[Bug 20456] New: Remove the C4::Serials::GetSubscriptionsFromBorrower
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20456 Bug ID: 20456 Summary: Remove the C4::Serials::GetSubscriptionsFromBorrower Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org C4::Serials::GetSubscriptionsFromBorrower is only used for the display of the routing list tab in staff. Bug 20400 implements this for the OPAC using Koha::Object. After switching staff the routine can be safely removed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20456 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20400 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 [Bug 20400] Add routing list tab to the patron account in OPAC -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20456 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 73119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73119&action=edit Bug 20456: Switch routling list tab in staff to use Koha::Object Bug 20400 added a routing list tab to the patron account in the OPAC using Koha::Object. This patch switches the routing list tab in the patron account in intranet over to the new code. It also adds an additional column showing the position of the patron on the routing list and fixes the search. To test: - Create some subscriptions with routing lists - Take a look at the patron accounts of several patrons having - no entries on routing lists - 1 entry on a routing list - entries on several routing lists - Make sure the display works correctly. - Search for a subscription and make sure search works. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20456 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 73120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73120&action=edit Bug 20456: Remove the C4::Serials::GetSubscriptionsFromBorrower Bug 20400 added a routing list tab to the patron account in the OPAC using Koha::Object. After changing the staff view too, we can now safely remove GetSubscriptionsFromBorrower as it is no longer used. To test: - Make sure that GetSubscriptionsFromBorrower is no longer used. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20456 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20456 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I assume this is a false positive as removing a method should reduce POD :) FAIL C4/Serials.pm OK critic OK forbidden patterns OK git manipulation OK pod FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 OK spelling OK valid -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20456 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_18_05_candidate CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20456 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73119|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 74667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74667&action=edit Bug 20456: Switch routling list tab in staff to use Koha::Object Bug 20400 added a routing list tab to the patron account in the OPAC using Koha::Object. This patch switches the routing list tab in the patron account in intranet over to the new code. It also adds an additional column showing the position of the patron on the routing list and fixes the search. To test: - Create some subscriptions with routing lists - Take a look at the patron accounts of several patrons having - no entries on routing lists - 1 entry on a routing list - entries on several routing lists - Make sure the display works correctly. - Search for a subscription and make sure search works. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20456 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73120|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 74668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74668&action=edit Bug 20456: Remove the C4::Serials::GetSubscriptionsFromBorrower Bug 20400 added a routing list tab to the patron account in the OPAC using Koha::Object. After changing the staff view too, we can now safely remove GetSubscriptionsFromBorrower as it is no longer used. To test: - Make sure that GetSubscriptionsFromBorrower is no longer used. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20456 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr Status|Needs Signoff |Failed QA --- Comment #6 from Séverine Queune <severine.queune@bulac.fr> --- No problem to use routing lists, but several display issues an patron's account : - the number of subscritpion lists always display "0", whatever the number of lists visible is - the position priority is always 1, even if the patron is not the first on list - routing lists are displayed even on patron's account that are not part of them Probably should not write that point here, but "Your routing list" tab in the OPAC always leads to an "Internal server error" (bug 20400). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20456 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 74675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74675&action=edit Bug 20456: (follow-up) Fix number of subscriptions and position display TT variables needed to be adjusted because of changes from bug 20400. Also: while we want logged_in_user in OPAC, we don't want that in staff. 1) Check the right number of subscriptions is displayed on top of the table 2) check the right position number is display for the routing list -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20456 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Séverine Queune from comment #6)
- the number of subscription lists always display "0", whatever the number of lists visible is
Thx for catching that - fixed!
- the position priority is always 1, even if the patron is not the first on list
Fixed!
- routing lists are displayed even on patron's account that are not part of them
The tab in staff is only dependent on the pref, not on the existence. I didn't touch that logic, could be a separate bug? But as we have the search option in staff, maybe we want to keep it?
Probably should not write that point here, but "Your routing list" tab in the OPAC always leads to an "Internal server error" (bug 20400).
This is a hard one. I can see it in the sandbox, but I can't replicate it on my installation with the same conditions (patron with one routing list, being first position). Better to move that to bug 20400. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20456 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20456 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74667|0 |1 is obsolete| | --- Comment #9 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 74683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74683&action=edit Bug 20456: Switch routling list tab in staff to use Koha::Object Bug 20400 added a routing list tab to the patron account in the OPAC using Koha::Object. This patch switches the routing list tab in the patron account in intranet over to the new code. It also adds an additional column showing the position of the patron on the routing list and fixes the search. To test: - Create some subscriptions with routing lists - Take a look at the patron accounts of several patrons having - no entries on routing lists - 1 entry on a routing list - entries on several routing lists - Make sure the display works correctly. - Search for a subscription and make sure search works. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20456 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74668|0 |1 is obsolete| | --- Comment #10 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 74684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74684&action=edit Bug 20456: Remove the C4::Serials::GetSubscriptionsFromBorrower Bug 20400 added a routing list tab to the patron account in the OPAC using Koha::Object. After changing the staff view too, we can now safely remove GetSubscriptionsFromBorrower as it is no longer used. To test: - Make sure that GetSubscriptionsFromBorrower is no longer used. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20456 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74675|0 |1 is obsolete| | --- Comment #11 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 74685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74685&action=edit Bug 20456: (follow-up) Fix number of subscriptions and position display TT variables needed to be adjusted because of changes from bug 20400. Also: while we want logged_in_user in OPAC, we don't want that in staff. 1) Check the right number of subscriptions is displayed on top of the table 2) check the right position number is display for the routing list Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20456 --- Comment #12 from Séverine Queune <severine.queune@bulac.fr> --- No more count problems ! (In reply to Katrin Fischer from comment #8)
(In reply to Séverine Queune from comment #6)
- routing lists are displayed even on patron's account that are not part of them
The tab in staff is only dependent on the pref, not on the existence. I didn't touch that logic, could be a separate bug? But as we have the search option in staff, maybe we want to keep it?
I didn't notice that before, as I only use routing list for tests and not in production. Behaviour is now different, only the routing lists patron is on are now displayed (empty list for patron that have no routing list). If that changes the original behaviour, maybe I shouldn't have signed it... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20456 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |alex.arnaud@biblibre.com |y.org | CC| |alex.arnaud@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20456 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #13 from Alex Arnaud <alex.arnaud@biblibre.com> --- All is ok for me. Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20456 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_18_05_candidate | --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- String changes, skipping for 18.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20456 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #15 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20456 Bug 20456 depends on bug 20400, which changed state. Bug 20400 Summary: Add routing list tab to the patron account in OPAC https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20456 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize@ptfs-europe | |.com --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.02 Thanks guys, I've made the decision to port this one back as it only just missed the 18.05.00 release due to string changes and doesn't fundamentally change functionality but rather tidies up code. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20456 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED --- Comment #17 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Depends on Bug 20400 not in 17.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org