[Bug 21004] New: Use modal to add and edit notes on receiving orders/shipments page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21004 Bug ID: 21004 Summary: Use modal to add and edit notes on receiving orders/shipments page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org See bug 20969, but for parcel.pl. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21004 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20969 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21004 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21004 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |johanna.raisa@koha-suomi.fi Status|NEW |Needs Signoff Assignee|oleonard@myacpl.org |johanna.raisa@koha-suomi.fi --- Comment #1 from Johanna Räisä <johanna.raisa@koha-suomi.fi> --- Created attachment 187077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187077&action=edit Bug 21004: Use modal to add and edit notes on receiving orders/shipments page This patch adds a modal to add and edit notes on the receiving orders/shipments page. Test Plan: 1. Navigate to the receiving orders/shipments page. 2. Add or edit a note. 3. See that a new page opens with a form to add or edit the note. 4. Apply the patch and reload the page. 5. Click to add or edit a note. 6. See that a modal opens with a form to add or edit the note. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21004 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21004 --- Comment #2 from Johanna Räisä <johanna.raisa@koha-suomi.fi> --- Created attachment 187078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187078&action=edit Bug 21004: (follow-up) remove unused modordernotes file The modordernotes.tt file is no longer used in the application, so it can be safely removed to clean up the codebase. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21004 --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Automatic patch test results: â ï¸ The patch applies with fuzzy option (ignoring whitespace). This may indicate minor conflicts that need to be resolved. Details: Patch applies with fuzzy option (ignoring whitespace) This is an automated message from the patch testing system. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21004 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com Status|Needs Signoff |Failed QA --- Comment #4 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- It does not apply cleanly please rebase! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21004 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187077|0 |1 is obsolete| | --- Comment #5 from Johanna Räisä <johanna.raisa@koha-suomi.fi> --- Created attachment 197252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197252&action=edit Bug 21004: Use modal to add and edit notes on receiving orders/shipments page This patch adds a modal to add and edit notes on the receiving orders/shipments page. Test Plan: 1. Navigate to the receiving orders/shipments page. 2. Add or edit a note. 3. See that a new page opens with a form to add or edit the note. 4. Apply the patch and reload the page. 5. Click to add or edit a note. 6. See that a modal opens with a form to add or edit the note. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21004 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187078|0 |1 is obsolete| | --- Comment #6 from Johanna Räisä <johanna.raisa@koha-suomi.fi> --- Created attachment 197253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197253&action=edit Bug 21004: (follow-up) remove unused modordernotes file The modordernotes.tt file is no longer used in the application, so it can be safely removed to clean up the codebase. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21004 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21004 Chris Mathevet <chris.mathevet@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21004 Chris Mathevet <chris.mathevet@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197253|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21004 --- Comment #7 from Chris Mathevet <chris.mathevet@inLibro.com> --- Created attachment 198688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198688&action=edit Bug 21004: (follow-up) remove unused modordernotes file The modordernotes.tt file is no longer used in the application, so it can be safely removed to clean up the codebase. Signed-off-by: Chris Mathevet <chris.mathevet@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21004 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |Laura.escamilla@bywatersolu |y.org |tions.com Comma delimited| |Koha-Suomi Oy list of Sponsors| | Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21004 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197252|0 |1 is obsolete| | Attachment #198688|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21004 --- Comment #8 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 206311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206311&action=edit Bug 21004: Use modal to add and edit notes on receiving orders/shipments page This patch adds a modal to add and edit notes on the receiving orders/shipments page. Test Plan: 1. Navigate to the receiving orders/shipments page. 2. Add or edit a note. 3. See that a new page opens with a form to add or edit the note. 4. Apply the patch and reload the page. 5. Click to add or edit a note. 6. See that a modal opens with a form to add or edit the note. Sponsored-by: Koha-Suomi Oy Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21004 --- Comment #9 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 206312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206312&action=edit Bug 21004: (follow-up) remove unused modordernotes file The modordernotes.tt file is no longer used in the application, so it can be safely removed to clean up the codebase. Signed-off-by: Chris Mathevet <chris.mathevet@inLibro.com> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21004 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@openfifth.co.u | |k Status|Passed QA |Failed QA --- Comment #10 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Hi all, 1 small thing, steps below. Patch #2 removed modordernotes.tt, but the note links on the basket, late orders and receive pages still point to modordernotes.pl. Opening one in a new tab now shows an empty 'Receive orders from' page. To reproduce: 1) Inside KTD, create a basket with one order: $ ktd --shell k$ perl -MKoha::Acquisition::Baskets -MKoha::Acquisition::Orders -e 'my $b = Koha::Acquisition::Basket->new({ booksellerid => 1, basketname => "follow-up" })->store; Koha::Acquisition::Order->new({ basketno => $b->basketno, biblionumber => 1, quantity => 1, budget_id => 1 })->store; print "basketno=", $b->basketno, "\n"' 2) Go to http://localhost:8081/cgi-bin/koha/acqui/basket.pl?basketno=<basketno> 3) Open 'Add internal note' in a new tab 4) Confirm it shows an empty 'Receive orders from' page The first patch works fine on its own, with modordernotes.tt kept as the page the links fall back to (the same way moddeliverydate.tt works for the delivery date modal). I think we should either: a) Obsolete patch #2, or b) Remove all hrefs pointing to modordernotes.pl and make modordernotes.pl POST-only (save and redirect) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org