[Bug 12210] New: Baker & Taylor book jackets not disabled when BakerTaylorBookstoreURL is not populated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12210 Bug ID: 12210 Summary: Baker & Taylor book jackets not disabled when BakerTaylorBookstoreURL is not populated Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: bartonski@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com The description of the BakerTaylorBookstoreURL syspref says "Baker and Taylor "My Library Bookstore" links should be accessed at https:// isbn (this should be filled in with something like ocls.mylibrarybookstore.com/MLB/actions/searchHandler.do?nextPage=bookDetails&parentNum=10923&key=). Leave it blank to disable these links." Leaving this syspref blank does not disable the links. Instead, they are populated without the bookstore URL: the cover image for ISBN 1575725738 will cause koha to make a request to http://1575725738, which will, of course, time out. Leaving BakerTaylorBookstoreURL blank should disable any URL that depends on this syspref, as stated in the syspref description. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12210 Peggy Thrasher <p.thrasher@dover.nh.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |p.thrasher@dover.nh.gov -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12210 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12210 --- Comment #1 from Galen Charlton <gmcharlt@gmail.com> --- Is this for a case where the library has BakerTaylorEnabled set to true (because they are getting cover images) but are not using the bookstore feature? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12210 --- Comment #2 from Peggy Thrasher <p.thrasher@dover.nh.gov> --- Yes. It is my library. Peggy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12210 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.14 |master --- Comment #3 from Galen Charlton <gmcharlt@gmail.com> --- Thanks. Here's is a statement of the expected behavior; please let me know if it's correct: * If BakerTaylorEnabled is off, all B&T content, including cover images and links to the bookstore should be disabled. * If BakerTaylorEnabled is on, B&T ContentCafe links should be displayed. * If BakerTaylorEnabled is on and BakerTaylorBookstoreURL is set to a value, B&T cover images should be displayed, with links to the bookstore. Here's a question: is it possible to get cover images from B&T without using their bookstore service, or do they go hand-in-hand? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12210 --- Comment #4 from Peggy Thrasher <p.thrasher@dover.nh.gov> --- Hi Galen, This is what they said about the book jackets (we purchase them from Baker and Taylor through EBSCO). So it sounds like we can remove the link (or make it point to the detail record - that would be my choice!) Hello Peggy, We have consulted with our senior colleague, and he agreed and said your developer is more than welcome to remove the link. Thanks again for your patience and let me know if there is anything else I can assist you with. Please let me know if you have any questions or if I can be of further assistance. This response was sent from our case management system. When replying, please use the “Reply” button and respond directly to this email to ensure your response is received and documented in this case. Regards, Michael Seretse-Khama Technical Support Representative NoveList, a division of EBSCO -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12210 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This 'might' be a good one for the Catalyst Academy.. marking as thus. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12210 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12210 Justin Vos <justinvos@live.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion CC| |justinvos@live.com --- Comment #6 from Justin Vos <justinvos@live.com> --- I don't have a username/password, but if someone is able to provide me a BakerTaylorUsername and BakerTaylorPassword login, I would be happy to test and fix this bug. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12210 --- Comment #7 from Peggy Thrasher <p.thrasher@dover.nh.gov> --- I have sent you credentials in an email. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12210 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12210 --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37451 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37451&action=edit Bug 12210 - Baker & Taylor book jackets not disabled when BakerTaylorBookstoreURL is not populated The description of the BakerTaylorBookstoreURL syspref says "Baker and Taylor "My Library Bookstore" links should be accessed at https:// isbn (this should be filled in with something like ocls.mylibrarybookstore.com/MLB/actions/searchHandler.do?nextPage=bookDetails&parentNum=10923&key=). Leave it blank to disable these links." Leaving this syspref blank does not disable the links. Instead, they are populated without the bookstore URL: the cover image for ISBN 1575725738 will cause koha to make a request to http://1575725738, which will, of course, time out. Leaving BakerTaylorBookstoreURL blank should disable any URL that depends on this syspref, as stated in the syspref description. Test Plan: 1) Apply this patch 2) Enable Baker & Taylor cover images, but *not* BakerTaylorBookstoreURL 3) Perform an OPAC search where you have B&T cover images in the results 4) Note the image links now direct you to the record details -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12210 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37451|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37529 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37529&action=edit Bug 12210 - Baker & Taylor book jackets not disabled when BakerTaylorBookstoreURL is not populated The description of the BakerTaylorBookstoreURL syspref says "Baker and Taylor "My Library Bookstore" links should be accessed at https:// isbn (this should be filled in with something like ocls.mylibrarybookstore.com/MLB/actions/searchHandler.do?nextPage=bookDetails&parentNum=10923&key=). Leave it blank to disable these links." Leaving this syspref blank does not disable the links. Instead, they are populated without the bookstore URL: the cover image for ISBN 1575725738 will cause koha to make a request to http://1575725738, which will, of course, time out. Leaving BakerTaylorBookstoreURL blank should disable any URL that depends on this syspref, as stated in the syspref description. Test Plan: 1) Apply this patch 2) Enable Baker & Taylor cover images, but *not* BakerTaylorBookstoreURL 3) Perform an OPAC search where you have B&T cover images in the results 4) Note the image links now direct you to the record details -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12210 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12210 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37529|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37530 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37530&action=edit Bug 12210 - Baker & Taylor book jackets not disabled when BakerTaylorBookstoreURL is not populated The description of the BakerTaylorBookstoreURL syspref says "Baker and Taylor "My Library Bookstore" links should be accessed at https:// isbn (this should be filled in with something like ocls.mylibrarybookstore.com/MLB/actions/searchHandler.do?nextPage=bookDetails&parentNum=10923&key=). Leave it blank to disable these links." Leaving this syspref blank does not disable the links. Instead, they are populated without the bookstore URL: the cover image for ISBN 1575725738 will cause koha to make a request to http://1575725738, which will, of course, time out. Leaving BakerTaylorBookstoreURL blank should disable any URL that depends on this syspref, as stated in the syspref description. Test Plan: 1) Apply this patch 2) Enable Baker & Taylor cover images, but *not* BakerTaylorBookstoreURL 3) Perform an OPAC search where you have B&T cover images in the results 4) Note the image links now direct you to the record details Signed-off-by: Sheila Kearns <sheila.kearns@state.vt.us> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12210 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12210 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12210 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37530|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 37551 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37551&action=edit [PASSED QA] Bug 12210 - Baker & Taylor book jackets not disabled when BakerTaylorBookstoreURL is not populated The description of the BakerTaylorBookstoreURL syspref says "Baker and Taylor "My Library Bookstore" links should be accessed at https:// isbn (this should be filled in with something like ocls.mylibrarybookstore.com/MLB/actions/searchHandler.do?nextPage=bookDetails&parentNum=10923&key=). Leave it blank to disable these links." Leaving this syspref blank does not disable the links. Instead, they are populated without the bookstore URL: the cover image for ISBN 1575725738 will cause koha to make a request to http://1575725738, which will, of course, time out. Leaving BakerTaylorBookstoreURL blank should disable any URL that depends on this syspref, as stated in the syspref description. Test Plan: 1) Apply this patch 2) Enable Baker & Taylor cover images, but *not* BakerTaylorBookstoreURL 3) Perform an OPAC search where you have B&T cover images in the results 4) Note the image links now direct you to the record details Signed-off-by: Sheila Kearns <sheila.kearns@state.vt.us> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Only affects Baker & Taylor related parts of the code. Read the code carefully, but couldn't test in the OPAC. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12210 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12210 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Keywords|Academy | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org