[Bug 18581] New: Add standard edit and delete buttons to suggestions list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18581 Bug ID: 18581 Summary: Add standard edit and delete buttons to suggestions list Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/suggestion/suggestion.pl OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Right now the list of suggestions in the staff client has an "[edit]" link but no corresponding delete button, although there is a delete button on the detailed view. I propose to add the standard pair of edit and delete buttons to the table. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18581 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18581 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 63385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63385&action=edit Bug 18581 - Add standard edit and delete buttons to suggestions list This patch modifies the table of suggestions in the staff client, moving the edit link to the standard last column and styling it correctly. A delete button is added as well. Unrelated change: I removed the column containing suggestionid because I don't think it's human-relevant information. To test, apply the patch and go to Acquisitions -> Suggestions. - In each tab, the table of suggestions should have an unsorted last column containing "edit" and "delete" links which should be styled correctly and working correctly. - On the detailed view of a suggestion, the "delete" button in the toolbar should still work correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18581 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18581 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63385|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 63402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63402&action=edit [SIGNED OFF] Bug 18581 - Add standard edit and delete buttons to suggestions list This patch modifies the table of suggestions in the staff client, moving the edit link to the standard last column and styling it correctly. A delete button is added as well. Unrelated change: I removed the column containing suggestionid because I don't think it's human-relevant information. To test, apply the patch and go to Acquisitions -> Suggestions. - In each tab, the table of suggestions should have an unsorted last column containing "edit" and "delete" links which should be styled correctly and working correctly. - On the detailed view of a suggestion, the "delete" button in the toolbar should still work correctly. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18581 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18581 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63402|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 66469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66469&action=edit Bug 18581 - Add standard edit and delete buttons to suggestions list This patch modifies the table of suggestions in the staff client, moving the edit link to the standard last column and styling it correctly. A delete button is added as well. Unrelated change: I removed the column containing suggestionid because I don't think it's human-relevant information. To test, apply the patch and go to Acquisitions -> Suggestions. - In each tab, the table of suggestions should have an unsorted last column containing "edit" and "delete" links which should be styled correctly and working correctly. - On the detailed view of a suggestion, the "delete" button in the toolbar should still work correctly. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18581 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18581 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18581 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED --- Comment #5 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Enhancement not pushed to 17.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org