http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7915 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Version|rel_3_8 |master -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7915 Ebin Joseph <ebin.joseph@osslabs.biz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff CC| |ebin.joseph@osslabs.biz -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7915 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- This doesn't have a system preference to turn it on and off. Is that an omission which should be addressed in a revision, or is that a feature which was dropped? What was mean by "house the content of the card?" There are some issues I see with this: 1. There are violations of the capitalization rule described in Bug 2780. 2. The printable card view has a label "Membership No" but the term we standardize on is "Card number." 3. The printed card show the patron image whether or not the patronimages system preference is enabled. 4. The printable card view page has invalid XHTML. 5. The patch adds a CSS file, screen.css. This CSS could probably be embedded in the body of the page since it is "single-purpose." Another idea would be to put the CSS into its own system preference so that libraries could customize it. In any case, "screen.css" is not a descriptive enough name. If the CSS isn't moved into the template the file name should at least be changed. 6. The "Print card" option is added to the toolbar used on some patron-related pages but not to the toolbar used on others. These should be consistent (Sorry, Bug 6261 is still open). -- You are receiving this mail because: You are watching all bug changes.