[Bug 35489] New: Holds on items with no barcode are missing an input for itemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35489 Bug ID: 35489 Summary: Holds on items with no barcode are missing an input for itemnumber Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com This causes a move/loss of data on the holds form (request.pl) when holds are adjusted To test: 1 - Find a record in the catalog and add or edit items to have one item with a barcode and one without 2 - Place an item level hold on the item with no barcode 3 - Place another hold for a different patron on the item with a barcode 4 - From the holds table add an expiration date to the hold with a barcode and save 5 - Note the hold on the item with no barcode is now on the item with a barcode and the other hold is now a next available hold -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35489 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35489 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 159588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159588&action=edit Bug 35489: Add a hidden input for itemnumber even if item has no barcode This page is a single form, all fields must have inputs to avoid data loss/mismatch To test: 1 - Find a record in the catalog and add or edit items to have one item with a barcode and one without 2 - Place an item level hold on the item with no barcode 3 - Place another hold for a different patron on the item with a barcode 4 - From the holds table add an expiration date to the hold with a barcode and save 5 - Note the hold on the item with no barcode is now on the item with a barcode and the other hold is now a next available hold 6 - Delete the holds 7 - Apply patch 8 - Repeat 2-4 9 - Confirm the itemnumbers for the holds have not changed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35489 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh@dubcolib.org, | |martin.renvoize@ptfs-europe | |.com, tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35489 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35489 --- Comment #2 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 159607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159607&action=edit Bug 35489: This page is a ingle form, all fields must have inputs to avoid data loss/mismatch To test: 1 - Find a record in the catalog and add or edit items to have one item with a barcode and one without 2 - Place an item level hold on the item with no barcode 3 - Place another hold for a different patron on the item with a barcode 4 - From the holds table add an expiration date to the hold with a barcode and save 5 - Note the hold on the item with no barcode is now on the item with a barcode and the other hold is now a next available hold 6 - Delete the holds 7 - Apply patch 8 - Repeat 2-4 9 - Confirm the itemnumbers for the holds have not changed Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35489 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- The sandbox seems to have done something weird to the attachments on this bug, but it was my intent to sign off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35489 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35489 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159588|0 |1 is obsolete| | --- Comment #4 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 159929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159929&action=edit Bug 35489: Add a hidden input for itemnumber even if item has no barcode This page is a single form, all fields must have inputs to avoid data loss/mismatch To test: 1 - Find a record in the catalog and add or edit items to have one item with a barcode and one without 2 - Place an item level hold on the item with no barcode 3 - Place another hold for a different patron on the item with a barcode 4 - From the holds table add an expiration date to the hold with a barcode and save 5 - Note the hold on the item with no barcode is now on the item with a barcode and the other hold is now a next available hold 6 - Delete the holds 7 - Apply patch 8 - Repeat 2-4 9 - Confirm the itemnumbers for the holds have not changed Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35489 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Attachment #159607|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35489 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #5 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Works, makes sense, QA script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35489 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35489 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35489 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m Version(s)|24.05.00 |24.05.00,23.11.02 released in| | --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35489 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- Please rebase this for 23.05.x if needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35489 --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 160573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160573&action=edit Bug 35489: [23.05.x] Add a hidden input for itemnumber even if item has no barcode This page is a single form, all fields must have inputs to avoid data loss/mismatch To test: 1 - Find a record in the catalog and add or edit items to have one item with a barcode and one without 2 - Place an item level hold on the item with no barcode 3 - Place another hold for a different patron on the item with a barcode 4 - From the holds table add an expiration date to the hold with a barcode and save 5 - Note the hold on the item with no barcode is now on the item with a barcode and the other hold is now a next available hold 6 - Delete the holds 7 - Apply patch 8 - Repeat 2-4 9 - Confirm the itemnumbers for the holds have not changed Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35489 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00,23.11.02 |24.05.00,23.11.02,23.05.08 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 23.05.x for upcoming 23.05.08. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35489 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35489 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable CC| |wainuiwitikapark@catalyst.n | |et.nz Version(s)|24.05.00,23.11.02,23.05.08 |24.05.00,23.11.02,23.05.08, released in| |22.11.28 --- Comment #11 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Applied to 22.11 for 22.11.28 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35489 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org