http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12550 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29609 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29609&action=edit Bug 12550 - Add ability to delay loading of patron's checkouts in circulation and patron details Now that a patron's checkouts are loaded asynchronously, we can further improve Koha's performance by not loading the checkouts table when it is not needed. For example, if a librarian is checking out 5 items to a patron, we really don't need to load the table during the scanning of items 1 to 4, just for item 5. Another example would be browsing to the patron details table in order to change a patron's password. I propose we add two separate system preferences to add a timer for loading the patron's checkouts table, one for circulation and one for patron details. That way a library can choose to have enough delay so that most librarians can scan items repeatedly without loading the checkouts table, and can have the patron details table load more quickly if they wish. In addition, setting one or both timeouts to 0 will cause the system to act as it currently does. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Test circulation and patron details, no changes should be noted 4) Set CheckoutsTableSecondsToLoadCirculation and CheckoutsTableSecondsToLoadPatronDetails to some number of seconds. 5) Test again, note tables load after the set number of seconds 6) Test the "Load now" button, note it triggers the table to load immediately -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12550 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29609|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29610 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29610&action=edit Bug 12550 - Add ability to delay loading of patron's checkouts in circulation and patron details Now that a patron's checkouts are loaded asynchronously, we can further improve Koha's performance by not loading the checkouts table when it is not needed. For example, if a librarian is checking out 5 items to a patron, we really don't need to load the table during the scanning of items 1 to 4, just for item 5. Another example would be browsing to the patron details table in order to change a patron's password. I propose we add two separate system preferences to add a timer for loading the patron's checkouts table, one for circulation and one for patron details. That way a library can choose to have enough delay so that most librarians can scan items repeatedly without loading the checkouts table, and can have the patron details table load more quickly if they wish. In addition, setting one or both timeouts to 0 will cause the system to act as it currently does. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Test circulation and patron details, no changes should be noted 4) Set CheckoutsTableSecondsToLoadCirculation and CheckoutsTableSecondsToLoadPatronDetails to some number of seconds. 5) Test again, note tables load after the set number of seconds 6) Test the "Load now" button, note it triggers the table to load immediately -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12550 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29610|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29615 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29615&action=edit Bug 12550 - Add ability to delay loading of patron's checkouts in circulation and patron details Now that a patron's checkouts are loaded asynchronously, we can further improve Koha's performance by not loading the checkouts table when it is not needed. For example, if a librarian is checking out 5 items to a patron, we really don't need to load the table during the scanning of items 1 to 4, just for item 5. Another example would be browsing to the patron details table in order to change a patron's password. Test Plan: 1) Apply this patch 2) Browse to circulation.pl for a patron 3) Note the table is not loaded automatically 4) Click the "Show checkouts" button 5) Note the checkouts table loads 6) Check the "Always show checkouts immediately" checkbox 7) Reload the page, the checkouts should now load immediately 8) Repeat steps 3-7 for the patron details page ( moremember.pl ) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12550 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29615|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 29618 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29618&action=edit Bug 12550 - Add ability to delay loading of patron's checkouts in circulation and patron details Now that a patron's checkouts are loaded asynchronously, we can further improve Koha's performance by not loading the checkouts table when it is not needed. For example, if a librarian is checking out 5 items to a patron, we really don't need to load the table during the scanning of items 1 to 4, just for item 5. Another example would be browsing to the patron details table in order to change a patron's password. Test Plan: 1) Apply this patch 2) Browse to circulation.pl for a patron 3) Note the table is not loaded automatically 4) Click the "Show checkouts" button 5) Note the checkouts table loads 6) Check the "Always show checkouts immediately" checkbox 7) Reload the page, the checkouts should now load immediately 8) Repeat steps 3-7 for the patron details page ( moremember.pl ) Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Amended patch: remove trailing spaces. Note: I am not sure the checkbox is at the best place, but I don't have a better suggestion. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12550 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Patch complexity|--- |Medium patch QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | --- Comment #6 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- This one is on top now. Will add this report to my QA to-do list (for nontrivial patches :) But if someone else wants to QA this first, no problem whatsoever.. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12550 --- Comment #8 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #7)

(In reply to M. de Rooy from comment #6)

...

Will add this report to my QA to-do list (for nontrivial patches :)

If I remember correctly, this is more a simple patch than a medium. Most of the part of the changes is indentation.

Could be. I just looked at the number of lines while scrolling through.. Thx -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12550 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Happy to pass this. It, is indeed, actually a pretty trivial patch; some minor re-factoring which knocks out allot of indenting and then a few extra bits of code for functionality. I'm happy there are no regressions and it's a very worthwhile addition. I do agree with what Jonathan says about the check box not feeling quite right.. but can't come up with a better position either.. I'll ask Owen to take a look at some point ;) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12550 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_4_candidate -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12550 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31160|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 31965 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31965&action=edit Bug 12550 - Add ability to delay loading of patron's checkouts in circulation and patron details Rebased patch. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12550 --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 31968 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31968&action=edit Bug 12550 [QA Followup] - Make checking the checkbox load the table of checkouts -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12550 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_5_candidate | CC| |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12550 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13196 -- You are receiving this mail because: You are watching all bug changes.