https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726 Michael Hafen <michael.hafen@washk12.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|cnighswonger@foundations.ed |michael.hafen@washk12.org |u | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726 --- Comment #3 from Michael Hafen <michael.hafen@washk12.org> --- Test plan: 1. start a new batch in the patron card creator (Tools -> Patron card creator -> New -> card batch) 2. click the Add patron(s) button. Observe that Category and Library are the only options. 3. Close search for patron window. 4. Apply patch. 5. click the Add patron(s) button. Observe that you can now search for patrons by their sort1 and sort2 values. 6. perform a search and observe the 'Select all | Clear all | Add selected patrons' links and button. 7. use the Select all link to select all the patrons found by the search. 8. use the Add selected patrons button to add the selected patrons to the card batch's Add by borrowernumber(s) text input field. 9. close the search for patron window. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726 Michael Hafen <michael.hafen@washk12.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122991|0 |1 is obsolete| | Attachment #129203|0 |1 is obsolete| | --- Comment #5 from Michael Hafen <michael.hafen@washk12.org> --- Created attachment 134003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134003&action=edit Bug 28726 - Add sort1 and sort2 to patron card creator - patron search. Add sort1 and sort2 filters, checkboxes and select/clear all links, and a add selected button to the patron search (for the patron card creator). Rebase after change to how the patron search works. Test plan: 1. start a new batch in the patron card creator (Tools -> Patron card creator -> New -> card batch) 2. click the Add patron(s) button. Observe that Category and Library are the only options. 3. Close search for patron window. 4. Apply patch. 5. click the Add patron(s) button. Observe that you can now search for patrons by their sort1 and sort2 values. 6. perform a search and observe the 'Select all | Clear all | Add selected patrons' links and button. 7. use the Select all link to select all the patrons found by the search. 8. use the Add selected patrons button to add the selected patrons to the card batch's Add by borrowernumber(s) text input field. 9. close the search for patron window. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Michaeal, could you please rebase against the master branch? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 28726: Add sort1 and sort2 to patron card creator - patron search. error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc). error: could not build fake ancestor Patch failed at 0001 Bug 28726: Add sort1 and sort2 to patron card creator - patron search. hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-28726---Add-sort1-and-sort2-to-patron-card-cre-61BF84.patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Please don't forget to switch back the status when you rebase :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726 --- Comment #10 from Michael Hafen <michael.hafen@washk12.org> --- (In reply to Emmanuel Bétemps from comment #9)

I got this message after applying the patch (which is not displayed in the KohaGitLog) (I test using a sandbox)

------------------------------------------- Bug 28726 - Add sort1 and sort2 to patron card creator patron search

137854 - Bug 28726: Add sort1 and sort2 to patron card creator - patron search.

Apply? [(y)es, (n)o, (i)nteractive] Traceback (most recent call last): File "/usr/bin/git-bz", line 2716, in <module> applied = do_apply(bug_ref) File "/usr/bin/git-bz", line 1827, in do_apply users = bug.server.get_xmlrpc_proxy().User.get({ 'names': [patch.attacher] })['users'] File "/usr/lib/python2.7/xmlrpclib.py", line 1243, in __call__ return self.__send(self.__name, args) File "/usr/lib/python2.7/xmlrpclib.py", line 1602, in __request verbose=self.__verbose File "/usr/lib/python2.7/xmlrpclib.py", line 1283, in request return self.single_request(host, handler, request_body, verbose) File "/usr/lib/python2.7/xmlrpclib.py", line 1331, in single_request response.msg, xmlrpclib.ProtocolError: <ProtocolError for bugs.koha-community.org/xmlrpc.cgi: 404 Not Found>

To be that looks like a problem with the koha-community.org git server. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Ok, I have the same error. Chris said it could be related to git-bz not working with ipv6. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Michael, please check the attache file, this doesn't appear to be a correct patch file, but only the commit message. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726 Michael Hafen <michael.hafen@washk12.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726 Emmanuel Bétemps <e.betemps@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #17 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- + @sort1 = sort {$a cmp $b} uniq( Koha::Patrons->search($sort_filter)->get_column('sort1') ); This is terrible if you have lot of patrons. You should at least do the unique (distinct) at the DBMS level. What about the following suggestion: you could display sort1 and sort2 authorised values in the dropdown list, or simply display a search input. You could also add it to the table's headers (filter at the top of the column). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726 --- Comment #19 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Thanks Katrin, that's exactly what I wanted to say but some parts got lost when I rephrased the comment apparently. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Michaeal, could you take a look at changing the form as suggested in comment#19? The patron edit form could be a good starting place for this. I realize there is another place in Koha at least where it's done like you do here - the statistics wizard for patrons - but I believe it would be worth changing and changing it there too. I can easily see a library using the field for individual notes. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726 Michael Hafen <michael.hafen@washk12.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion --- Comment #22 from Michael Hafen <michael.hafen@washk12.org> --- I'll take a look, but it will mean a big change to how I'm handling patrons, as my use case is a little different. I'm in a school district, and all our patron info comes in from LDAP. We aren't using the Authorized Values categories for the sort fields. I wasn't even planning on trying to use them since our servers handle building those drop down pretty well as is. We also have Independant Branches on, so the list gets filtered by branchcode, so I'd also have to see if the Authorized Values categories can do that too. We have 72079 patrons with 2975 unique sort2 values, but each library has no more than 200 values in the sort2, and it's usually closer to or less than 100 values. Even as the SuperLibrarian, when I load the patron card create patron search window it doesn't take more than a second on my servers, so I've been fine with it that way. I can see that this isn't optimal, but the alternative is creating a cron script to scrape LDAP to pull all the possible values for those two attributes to sync the Authorized Values categories. Anyway, I'll have to look at the Authorized Values stuff to see if it can meet our use case. And I don't mind changing the patch to use that instead, and then changing it again in my local fork to scrape the database instead. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726 Michael Hafen <michael.hafen@washk12.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138653|0 |1 is obsolete| | --- Comment #24 from Michael Hafen <michael.hafen@washk12.org> --- Created attachment 141405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141405&action=edit Bug 28726: Add sort1 and sort2 to patron card creator - patron search. [ 2022-10-05 updated for recommendations: AV and select2 ] Bug 28726: Add sort1 and sort2 to patron card creator - patron search. Also adds a select all / clear all and checkboxes. Test plan: 1. start a new batch in the patron card creator (Tools -> Patron card creator -> New -> card batch) 2. click the Add patron(s) button. Observe that Category and Library are the on ly options. 3. Close search for patron window. 4. Apply patch. 5. click the Add patron(s) button. Observe that you can now search for patrons by their sort1 and sort2 values. 6. perform a search and observe the 'Select all | Clear all | Add selected patro ns' links and button. 7. use the Select all link to select all the patrons found by the search. 8. use the Add selected patrons button to add the selected patrons to the card b atch's Add by borrowernumber(s) text input field. 9. close the search for patron window. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726 --- Comment #25 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 143646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143646&action=edit Bug 28726: Add sort1 and sort2 to patron card creator - patron search. Also adds a select all / clear all and checkboxes. Test plan: 1. start a new batch in the patron card creator (Tools -> Patron card creator -> New -> card batch) 2. click the Add patron(s) button. Observe that Category and Library are the only options. 3. Close search for patron window. 4. Apply patch. 5. click the Add patron(s) button. Observe that you can now search for patrons by their sort1 and sort2 values. 6. perform a search and observe the 'Select all | Clear all | Add selected patrons' links and button. 7. use the Select all link to select all the patrons found by the search. 8. use the Add selected patrons button to add the selected patrons to the card batch's Add by borrowernumber(s) text input field. 9. close the search for patron window. Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Attachment #141405|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726 --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Kyle M Hall from comment #26)

I don't think we should be pre-populating a select pulldown from sort1/2. These fields could contain unique information, and a library could have tens or hundreds of thousands of patrons. In that case bad things (tm) would happen. I think it would be best of those fields were free text fields.

Just to clarify, if AV values exist, would you be ok with populating from the config (authorised values) instead of the data? If the category has no entries, we do freetext, otherwise a pull down. That matches the behviour in other spots, like the patron edit/display forms and the statistical wizard for patrons. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726 --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think maybe it will be easier to keep it simple and have a text field or a pull down from AV depending on config first. As Kyle said sort fields can have unique values, so you will have an endless pull down with one entry per patron, this is not useful. Also: pull down and free text will match how this field is used in all other places in Koha (= existing pattern). Further improvements could then be made on a follow-up bug. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726 --- Comment #31 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Michael Hafen from comment #30)

Making it a free text field doesn't work for me. In my opinion having a free text input doesn't work well for a filter field on a search page; especially in my case where the librarians don't control that field, it's controlled by LDAP.

Katrin mentioned the Patron Statistics Wizard. Looking at that, what's done for the sort2 column is to pull distinct values limited to 200. That would work for me, that should be well under what my librarians would encounter in that field.

Would doing that instead be acceptable?

It won't work for any library that stored an identifier or unique value in there that has more than 200 patrons. They would see an incomplete pull down. Also: a 200 entry pull down is not really nice to use? Actually I was not aware the wizard did that :( we should fix it as well. I'll claim the patron form then as the example and the batch patron modification templates (sorry). Why will a free text not work? If they have no idea what they are looking for, will also not be very helpful? I think it's a specific use case we are dealing with here that I'd like to understand better. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726 --- Comment #33 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We'll need something that works universally. The auto-complete seemed like a good idea, but I'd like Kyle and others to comment on performance concerns. Koha's tables are case insensitive in the database - Koha doesn't care about it in searches that are SQL based. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726 Michael Hafen <michael.hafen@washk12.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #35 from Michael Hafen <michael.hafen@washk12.org> --- I didn't even realize that the sql search would be case-insensitive. Now that you mention it, of course it is. Anyway, here's a patch that just pulls from AV Bsort1 and Bsort2, using av-build-dropbox.inc, so it's either a select or an input. I can do otherwise on my local fork if it upsets my librarians (which I expect it will). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726 --- Comment #36 from solene.ngamga@inlibro.com --- Created attachment 148489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148489&action=edit Bug 28726: Add sort1 and sort2 to patron card creator - patron search. Also adds a select all / clear all and checkboxes. Test plan: 1. start a new batch in the patron card creator (Tools -> Patron card creator -> New -> card batch) 2. click the Add patron(s) button. Observe that Category and Library are the only options. 3. Close search for patron window. 4. Apply patch. 5. click the Add patron(s) button. Observe that you can now search for patrons by their sort1 and sort2 values. 6. perform a search and observe the 'Select all | Clear all | Add selected patrons' links and button. 7. use the Select all link to select all the patrons found by the search. 8. use the Add selected patrons button to add the selected patrons to the card batch's Add by borrowernumber(s) text input field. 9. close the search for patron window. Signed-off-by: Solene Ngamga <solene.ngamga@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147477|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726 --- Comment #38 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- If I am adding borrowers to the patron card batch, I am still seeing the box "There are no patrons in this batch" and I have no possibility to go further? Could be that I am missing config data for this module still, but this form should be more helpful. Probably out of scope, but it limits testing of this change. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726 --- Comment #40 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Michael Hafen from comment #39) Thanks.

8. use the Add selected patrons button to add the selected patrons to the card batch's Add by borrowernumber(s) text input field in the main window.

This is the confusing part. Since I clicked on that button before selecting the patrons, it is quite strange that you should click it again to kind of confirm the action you did. It is outside the scope of this report, but the operation is not intuitive. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148489|0 |1 is obsolete| | --- Comment #41 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 150650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150650&action=edit Bug 28726: Add sort1 and sort2 to patron card creator - patron search. Also adds a select all / clear all and checkboxes. Test plan: 1. start a new batch in the patron card creator (Tools -> Patron card creator -> New -> card batch) 2. click the Add patron(s) button. Observe that Category and Library are the only options. 3. Close search for patron window. 4. Apply patch. 5. click the Add patron(s) button. Observe that you can now search for patrons by their sort1 and sort2 values. 6. perform a search and observe the 'Select all | Clear all | Add selected patrons' links and button. 7. use the Select all link to select all the patrons found by the search. 8. use the Add selected patrons button to add the selected patrons to the card batch's Add by borrowernumber(s) text input field. 9. close the search for patron window. Signed-off-by: Solene Ngamga <solene.ngamga@inLibro.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726 --- Comment #43 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- This patch is actually adding Sort1 and Sort2 to all patrons searches. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #45 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- <div class="searchheader fh-fixedHeader" id="searchheader" style=""> This empty div is visible when I search for patrons in the popup: https://snipboard.io/2zBDoA.jpg -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726 Michael Hafen <michael.hafen@washk12.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34209 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34209 [Bug 34209] Follow up on Bug 28726 - move whole search header div into checkbox column condition -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|34233 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34233 [Bug 34233] Pickup location pulldowns in request.pl are blank -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |Pushed to stable --- Comment #48 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Needed for simple backport of 34094 and the tree above it. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726 --- Comment #49 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726 Michael Hafen <michael.hafen@washk12.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34592 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34592 [Bug 34592] The Patron Search window, given just a sort field value, doesn't work -- You are receiving this mail because: You are watching all bug changes.