https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25211 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 103280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103280&action=edit Bug 25211: Add missing share icon to OPAC lists page This patch adds a Font Awesome icon to the "Share" links on the list of lists in the OPAC. To test, apply the patch and log in to the OPAC as a user who has one or more private lists. - Go to Lists -> Your lists - In the table of your lists, each list should have a "Share" link with an icon. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25211 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103280|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 103315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103315&action=edit Bug 25211: Add missing share icon to OPAC lists page This patch adds a Font Awesome icon to the "Share" links on the list of lists in the OPAC. To test, apply the patch and log in to the OPAC as a user who has one or more private lists. - Go to Lists -> Your lists - In the table of your lists, each list should have a "Share" link with an icon. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Don't forget to enable OpacAllowSharingPrivateLists Works ok -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25211 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am trying to trest this, but I got real trouble getting the share link to show on master with and without the patch - I did switch on OpacAllowSharingPrivateLists. Can someone help? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25211 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Owen, on hover the 3 links have different behaviours: "Edit" is not underlined "Delete" is not underlined and red "Shared" is underlined I think "Shared" should not be underlined. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25211 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Jonathan Druart from comment #5)

I think "Shared" should not be underlined.

I have filed Bug 25276 for that issue. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25211 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103315|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 103679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103679&action=edit Bug 25211: Add missing share icon to OPAC lists page This patch adds a Font Awesome icon to the "Share" links on the list of lists in the OPAC. To test, apply the patch and log in to the OPAC as a user who has one or more private lists. - Go to Lists -> Your lists - In the table of your lists, each list should have a "Share" link with an icon. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Don't forget to enable OpacAllowSharingPrivateLists Works ok Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25211 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25276 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25276 [Bug 25276] Correct hover style of list share button in the OPAC -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25211 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---

That was not it, it looks like I can't save the syspref change and was missing the error (instead of success) modal:

XHRPOSThttp://localhost:8081/cgi-bin/koha/svc/config/systempreferences/ [HTTP/1.1 500 Internal Server Error 58ms] Can't open /var/log/koha/kohadev/opac-error.log (Permission denied) at /usr/share/perl5/Log/Log4perl/Appender/File.pm line 143 Eval {...} at /usr/share/perl5/Log/Log4perl/Appender/File.pm line 138 Log::Log4perl::Appender::File::file_open('Log::Log4perl::Appender:: File=HASH(0x55cef5d65b70)') called at /usr/share/perl5/Log/Log4perl/Appender/File.pm line

Filed bug 25284 for this - unrelated to the change here. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25211 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25211 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Version(s)|20.05.00, 19.11.06 |20.05.00, 19.11.06, released in| |19.05.11 Status|Pushed to stable |Pushed to oldstable --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.11 -- You are receiving this mail because: You are watching all bug changes.