[Bug 14487] New: Warns from returns.pl during checkin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14487 Bug ID: 14487 Summary: Warns from returns.pl during checkin Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Circulation Assignee: indradg@gmail.com Reporter: indradg@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Suppress these warns during returning an item returns.pl: Use of uninitialized value $holdingBranch in string eq at /home/l2c2technologies/koha/circ/returns.pl line 623., referer: http://kohamaster.l2c2.co.in/cgi-bin/koha/members/readingrec.pl?borrowernumb... returns.pl: Use of uninitialized value $collectionBranch in string eq at /home/l2c2technologies/koha/circ/returns.pl line 623., referer: http://kohamaster.l2c2.co.in/cgi-bin/koha/members/readingrec.pl?borrowernumb... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14487 --- Comment #1 from Indranil Das Gupta <indradg@gmail.com> --- (In reply to Indranil Das Gupta from comment #0)
Suppress these warns during returning an item
The warns have stopped for some reason. I need to investigate this a bit more. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14487 --- Comment #2 from Indranil Das Gupta <indradg@gmail.com> --- Created attachment 40773 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40773&action=edit Bug 14487 - silence warns during checkin Test plan ========= 1/ check out an item and then check it back in. 1/ check the logs after the check-in to see the warns from returns.pl line 623 of : (a) Use of uninitialized value $holdingBranch (b) Use of uninitialized value $collectionBranch 2/ apply patch 3/ check out and check-in again. no warns are recorded this time. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14487 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |BLOCKED --- Comment #3 from Indranil Das Gupta <indradg@gmail.com> --- (In reply to Indranil Das Gupta from comment #1)
(In reply to Indranil Das Gupta from comment #0)
Suppress these warns during returning an item
The warns have stopped for some reason. I need to investigate this a bit more.
please ignore comment #1 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14487 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14487 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40773|0 |1 is obsolete| | --- Comment #4 from Indranil Das Gupta <indradg@gmail.com> --- Created attachment 40783 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40783&action=edit Bug 14487 - silence warns during checkin Test plan ========= 1/ check out an item and then check it back in. 1/ check the logs after the check-in to see the warns from returns.pl line 623 of : (a) Use of uninitialized value $holdingBranch (b) Use of uninitialized value $collectionBranch 2/ apply patch 3/ check out and check-in again. no warns are recorded this time. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14487 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14487 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40783|0 |1 is obsolete| | --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 40784 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40784&action=edit Bug 14487 - silence warns during checkin Test plan ========= 1/ check out an item and then check it back in. 1/ check the logs after the check-in to see the warns from returns.pl line 623 of : (a) Use of uninitialized value $holdingBranch (b) Use of uninitialized value $collectionBranch 2/ apply patch 3/ check out and check-in again. no warns are recorded this time. NOTE: Under Debian Jessie, there are other messages. Additionally, this only corrects the line 623 ones. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14487 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED CC| |mtompset@hotmail.com --- Comment #6 from M. Tompsett <mtompset@hotmail.com> --- [Fri Jul 03 17:00:54.327367 2015] [cgi:error] [pid 2960] [client 192.168.45.37:62532] AH01215: [Fri Jul 3 17:00:54 2015] returns.pl: Use of uninitialized value in hash element at /home/mtompset/kohaclone/circ/returns.pl line 469., referer: http://library-admin.debiankoha.ca/cgi-bin/koha/circ/returns.pl This probably applies to more than just Debian Jessie. [Fri Jul 03 17:00:54.334787 2015] [cgi:error] [pid 2960] [client 192.168.45.37:62532] AH01215: [Fri Jul 3 17:00:54 2015] returns.pl: CGI::param called in list context from package main line 620, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436., referer: http://library-admin.debiankoha.ca/cgi-bin/koha/circ/returns.pl This probably applies to only Debian Jessie context. Moving this back to ASSIGNED, since I believe 469 should be fixed at least based on the bug description given. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14487 --- Comment #7 from M. Tompsett <mtompset@hotmail.com> --- (In reply to M. Tompsett from comment #6)
[Fri Jul 03 17:00:54.327367 2015] [cgi:error] [pid 2960] [client 192.168.45.37:62532] AH01215: [Fri Jul 3 17:00:54 2015] returns.pl: Use of uninitialized value in hash element at /home/mtompset/kohaclone/circ/returns.pl line 469., referer: http://library-admin.debiankoha.ca/cgi-bin/koha/circ/returns.pl
Trigger case: check in something that isn't checked out. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14487 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14487 --- Comment #8 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 40785 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40785&action=edit Bug 14487: Noise best detected under Debian 8 The first error is caused by the fact that $messages->{'IsPermanent'} is undefined. The second error is caused by querying the CGI parameter 'barcode' inside a function call. This is not required. There is a variable $barcode set with the parameter. Changed to use the variable. TEST PLAN ---------- 1) Test first patch. 2) Clear the log 3) Put in a barcode which is not checked out. 4) Check the log. -- should be two errors. One about a hash, the other will only be detectable under Debian 8. 5) Apply this second patch 6) Clear the log 7) Put in a barcode which is not checked out. 8) Check the log. -- should be empty. 9) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14487 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40785|0 |1 is obsolete| | --- Comment #9 from Indranil Das Gupta <indradg@gmail.com> --- Created attachment 40788 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40788&action=edit Bug 14487: Noise best detected under Debian 8 The first error is caused by the fact that $messages->{'IsPermanent'} is undefined. The second error is caused by querying the CGI parameter 'barcode' inside a function call. This is not required. There is a variable $barcode set with the parameter. Changed to use the variable. TEST PLAN ---------- 1) Test first patch. 2) Clear the log 3) Put in a barcode which is not checked out. 4) Check the log. -- should be two errors. One about a hash, the other will only be detectable under Debian 8. 5) Apply this second patch 6) Clear the log 7) Put in a barcode which is not checked out. 8) Check the log. -- should be empty. 9) run koha qa test tools Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14487 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@quecheelibrary.org Status|Needs Signoff |Signed Off --- Comment #10 from Nick Clemens <nick@quecheelibrary.org> --- All patches appear to be signed off, marking as such -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14487 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #11 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Nick Clemens from comment #10)
All patches appear to be signed off, marking as such
I happen to know that Indranil did not have a Debian 8 VM, so I don't think he accurately triggered the noise, though he did confirm that it still worked as expected. That is why it was still needs sign off. Like I said, this needs a Debian 8 (not Jessie release candidate) updated to test the second patch fully (because otherwise you won't likely see the messages as in comment #6. That's why I'm sticking it back to Needs Sign off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14487 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14487 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40784|0 |1 is obsolete| | --- Comment #12 from Nick Clemens <nick@quecheelibrary.org> --- Created attachment 41082 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41082&action=edit Bug 14487 - silence warns during checkin Test plan ========= 1/ check out an item and then check it back in. 1/ check the logs after the check-in to see the warns from returns.pl line 623 of : (a) Use of uninitialized value $holdingBranch (b) Use of uninitialized value $collectionBranch 2/ apply patch 3/ check out and check-in again. no warns are recorded this time. NOTE: Under Debian Jessie, there are other messages. Additionally, this only corrects the line 623 ones. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14487 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40788|0 |1 is obsolete| | --- Comment #13 from Nick Clemens <nick@quecheelibrary.org> --- Created attachment 41083 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41083&action=edit Bug 14487: Noise best detected under Debian 8 The first error is caused by the fact that $messages->{'IsPermanent'} is undefined. The second error is caused by querying the CGI parameter 'barcode' inside a function call. This is not required. There is a variable $barcode set with the parameter. Changed to use the variable. TEST PLAN ---------- 1) Test first patch. 2) Clear the log 3) Put in a barcode which is not checked out. 4) Check the log. -- should be two errors. One about a hash, the other will only be detectable under Debian 8. 5) Apply this second patch 6) Clear the log 7) Put in a barcode which is not checked out. 8) Check the log. -- should be empty. 9) run koha qa test tools Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com> Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14487 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14487 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41082|0 |1 is obsolete| | Attachment #41083|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 41173 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41173&action=edit [PASSED QA] Bug 14487 - silence warns during checkin Test plan ========= 1/ check out an item and then check it back in. 1/ check the logs after the check-in to see the warns from returns.pl line 623 of : (a) Use of uninitialized value $holdingBranch (b) Use of uninitialized value $collectionBranch 2/ apply patch 3/ check out and check-in again. no warns are recorded this time. NOTE: Under Debian Jessie, there are other messages. Additionally, this only corrects the line 623 ones. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14487 --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 41174 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41174&action=edit [PASSED QA] Bug 14487: Noise best detected under Debian 8 The first error is caused by the fact that $messages->{'IsPermanent'} is undefined. The second error is caused by querying the CGI parameter 'barcode' inside a function call. This is not required. There is a variable $barcode set with the parameter. Changed to use the variable. TEST PLAN ---------- 1) Test first patch. 2) Clear the log 3) Put in a barcode which is not checked out. 4) Check the log. -- should be two errors. One about a hash, the other will only be detectable under Debian 8. 5) Apply this second patch 6) Clear the log 7) Put in a barcode which is not checked out. 8) Check the log. -- should be empty. 9) run koha qa test tools Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com> Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14487 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #16 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Indranil and Mark! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14487 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #17 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.20.x will be in 3.20.3 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14487 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com --- Comment #18 from Liz Rea <wizzyrea@gmail.com> --- Pushed to 3.18.x, will be in 3.18.10. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14487 --- Comment #19 from Liz Rea <wizzyrea@gmail.com> --- Pushed to 3.18.x, will be in 3.18.10. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14487 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #20 from Mason James <mtj@kohaaloha.com> --- Pushed to 3.16.x, will be in 3.16.14 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org