[Bug 41807] New: Fix automatic tab selection on basket groups page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41807 Bug ID: 41807 Summary: Fix automatic tab selection on basket groups page Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: jonathan.druart@gmail.com, testopia@bugs.koha-community.org Depends on: 41563 There is some JS in basketgroups.tt which is intended to allow the script to pass a parameter for selecting the "Closed" tab on page reload but it has not been updated since the tabs WRAPPER work Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41563 [Bug 41563] Tidy kohaTable block - acqui -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41807 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41807 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 192900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192900&action=edit Bug 41807: Fix automatic tab selection on basket groups page This patch fixes the JS in the basket groups template which is intended to select the "Closed" tab when a "listclosed" parameter is passed. To test, apply the patch and go to Acquisitions. - Search for and view a vendor. - Click "Basket groups" in the sidebar. - Create a new basket group if necessary. - Click "Delete" to remove the basket group. - When the page reloads the "Closed" tab should be selected. - Create a new basket group if necessary and click "Close and export as PDF." When the page reloads the "Closed" tab should be selected. - Click "Reopen." The "Closed" tab should again be selected. The patch doesn't make any changes to existing behavior but I think we should re-evaluate whether the "Closed" tab is the right place to go after deleting or reopening a basket group. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41807 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Sponsorship status|--- |Sponsored Status|Needs Signoff |Signed Off Comma delimited| |Athens County Public list of Sponsors| |Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41807 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192900|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41807 --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 193161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193161&action=edit Bug 41807: Fix automatic tab selection on basket groups page This patch fixes the JS in the basket groups template which is intended to select the "Closed" tab when a "listclosed" parameter is passed. To test, apply the patch and go to Acquisitions. - Search for and view a vendor. - Click "Basket groups" in the sidebar. - Create a new basket group if necessary. - Click "Delete" to remove the basket group. - When the page reloads the "Closed" tab should be selected. - Create a new basket group if necessary and click "Close and export as PDF." When the page reloads the "Closed" tab should be selected. - Click "Reopen." The "Closed" tab should again be selected. The patch doesn't make any changes to existing behavior but I think we should re-evaluate whether the "Closed" tab is the right place to go after deleting or reopening a basket group. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41807 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Noting an existing "bug" when signing off: 1. Create two baskets groups. 2. Try the "Close and export as PDF" button for the LAST basket group in the list - note that nothing happens. 3. Try the "Close and export as PDF" button for the FIRST basket group in the list - it works as expected. 4. Try the "Close and export as PDF" button for the one basket group - it works as expected. Comment on what should happen: - Rather than change tabs to closed, I think it should remain on the tab you are on. - So if you are on the closed tab, and you perform an action, you should remain on that tab. - The same if you are on the open tab - you should remain on that tab. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41807 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41807 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193161|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41807 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 194396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194396&action=edit Bug 41807: Fix automatic tab selection on basket groups page This patch fixes the JS in the basket groups template which is intended to select the "Closed" tab when a "listclosed" parameter is passed. To test, apply the patch and go to Acquisitions. - Search for and view a vendor. - Click "Basket groups" in the sidebar. - Create a new basket group if necessary. - Click "Delete" to remove the basket group. - When the page reloads the "Closed" tab should be selected. - Create a new basket group if necessary and click "Close and export as PDF." When the page reloads the "Closed" tab should be selected. - Click "Reopen." The "Closed" tab should again be selected. The patch doesn't make any changes to existing behavior but I think we should re-evaluate whether the "Closed" tab is the right place to go after deleting or reopening a basket group. Sponsored-by: Athens County Public Libraries Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41807 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41807 --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41807 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41807 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch fixes a bug release notes| |which prevented the | |expected tab from being | |activated when the user | |takes certain actions like | |closing or deleting a | |basket group. Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41807 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.05.00 |26.05.00,25.11.04 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41807 --- Comment #6 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41807 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com Status|Pushed to stable |Needs documenting --- Comment #7 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Not backported to 25.05.x, as the patch does not apply cleanly and appears to depend on other changes that are not present on this branch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41807 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #8 from David Nind <david@davidnind.com> --- Bug fix, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41807 Bug 41807 depends on bug 41563, which changed state. Bug 41563 Summary: Tidy kohaTable block - acqui https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41563 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org