[Bug 26988] New: Don't load hold pickup locations unless dropdown is selected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988 Bug ID: 26988 Summary: Don't load hold pickup locations unless dropdown is selected Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Bug 26963 deals with improving the efficiency of the pickup_locations routine. Currently we are loading these dropdowns for every hold on a bib. It would save loading time to only load the dropdown if a library attempts to edit the pickup location -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 113395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113395&action=edit Bug 26988: Add API route to fetch hold pickup locations and use it in the holds table To test: 1 - Place a number of holds on a record 2 - Have different pickup locations for the holds 3 - Have some libraries that are not pickup locations 4 - Load the holds tab for the record and note libraries not pickup locations are not in dropdowns 5 - Apply patch and restart all things 6 - Reload the holds table 7 - Click on a dropdown, note the spinner, should load successfully 8 - Confirm the dropdown matches the options before the patch 9 - Confirm updating the hold location works -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com | |, | |jonathan.druart@bugs.koha-c | |ommunity.org, | |katrin.fischer@bsz-bw.de, | |wizzyrea@gmail.com Depends on| |26963 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26963 [Bug 26963] Koha::Template::Plugin::Branches::pickup_locations is very inefficient, causing timeouts on records with large numbers of holds/items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113395|0 |1 is obsolete| | --- Comment #2 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 113418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113418&action=edit Bug 26988: Add API route to fetch hold pickup locations and use it in the holds table To test: 1 - Place a number of holds on a record 2 - Have different pickup locations for the holds 3 - Have some libraries that are not pickup locations 4 - Load the holds tab for the record and note libraries not pickup locations are not in dropdowns 5 - Apply patch and restart all things 6 - Reload the holds table 7 - Click on a dropdown, note the spinner, should load successfully 8 - Confirm the dropdown matches the options before the patch 9 - Confirm updating the hold location works Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113418|0 |1 is obsolete| | --- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 113426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113426&action=edit Bug 26988: Add API route to fetch hold pickup locations and use it in the holds table To test: 1 - Place a number of holds on a record 2 - Have different pickup locations for the holds 3 - Have some libraries that are not pickup locations 4 - Load the holds tab for the record and note libraries not pickup locations are not in dropdowns 5 - Apply patch and restart all things 6 - Reload the holds table 7 - Click on a dropdown, note the spinner, should load successfully 8 - Confirm the dropdown matches the options before the patch 9 - Confirm updating the hold location works Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 113427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113427&action=edit Bug 26988: Make ->patron prefetchable Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 113428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113428&action=edit Bug 26988: (QA follow-up) Make the API return proper library objects Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|26963 | See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26963 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26963 [Bug 26963] Koha::Template::Plugin::Branches::pickup_locations is very inefficient, causing timeouts on records with large numbers of holds/items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://wiki.koha-community | |.org/wiki/Holds_pickup_loca | |tions_endpoint_RFC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113426|0 |1 is obsolete| | Attachment #113427|0 |1 is obsolete| | Attachment #113428|0 |1 is obsolete| | --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 113456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113456&action=edit Bug 26988: Add API route to fetch hold pickup locations and use it in the holds table To test: 1 - Place a number of holds on a record 2 - Have different pickup locations for the holds 3 - Have some libraries that are not pickup locations 4 - Load the holds tab for the record and note libraries not pickup locations are not in dropdowns 5 - Apply patch and restart all things 6 - Reload the holds table 7 - Click on a dropdown, note the spinner, should load successfully 8 - Confirm the dropdown matches the options before the patch 9 - Confirm updating the hold location works Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988 --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 113457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113457&action=edit Bug 26988: Make ->patron prefetchable Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988 --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 113458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113458&action=edit Bug 26988: (QA follow-up) Make the API return proper library objects Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988 --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 113459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113459&action=edit Bug 26988: (follow-up) Adjust code to use api field names -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988 --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 113460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113460&action=edit Bug 26988: (follow-up) Fix filter and encode api values and escape rendered values This patch makes the QA tools happy and follows correct procedures for passing data to and rendering data from the api -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This is working in Chrome but not on Firefox. We are trying to fix it! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988 --- Comment #12 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 113502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113502&action=edit Bug 26988: (follow-up) Change event to focus Click event on select element if Firefox does not work as expected, so this patch changes the event to focus for it to work seamlessly in both browsers. https://bugs.koha-community.org/show_bug.cgi?id=26899 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Don't load hold pickup |Defer loading the hold |locations unless dropdown |pickup locations until the |is selected |dropdown is selected QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113456|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113457|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113458|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113459|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113460|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113502|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988 --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 113533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113533&action=edit Bug 26988: Add API route to fetch hold pickup locations and use it in the holds table To test: 1 - Place a number of holds on a record 2 - Have different pickup locations for the holds 3 - Have some libraries that are not pickup locations 4 - Load the holds tab for the record and note libraries not pickup locations are not in dropdowns 5 - Apply patch and restart all things 6 - Reload the holds table 7 - Click on a dropdown, note the spinner, should load successfully 8 - Confirm the dropdown matches the options before the patch 9 - Confirm updating the hold location works Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988 --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 113534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113534&action=edit Bug 26988: Make ->patron prefetchable Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988 --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 113535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113535&action=edit Bug 26988: (QA follow-up) Make the API return proper library objects Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988 --- Comment #16 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 113536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113536&action=edit Bug 26988: (follow-up) Adjust code to use api field names Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988 --- Comment #17 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 113537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113537&action=edit Bug 26988: (follow-up) Fix filter and encode api values and escape rendered values This patch makes the QA tools happy and follows correct procedures for passing data to and rendering data from the api Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988 --- Comment #18 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 113538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113538&action=edit Bug 26988: (follow-up) Change event to focus Click event on select element if Firefox does not work as expected, so this patch changes the event to focus for it to work seamlessly in both browsers. https://bugs.koha-community.org/show_bug.cgi?id=26899 Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988 --- Comment #19 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 113590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113590&action=edit Bug 26988: No need to check if hold is linked to a patron Holds are deleted along with patrons. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26963 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26963 [Bug 26963] Improve Koha::Item::pickup_locations performance -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988 --- Comment #20 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 113601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113601&action=edit Bug 26988: Adjust for bug 26963 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988 --- Comment #21 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27016 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27016 [Bug 27016] Make the pickup locations dropdowns use Select2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27015 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27015 [Bug 27015] Add filtering options to the pickup_locations routes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988 --- Comment #22 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 113669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113669&action=edit Bug 26988: (QA follow-up) Unit tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #23 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Dear RM, we forgot the unit tests for the route. The latest patch adds them. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988 --- Comment #24 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Tomás Cohen Arazi from comment #22)
Created attachment 113669 [details] [review] Bug 26988: (QA follow-up) Unit tests
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Patch pushed to master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988 Bug 26988 depends on bug 26963, which changed state. Bug 26963 Summary: Improve Koha::Item::pickup_locations performance https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26963 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable --- Comment #25 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Backported to 20.05.x for 20.05.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00 |20.11.00, 20.05.07 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988 --- Comment #26 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Andrew Fuerste-Henry from comment #25)
Backported to 20.05.x for 20.05.07
There is a test failing on 20.05.x, Tomas can you have a look please? t/db_dependent/api/v1/holds.t .. 9/10 # Failed test 'exact match for JSON Pointer ""' # at t/db_dependent/api/v1/holds.t line 768. # Structures begin differing at: # $got = HASH(0x5630131b9158) # $expected = ARRAY(0x5630134b3bf8) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27177 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27177 [Bug 27177] t/db_dependent/api/v1/holds.t failing after bug 26988 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #27 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27863 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27863 [Bug 27863] Holds API route for pickup_libraries should return all branches if 'AllowHoldPolicyOverride' is enabled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988 --- Comment #28 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #26)
(In reply to Andrew Fuerste-Henry from comment #25)
Backported to 20.05.x for 20.05.07
There is a test failing on 20.05.x, Tomas can you have a look please?
t/db_dependent/api/v1/holds.t .. 9/10 # Failed test 'exact match for JSON Pointer ""' # at t/db_dependent/api/v1/holds.t line 768. # Structures begin differing at: # $got = HASH(0x5630131b9158) # $expected = ARRAY(0x5630134b3bf8)
Is this still the case, Andrew? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988 --- Comment #29 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- I am not getting that test failure on 20.05.x: root@kohadevbox:koha(rmain2005)$ prove t/db_dependent/api/v1/holds.t t/db_dependent/api/v1/holds.t .. ok All tests successful. Files=1, Tests=12, 11 wallclock secs ( 0.03 usr 0.01 sys + 7.19 cusr 1.00 csys = 8.23 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28842 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28842 [Bug 28842] Missing summary for /items/:item_id/pickup_locations -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|28842 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28842 [Bug 28842] Missing summary for /items/:item_id/pickup_locations -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org