[Bug 16245] New: Enhancements to RIS fails on change TY
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16245 Bug ID: 16245 Summary: Enhancements to RIS fails on change TY Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: gmcharlt@gmail.com Reporter: hagud@orex.es QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Good morning We have found one potential bug on this patch (https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357). The issue is that RisExportAdditionalFields doesn't recognize property the TY This patch is not recognizing propertly the type of the record, if leader position 6 is 'a' it publishs as book even the position 7 is b=article And it fails when try to modify it. We have tried to add TY: [942$c] to force the patch to replace the TY value, but it keeps the default Book value Koha 3.22.5 (debian jessy 8 with plack enabled) Test: Catalogue a record with LDR 6 and 7 'ab' --> this is an article check the record type is article in koha leader Download as RIS and check that type is book Modify syspref RisExportAdditionalFields TY: [337$a] (or whatever you wish) Download as RIS the ty is still book, it doesn't matter the value of 337$a or whatever -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16245 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16243 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16245 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |milton.lee@nzica.com --- Comment #1 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- *** Bug 7989 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16245 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Enhancements to RIS fails |RIS export file type |on change TY |incorrect Assignee|gmcharlt@gmail.com |hector.hecaxmmx@gmail.com CC| |hector.hecaxmmx@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16245 --- Comment #2 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 55896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55896&action=edit Bug 16245: RIS export file type incorrect When exporting lists to a RIS file, the TY field of the RIS file is always 'book' even if the item being exported is a journal or serial. Since unimarc and marc21 is coded in Koha, just a few references types are included. This needs a much better code. This bug changes only TY BOOK result. Other resources needs a case by case basis. To test -In advanced search limit by itemtype (books, music, continue resources, etc). -Search and save result in Cart -Export to RIS Format and notice about the new TY change with all materials -Test with http://www.myendnoteweb.com if you have account or create one. -Export record in bib record details page in OPAC and Intranet. -Confirm that works as expected. Sponsored-by: Universidad de El Salvador -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16245 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16245 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55896|0 |1 is obsolete| | --- Comment #3 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 55897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55897&action=edit Bug 16245: RIS export file type incorrect When exporting lists to a RIS file, the TY field of the RIS file is always 'book' even if the item being exported is a journal or serial. Since unimarc and marc21 is coded in Koha, just a few references types are included. This needs a much better code. This bug changes only TY BOOK result. Other resources needs a case by case basis. To test -In advanced search limit by itemtype (books, music, continue resources, etc). -Search and save result in Cart -Export to RIS Format and notice about the new TY change with all materials -Test with http://www.myendnoteweb.com if you have account or create one. -Export record in bib record details page in OPAC and Intranet. -Confirm that works as expected. Sponsored-by: Universidad de El Salvador -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16245 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16245 --- Comment #4 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Doing a little search for some other reference types, I could obtain this table: FOR MARC 21 Book BOOK Leader/06 a Leader/07 m Serial SER Leader/06 a Leader/07 s Full Journal JFULL Leader/06 a Leader/07 s 008/21 p Newspapers NEWS Leader/06 a Leader/07 s 008/21 n Book chapter CHAP Leader/06 a Leader/07 a 773$7/02 a 773$7/03 m Journal article JOUR Leader/06 a Leader/07 a 773$7/02 a 773$7/03 s ************************* Catalog CTLG Could be serial or simple monograph Book Leader/06 a Leader/07 m 008/24-27 c Serial Leader/06 a Leader/07 s 008/24 c ************************ Conference Paper CPAPER Serial, book Book Leader/06 a Leader/07 m 008/29 1 Serial Leader/06 a Leader/07 s 008/29 1 ************************* Patent PAT Book Leader/06 a Leader/07 m 008/24-27 j Serial Leader/06 a Leader/07 s 008/24 j ************************* Thesis THES Book Leader/06 a Leader/07 m 008/24-27 m Serial Leader/06 a Leader/07 s 008/24 m ************************* Case CASE Book Leader/06 a Leader/07 m 008/24-27 vw Serial Leader/06 a Leader/07 s 008/24 vw ************************* Statute STAT Book Leader/06 a Leader/07 m 008/24-27 lz Serial Leader/06 a Leader/07 s 008/24 lz ************************* Encyclopedia ENCYC Book Leader/06 a Leader/07 m 008/24-27 e Serial Leader/06 a Leader/07 s 008/24 e ************************* Dictionaries DICT Book Leader/06 a Leader/07 m 008/24-27 d Serial Leader/06 a Leader/07 s 008/24 d Unpublished Work and Manuscript, the same in MARC21 MANSCPT, UNPD Leader/06 t Leader/07 m ######################## FOR UNIMARC Book BOOK Leader/06 a Leader/07 m Serial SER Leader/06 a Leader/07 s Full Journal JFULL Leader/06 a Leader/07 s 100$a/0 a Newspapers NEWS Leader/06 a Leader/07 s 100$a/0 c Book chapter CHAP Leader/06 a Leader/07 a 463 Journal article JOUR Leader/06 a Leader/07 a 461 Dictionaries, Encyclopedias, case, statutes, etc. For book and serials 105$a/4-7 110$a/3 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16245 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55897|0 |1 is obsolete| | --- Comment #5 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 55941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55941&action=edit Bug 16245: RIS export file type incorrect When exporting lists to a RIS file, the TY field of the RIS file is always 'book' even if the item being exported is a journal or serial. Since unimarc and marc21 is coded in Koha, just a few references types are included. This needs a much better code. This bug changes only TY BOOK result. Other resources needs a case by case basis. To test: -In advanced search limit by itemtype (books, music, continue resources, etc). -Search and save result in Cart -Export to RIS Format and notice about the new TY change with all materials -Export record in bib record details page in OPAC and Intranet. -Confirm that works as expected. -Bonus test: -Try to import the RIS file in http://www.myendnoteweb.com if you have account or create one. NOTE: According with previous comment, some values has changed. Sponsored-by: Universidad de El Salvador -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16245 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16245 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55941|0 |1 is obsolete| | --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 56043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56043&action=edit Bug 16245: RIS export file type incorrect When exporting lists to a RIS file, the TY field of the RIS file is always 'book' even if the item being exported is a journal or serial. Since unimarc and marc21 is coded in Koha, just a few references types are included. This needs a much better code. This bug changes only TY BOOK result. Other resources needs a case by case basis. To test: -In advanced search limit by itemtype (books, music, continue resources, etc). -Search and save result in Cart -Export to RIS Format and notice about the new TY change with all materials -Export record in bib record details page in OPAC and Intranet. -Confirm that works as expected. -Bonus test: -Try to import the RIS file in http://www.myendnoteweb.com if you have account or create one. NOTE: According with previous comment, some values has changed. Sponsored-by: Universidad de El Salvador Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16245 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- What is 'MANSCPT'? Are the changes related to MANSCPT expected? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16245 --- Comment #8 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- (In reply to Jonathan Druart from comment #7)
What is 'MANSCPT'?
Hi Jonathan MANSCPT is "manuscript" according with official documentation <http://referencemanager.com/sites/rm/files/m/direct_export_ris.pdf> This exist in UNIMARC and MARC21. This was coded as BOOK/GEN and is a wrong reference type. For example in UNIMARC you can find in Record label in position 6 (type of record) the value (b = language materials, manuscript) you can see more about it at <http://archive.ifla.org/VI/3/p1996-1/uni.htm> MARC21 in Leader position 06 (type of record) is coded "t - Manuscript language material" and textually cite "Examples include marked or corrected galley and page proofs, manuscript books, legal papers, and unpublished theses and dissertations. " <http://www.loc.gov/marc/bibliographic/bdleader.html> If librarian coded in MARC21 Leader/06 "t" or UNIMARC 000/6 "b" he or she is coding a manuscript and unplublished book rather than a published book.
Are the changes related to MANSCPT expected? Not was the expected but I think this is wrong coded as BOOK in UNIMARC and GEN in MARC21. So if we started comparing at this point this is wrong anyway.
The expected was as Hugo pointed out in Description
Catalogue a record with LDR 6 and 7 'ab' --> this is an article check the record type is article in koha leader
But for this we need to see more subfields than leader 06 and leader 07. See "In Analytics" at <https://www.oclc.org/bibformats/en/specialcataloging.html#CHDBIIAF> MARC21 Journal article JOUR Leader/06 a Leader/07 a not b see examples at <https://www.oclc.org/bibformats/en/fixedfield/blvl.html> 773$7/02 a 773$7/03 s UNIMARC Journal article JOUR Leader/06 a Leader/07 a 461 But this needs more work, and if we include journal article we can include more reference types as annotated in comment 4 and I think (IMHO) this could be treat it in another bug. Regards -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16245 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56043|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 56476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56476&action=edit Bug 16245: RIS export file type incorrect When exporting lists to a RIS file, the TY field of the RIS file is always 'book' even if the item being exported is a journal or serial. Since unimarc and marc21 is coded in Koha, just a few references types are included. This needs a much better code. This bug changes only TY BOOK result. Other resources needs a case by case basis. To test: -In advanced search limit by itemtype (books, music, continue resources, etc). -Search and save result in Cart -Export to RIS Format and notice about the new TY change with all materials -Export record in bib record details page in OPAC and Intranet. -Confirm that works as expected. -Bonus test: -Try to import the RIS file in http://www.myendnoteweb.com if you have account or create one. NOTE: According with previous comment, some values has changed. Sponsored-by: Universidad de El Salvador Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16245 --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 56477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56477&action=edit Bug 16245: [QA Follow-up] Replace typeofrecord2 by biblevel Position 7 of the leader is better referred to as biblevel. (Pos 6 is record type.) At the same time replacing some regex's by simple eq's. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> It seems that bib level in the UNIMARC leader only allows a subset of the possible combinations for MARC21. This does not have bad side-effects however in the new code that tests bib level to determine the type tag. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16245 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Unfortunately, we do not have any unit tests for Ris.pm. This patch set could have introduced one? But I am not blocking this for that reason now. Looking thru Ris.pm, I would love to see the STDOUT manipulation removed. Instead of failing it for the typeofrecord2 variable, added a follow-up. Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16245 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Hector, Marcel! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16245 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr Status|Pushed to Master |Pushed to Stable --- Comment #13 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.05. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16245 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #14 from Julian Maurice <julian.maurice@biblibre.com> --- Pushed in 3.22.x, will be in 3.22.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16245 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org