[Bug 9966] New: Hiden Items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9966 Bug ID: 9966 Summary: Hiden Items Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: ed.veal@bywatersolutions.com If you set up the OpacHiddenItems syspref to hide based on homebranch and then do a "Title Phrase" search for a title that on the hidden branch owns you get a 404 error rather than the "No Item found" message. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9966 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|OPAC |Searching Version|3.10 |master Assignee|oleonard@myacpl.org |gmcharlt@gmail.com Summary|Hiden Items |Incorrect 404 when a search | |returns one result hidden | |by OpacHiddenItems --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- I don't think this is related to the type of search, I think it has to do with the fact that the search is returning only one record. Normally a search with one result redirects to the detail page for that result. It sounds like the fact that the result is hidden by OpacHiddenItems makes it behave as if the record doesn't exist. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9966 --- Comment #2 from Ed Veal <ed.veal@bywatersolutions.com> --- Owen, I agree but that was the best example I could use to get the error to show. You are correct it is not the search that is at issue it is the fact that it is trying to display something that is hidden. Ed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9966 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9966 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby@univ-rennes2.f | |r -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9966 Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9966 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9966 james.elian@britishschool.ro changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |james.elian@britishschool.r | |o --- Comment #3 from james.elian@britishschool.ro --- I resolved a similar situation by re-indexing (koha-rebuild-zebra on my Ubuntu system). Before, the hidden item type was still appearing on search results, and clicking the link to the item would result in a 404 error. After, the item type was correctly hidden from all search results. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9966 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think 2 different problems here: - when there is only one result of the search, that is hidden due to opachiddenitems, then the 404 displays. Maybe we should implement something like OpacSuppressionRedirect and OpacSuppressionMessage for opachiddenitems? - The item information in the result list is coming from the Zebra index, so this might be the reason a reindex was necessary to make it work - maybe the item was not indexed yet before? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9966 --- Comment #5 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Created attachment 41194 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41194&action=edit Bug 9966 - Incorrect 404 when a search returns one result hidden by OpacHiddenItems This patch disables throwing the 404-error. We should be able to show the opac-detail.pl regardless of hidden items or not. This doesn't fix the availability on opac-search.pl, but gets us out of a very awkward predicatement. TEST PLAN: 1. You can now access opac-detail.pl for Biblios whose ALL Items are hidden by the 'OpacHiddenItems'-syspref. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9966 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |olli-antti.kivilahti@jns.fi --- Comment #6 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- s'il vous plaît. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9966 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- If I understand you correctly this will make the record visible, even if all items are hidden. I think this breaks a feature/user expectation. A lot of libraries use the fact the record is hidden with the last item to their advantage and the feature has been explicitly build to function this way from the beginning. This fix is too simple - it needs to be optional. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9966 --- Comment #8 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- (In reply to Katrin Fischer from comment #7)
If I understand you correctly this will make the record visible, even if all items are hidden. I think this breaks a feature/user expectation. A lot of libraries use the fact the record is hidden with the last item to their advantage and the feature has been explicitly build to function this way from the beginning.
This fix is too simple - it needs to be optional.
The hidden items should not be displayed in OPAC regardless of this fix. The way I tested we get the opac-detail.pl with no Items to display because they were all correctly hidden by the "OpacHiddenItems"-syspref. If this fix is too simple, you can freely wait for a more complete solution. For the time being we are affected by this bug and it causes bad experiences for OPAC users. This patch fixes the biggest issue with the lowest effort. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9966 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #9 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Put status back to "Needs Signoff", because QA misunderstood the patch effects and no test results were available to discredit the intended behaviour. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9966 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #10 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Failed QA because of missing tests ;) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9966 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The point is you are deleting code that is there on purpose - the bibliographic details/record shouldn't show when all items are hidden. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9966 --- Comment #12 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- (In reply to Katrin Fischer from comment #11)
The point is you are deleting code that is there on purpose - the bibliographic details/record shouldn't show when all items are hidden.
Sorry, I read Item when you wrote Record. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org