http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11719 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 25178 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25178&action=edit Bug 11719 - Use new DataTables include in serials templates Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to all serials-related pages which use DataTables. Apply the patch and test the following pages to confirm that table sorting works correctly: - Serials search results (serials/serials-search.pl): Perform a search which will return more than one subscription. The expiration date column is now sorted using the "title-string" filter for sorting based on the unformatted date. The "anti-the" filter has been added to the title column to exclude articles when sorting. - Serials collection (serials/serials-collection.pl): View the serial colection page for an existing subscription. The table of issues should be sorted correctly. - Serial claims (serials/claims.pl): The "since" and "claim date" columns have been modified to use the title-string filter for sorting based on the unformatted date. C4::Serials.pm::GetLateOrMissingIssues has been modified to pass an unformatted date along with the formatted date. The "anti-the" filter has been added to the title column to exclude articles when sorting. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11719 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25178|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11719 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sorting on Call number gives me a Javascript error and the 'little arrow' icons don't change when clicking on them: return a.match(/title="(.*?)"/)[1].toLowerCase(); -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11719 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 25619 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25619&action=edit Bug 11719 [Follow-up] Use new DataTables include in serials templates This patch corrects column sorting configuration to avoid an error when sorting on the call number column. Also changed: removed obsolete UK sort mention. To test, search for serial subscriptions. Test sorting on all columns in the results table with and without the RoutingSerials preference enabled. Sorting should work correctly without error. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11719 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25600|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11719 --- Comment #7 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 26042 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26042&action=edit Bug 11719 - Use new DataTables include in serials templates Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to all serials-related pages which use DataTables. Apply the patch and test the following pages to confirm that table sorting works correctly: - Serials search results (serials/serials-search.pl): Perform a search which will return more than one subscription. The expiration date column is now sorted using the "title-string" filter for sorting based on the unformatted date. The "anti-the" filter has been added to the title column to exclude articles when sorting. - Serials collection (serials/serials-collection.pl): View the serial colection page for an existing subscription. The table of issues should be sorted correctly. - Serial claims (serials/claims.pl): The "since" and "claim date" columns have been modified to use the title-string filter for sorting based on the unformatted date. C4::Serials.pm::GetLateOrMissingIssues has been modified to pass an unformatted date along with the formatted date. The "anti-the" filter has been added to the title column to exclude articles when sorting. Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Signed-off-by: Aleisha <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11719 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Owen, I tested and found 2 small things: - On the serials collection page the sort on the Routing column could be removed, this is no reason for a fail, as it's there pre-patch. So just noting :) - On the claims page the sorting is totally broken for me - maybe a side effect of another patch pushed since? Javascript error shown is: TypeError: a.aoColumns[c] is undefined ...null};if("function"===typeof a)return function(b,d,i){return a(b,d,i)};if("strin... jquery....min.js (Zeile 29) Since and Claim date don't show the little arrow for sorting. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11719 --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 27145 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27145&action=edit Bug 11719 [Follow-up 2] Use new DataTables include in serials templates This second follow-up addresses QA issues: - Corrected sorting on claims page while converting sorting configuration to up-to-date method. - Removed sorting from routing list column on serial collection page. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11719 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12089 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11719 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11719 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am having problems resolving the conflict here correctly - sorry. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11719 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26042|0 |1 is obsolete| | Attachment #26043|0 |1 is obsolete| | Attachment #27535|0 |1 is obsolete| | --- Comment #15 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 27733 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27733&action=edit Bug 11719 - Use new DataTables include in serials templates Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to all serials-related pages which use DataTables. Apply the patch and test the following pages to confirm that table sorting works correctly: - Serials search results (serials/serials-search.pl): Perform a search which will return more than one subscription. The expiration date column is now sorted using the "title-string" filter for sorting based on the unformatted date. The "anti-the" filter has been added to the title column to exclude articles when sorting. - Serials collection (serials/serials-collection.pl): View the serial colection page for an existing subscription. The table of issues should be sorted correctly. - Serial claims (serials/claims.pl): The "since" and "claim date" columns have been modified to use the title-string filter for sorting based on the unformatted date. C4::Serials.pm::GetLateOrMissingIssues has been modified to pass an unformatted date along with the formatted date. The "anti-the" filter has been added to the title column to exclude articles when sorting. Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Signed-off-by: Aleisha <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11719 --- Comment #17 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 27735 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27735&action=edit Bug 11719 [Follow-up 2] Use new DataTables include in serials templates This second follow-up addresses QA issues: - Corrected sorting on claims page while converting sorting configuration to up-to-date method. - Removed sorting from routing list column on serial collection page. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11719 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27733|0 |1 is obsolete| | Attachment #27734|0 |1 is obsolete| | Attachment #27735|0 |1 is obsolete| | --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 27737 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27737&action=edit [PASSED QA] Bug 11719 - Use new DataTables include in serials templates Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to all serials-related pages which use DataTables. Apply the patch and test the following pages to confirm that table sorting works correctly: - Serials search results (serials/serials-search.pl): Perform a search which will return more than one subscription. The expiration date column is now sorted using the "title-string" filter for sorting based on the unformatted date. The "anti-the" filter has been added to the title column to exclude articles when sorting. - Serials collection (serials/serials-collection.pl): View the serial colection page for an existing subscription. The table of issues should be sorted correctly. - Serial claims (serials/claims.pl): The "since" and "claim date" columns have been modified to use the title-string filter for sorting based on the unformatted date. C4::Serials.pm::GetLateOrMissingIssues has been modified to pass an unformatted date along with the formatted date. The "anti-the" filter has been added to the title column to exclude articles when sorting. Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tested all 3 tables, no regressions found. Passes QA script and tests. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11719 --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 27739 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27739&action=edit [PASSED QA] Bug 11719 [Follow-up 2] Use new DataTables include in serials templates This second follow-up addresses QA issues: - Corrected sorting on claims page while converting sorting configuration to up-to-date method. - Removed sorting from routing list column on serial collection page. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.