[Bug 17940] New: Holds not going to waiting state after having been transferred
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17940 Bug ID: 17940 Summary: Holds not going to waiting state after having been transferred Change sponsored?: --- Product: Koha Version: 16.11 Hardware: PC OS: Linux Status: NEW Severity: major Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: stefan.berndtsson@ub.gu.se QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com We seem to have found an issue with holds after transfers. Steps to reproduce (everything done by staff): Allow for On shelf holds. Have library branch A and B. Have one biblio with one item located at library A. Have one patron able to have holds placed on them. 1. Place a hold on biblio for patron, select pickup at library B. 2. Check in item on library A (get a transfer notice). 3. Check in item on library B (another transfer notice). 4. Item is not waiting properly on pickup location. If pickup was set to library A (same as item), it would be properly set to waiting. Expected outcome would be that the item is set to waiting at library B. After step 1, the reserves table contains "NULL" in "found" column. After step 2, "found" contains "T" After step 3, "found" still contains "T", where it should really contain "W". This has been tested with both 16.11.00 and 16.11.01. Thank you. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17940 --- Comment #1 from Stefan Berndtsson <stefan.berndtsson@ub.gu.se> --- Some additional information. When in the unexpected state after having checked in on library B (step 3), the information notice presented includes: "Hold found (item is already waiting):" This state seems to only look at itemnumber and priority == 0. When step 2 executes, the reserve is set to 'T', the priority to 0 and the itemnumber is added to the reserve entry. As far as I understand things, this is normal (priority is 0 when the item is assigned to a person, even if there is a transfer needed). When the item is checked in at the pickup (Step 3 again) the item is returned as "Waiting" (from CheckReserves) due to the itemnumber and priority == 0, and since it does not need a transfer from Library B, and is already considered to be waiting, it does not seem to update the 'W' flag. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17940 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17940 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- *** Bug 18075 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17940 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14695 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 [Bug 14695] Add ability to place multiple item holds on a given record per patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17940 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Hardware|PC |All Status|NEW |ASSIGNED Version|16.11 |master OS|Linux |All -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17940 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17940 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 60024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60024&action=edit Bug 17940: (follow-up 14695) Fix - Mark holds as waiting when transfer is done When an item from Library A is reserved and set to be picked up at Library B, the hold buttons fail to confirm or cancel during check in at Library B when the item is transferred from Library A. Test plan: * Create a hold for item at Library A to be picked up at Library B. * Check in item at Library A to trigger the transfer. => item shows in transit * Switch to Library B and check in item. * Confirm the hold. => item shows waiting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17940 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Marked as critical since it impacts last stable release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17940 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17940 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60024|0 |1 is obsolete| | --- Comment #5 from Christopher Brannon <cbrannon@cdalibrary.org> --- Created attachment 60035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60035&action=edit [SIGNED OFF] Bug 17940: (follow-up 14695) Fix - Mark holds as waiting when transfer is done When an item from Library A is reserved and set to be picked up at Library B, the hold buttons fail to confirm or cancel during check in at Library B when the item is transferred from Library A. Test plan: * Create a hold for item at Library A to be picked up at Library B. * Check in item at Library A to trigger the transfer. => item shows in transit * Switch to Library B and check in item. * Confirm the hold. => item shows waiting Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17940 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17940 --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 60037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60037&action=edit Bug 17940: (follow-up 14695) Fix - Mark holds as waiting when transfer is done When an item from Library A is reserved and set to be picked up at Library B, the hold buttons fail to confirm or cancel during check in at Library B when the item is transferred from Library A. Test plan: * Create a hold for item at Library A to be picked up at Library B. * Check in item at Library A to trigger the transfer. => item shows in transit * Switch to Library B and check in item. * Confirm the hold. => item shows waiting Signed-off-by: Crhistopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17940 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Attachment #60035|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17940 --- Comment #7 from Christopher Brannon <cbrannon@cdalibrary.org> --- Dude, what did you do to my name in the sign off??? Now I will never get credit for my work! :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17940 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60037|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 60045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60045&action=edit Bug 17940: (follow-up 14695) Fix - Mark holds as waiting when transfer is done When an item from Library A is reserved and set to be picked up at Library B, the hold buttons fail to confirm or cancel during check in at Library B when the item is transferred from Library A. Test plan: * Create a hold for item at Library A to be picked up at Library B. * Check in item at Library A to trigger the transfer. => item shows in transit * Switch to Library B and check in item. * Confirm the hold. => item shows waiting Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17940 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david.roberts@ptfs-europe.c | |om --- Comment #9 from David Roberts <david.roberts@ptfs-europe.com> --- I know this has been signed off and passed QA, but in the patch attachment, shouldn't: reserve_id => $reserve->{reserve_id}, actually be: reserve_id => $reserve->{'reserve_id'}, ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17940 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to David Roberts from comment #9)
I know this has been signed off and passed QA, but in the patch attachment, shouldn't:
reserve_id => $reserve->{reserve_id},
actually be:
reserve_id => $reserve->{'reserve_id'},
?
Just the same. No problem. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17940 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17940 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Good to see this fixed! This patch has been pushed to 16.11.x and will be in 16.11.04. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17940 Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17940 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19116 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17940 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #13 from Mason James <mtj@kohaaloha.com> --- Blocked by new feature, skipping for 16.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org