[Bug 9412] New: add optional_params to C4::Service
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9412 Bug ID: 9412 Summary: add optional_params to C4::Service Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: hugh@davenport.net.nz Adds a sub to allow getting parameters that aren't required, but may be sent -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9412 Hugh Davenport <hugh@davenport.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt@gmail.com |hugh@davenport.net.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9412 Hugh Davenport <hugh@davenport.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9412 Hugh Davenport <hugh@davenport.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9412 --- Comment #1 from Hugh Davenport <hugh@davenport.net.nz> --- Created attachment 14651 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14651&action=edit bug 9412 Add optional_params sub to C4::Service Similar to require_params, but just returns undef for any param that wasn't sent by request Signed-off-by: Hugh Davenport <hugh@davenport.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9412 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9412 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff CC| |bgkriegel@gmail.com --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Self-signed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9412 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.m.hall@gmail.com --- Comment #3 from Kyle M Hall <kyle.m.hall@gmail.com> --- I think this needs a test plan. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9412 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Failed QA for the following reasons: 1) No test plan 2) Adds a subroutine that is not used Can you please justify the addition of this new subroutine when it isn't used by any new code? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9412 Hugh Davenport <hugh@davenport.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |4439 Depends on| |4437 --- Comment #5 from Hugh Davenport <hugh@davenport.net.nz> --- Hi Kyle, Sorry, when I git bz'd the patch up here, it didn't take into account dependencies which I guess I kinda assumed it would. This bug is actually building blocks for bug 4439 which then use this method. I've updated this bug to show this dependency. Cheers, Hugh -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org