[Bug 35029] New: Doubled up entries in notices and slips after update
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35029 Bug ID: 35029 Summary: Doubled up entries in notices and slips after update Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org Depends on: 30555 This was caused by bug 30555: When we insert new entries into the letters table for existing notices (new transport types), we need to make sure that letter.name of the old and new notice entries match. Otherwise we'll see 2 entries in the editor with no way to fix it from the GUI. Both lead to the same notice entry page. name gets translated, so we need to query the existing one with the code of the letter and use it for the new entries. To test: * You will need a non-English installation, with translated installer. de-DE would work. And where the database from bug 30555 has run. * Alternatively you can try and update the name field for one of the entries in letter manually to see the same effect. * Go to tools > notices and slips * Verify there are 2 entries for the DUEDGST and other notices with different description. * When editing, you should see the same text/entries for each. It's also the same URL. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30555 [Bug 30555] Add more sample notice for SMS messages -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35029 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I think the grouping should probably be on something else than the name (the letter code??). In my SQL files for translating db updates, I added a line to update the letter name in the english letter to the french name to counter this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35029 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think it's because it displays the title in the table, so when we group on the other criteria you get them as separate entries. It's easy to fix if you have db access, much harder for everyone else. Might still be good to do some clean-up. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35029 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Doubled up entries in |Doubled up entries in |notices and slips after |notices and slips after |update |update of notice name Severity|minor |normal --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Now this also happens when the name of a notice is updated in the GUI, which makes this a much less avoidable issue :( -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35029 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@ptfs-europe.co | |m Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #4 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- *** This bug has been marked as a duplicate of bug 37891 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35029 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|DUPLICATE |--- -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35029 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEW --- Comment #5 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Putting this back to 'NEW' as discussion here appears to go more in-depth than what's being fixed in bug 37891. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35029 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=37891 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35029 --- Comment #6 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Caroline Cyr La Rose from comment #1)
I think the grouping should probably be on something else than the name (the letter code??).
In my SQL files for translating db updates, I added a line to update the letter name in the english letter to the french name to counter this.
The grouping is using name due to ONLY_FULL_GROUP_BY. Mattermost discussion: https://chat.koha-community.org/koha-community/pl/5xmw3emh9bduxbm51fkcg34k9y -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35029 --- Comment #7 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #3)
Now this also happens when the name of a notice is updated in the GUI, which makes this a much less avoidable issue :(
Bug 37891 should fix that. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35029 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Doubled up entries in |Notices table shows |notices and slips after |duplicate notice entries if |update of notice name |database rows mismatch on | |certain fields. --- Comment #8 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- I've updated the bug title, but I'm open to better suggestions. I believe the table will show duplicate entries of notices if any of the following fields mismatch across the different instances of message_transport_type for each code (letter.pl): GROUP BY branchcode,module,code,name,branchname This should ideally no longer be reproduceable through the UI after bug 37891, but it is still possible by updating the database manually to meet these conditions, and there are possibly active Koha instances with this problem currently. Mattermost initial discussion (for bug 37891) but it applies here also: https://chat.koha-community.org/koha-community/pl/dqheyewpd7nqfjwom8f8khom7w -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35029 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Notices table shows |Notices table shows |duplicate notice entries if |duplicate notice entries if |database rows mismatch on |database rows mismatch on |certain fields. |certain fields -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35029 Bug 35029 depends on bug 30555, which changed state. Bug 30555 Summary: Add more sample notice for SMS messages https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30555 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org