[Bug 8415] New: Link Serial with Acquisition
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8415 Priority: P5 - low Change sponsored?: --- Bug ID: 8415 CC: colin.campbell@ptfs-europe.com Assignee: koha-bugs@lists.koha-community.org Summary: Link Serial with Acquisition Severity: enhancement Classification: Unclassified OS: All Reporter: amit.gupta@osslabs.biz Hardware: All Status: NEW Version: unspecified Component: Serials Product: Koha -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8415 Amit Gupta <amit.gupta@osslabs.biz> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8415 Amit Gupta <amit.gupta@osslabs.biz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |amit.gupta@osslabs.biz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8415 Amit Gupta <amit.gupta@osslabs.biz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |savitra.sirohi@osslabs.biz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8415 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Amit, I know Biblibre has done work in this area - maybe you want to check with them. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8415 --- Comment #2 from Amit Gupta <amit.gupta@osslabs.biz> --- Created attachment 10780 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10780&action=edit Link Serial with Acquisition Rebase biblibre patch on master To Test: 1) Create a basket. 2) Click on From a Subscription link under Add order to basket section. 3) A filter box appear on the left hand side (Search by ISSN, Title, Publisher, Supplier) 4) Search a subscription and click on order to add the order on the basket. 5) If already subscription add to the basket it shows "only one order per subscription is allowed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8415 Amit Gupta <amit.gupta@osslabs.biz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8415 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |chris@bigballofwax.co.nz --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Amit, Is this a patch you wrote, or is a biblibre patch? You have the changed the author of it to you if so. If it was a patch from someone else (biblibre) which bug was it on, and you should leave the author as them. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8415 Amit Gupta <amit.gupta@osslabs.biz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10780|0 |1 is obsolete| | --- Comment #4 from Amit Gupta <amit.gupta@osslabs.biz> --- Created attachment 10782 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10782&action=edit Link Serial with Acquisition -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8415 Amit Gupta <amit.gupta@osslabs.biz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8415 Amit Gupta <amit.gupta@osslabs.biz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8456 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8415 claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez@biblibre.c | |om -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8415 Amit Gupta <amit.gupta@osslabs.biz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10782|0 |1 is obsolete| | --- Comment #5 from Amit Gupta <amit.gupta@osslabs.biz> --- Created attachment 10927 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10927&action=edit Link Serial with Acquisition -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8415 --- Comment #6 from claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> --- Hello Amit, Help is welcomed, thanks. I think we should have a look closer because you seem to add the same (but not the same) sub as another bz from us: Bug 5357 and there is maybe others overlaps with our work. More information soon... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8415 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |5357 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8415 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Amit and Claire, I would really like to see this functionality in Koha soon - is there a chance we can get a patch that works on top of bug 5357? Or how do you think is the best way to make progress here? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8415 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I have started testing this patch on top of bug 5357 and have a few questions: 1) When I search for a subscription, there is a checkbox "show only renewed". I have one subscription that is not yet expired and no expired subscriptions. When I check the checkbox, my working subscription is gone. What is a "renewed" subscription? How are those selected from the subscriptions? 2) AcqCreateItem is set to "on order". When creating an order for a subscription, the form forces me to add an item - I am confused by that. I thought that part of the functionality of ordering from subscriptions would include that no items have to be created, because subscriptions can work without items or items should only be created when issues are received. 3) We currently have a functionality to create suggestions when a serial is renewed. will this functionality be integrated with the new ordering process? What is the intended workflow here? I have worked on some smaller issues I found while testing - attaching rebased patch and follow up. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8415 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10927|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 11833 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11833&action=edit Bug 8415 - Link Serial with Acquisition To Test: 1) Create a basket. 2) Click on From a Subscription link under Add order to basket section. 3) A filter box appear on the left hand side (Search by ISSN, Title, Publisher, Supplier) 4) Search a subscription and click on order to add the order on the basket. 5) If already subscription add to the basket it shows "only one order per subscription is allowed". Signed-off-by: Amit Gupta <amit.gupta@osslabs.biz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8415 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 11834 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11834&action=edit Bug 8415: Follow up - Fixing some smaller issues 1) Changes the updatedatabase to be a bit more precise and always add the new field after claimed_date, like it is in kohastructure.sql. 2) Fixes capitalization rules for the new link to create a serial order. 3) Hides EAN search field when marcflavour is not UNIMARC. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8415 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Update: bug 5357 has been pushed now - retesting this. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8415 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11833|0 |1 is obsolete| | Attachment #11834|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 12326 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12326&action=edit [SIGNED-OFF] Bug 8415 - Link Serial with Acquisition To Test: 1) Create a basket. 2) Click on From a Subscription link under Add order to basket section. 3) A filter box appear on the left hand side (Search by ISSN, Title, Publisher, Supplier) 4) Search a subscription and click on order to add the order on the basket. 5) If already subscription add to the basket it shows "only one order per subscription is allowed". Signed-off-by: Amit Gupta <amit.gupta@osslabs.biz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8415 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 12327 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12327&action=edit Bug 8415: Follow up - Fixing some smaller issues 1) Changes the updatedatabase to be a bit more precise and always add the new field after claimed_date, like it is in kohastructure.sql. 2) Fixes capitalization rules for the new link to create a serial order. 3) Hides EAN search field when marcflavour is not UNIMARC. 4) Adds documentation for the new column in kohastructure.sql 5) Fixes some terms * Branch to Library * Search for Serial Routing Lists to Search for serial subscriptions 6) Deletes doubled up SearchSubscriptions from Search.pm -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8415 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- These 2 patches can not stand alone - the functionality on neworderempty is missing to make it possible to create an order without being forced to create items. Looking into this now. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8415 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12327|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 12366 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12366&action=edit Bug 8415: Follow up - Fixing some smaller issues 1) Changes the updatedatabase to be a bit more precise and always add the new field after claimed_date, like it is in kohastructure.sql. 2) Fixes capitalization rules for the new link to create a serial order. 3) Hides EAN search field when marcflavour is not UNIMARC. 4) Adds documentation for the new column in kohastructure.sql 5) Fixes some terms * Branch to Library * Search for Serial Routing Lists to Search for serial subscriptions 6) Deletes doubled up SearchSubscriptions from Search.pm * Change call to sub to use new signature -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8415 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12366|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 12368 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12368&action=edit Bug 8415: Follow up - Fixing some smaller issues 1) Changes the updatedatabase to be a bit more precise and always add the new field after claimed_date, like it is in kohastructure.sql. 2) Fixes capitalization rules for the new link to create a serial order. 3) Hides EAN search field when marcflavour is not UNIMARC. 4) Adds documentation for the new column in kohastructure.sql 5) Fixes some terms * Branch to Library * Search for Serial Routing Lists to Search for serial subscriptions * Supplier to Vendor 6) Deletes doubled up SearchSubscriptions from Search.pm * Change call to sub to use new signature 7) Deletes "Show only renewed" checkbox and related code. This feature requires a database field reneweddate in subscription that is not available in master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8415 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- There are 2 known problems with those patches: 1) The functionality is incomplete as the part for the new order and item receive forms is still missing. I tried rebasing the patches from Biblibre, but the item management has changed so much I had problems to get it working. The approach on bug 8456 to solve this is a bit different, I noted my concerns on this bug and also linked to the commit I tried to rebase. 2) While testing I noted a few things with these patches: a) blocker: If you cancel a subscription order, you can't reorder it. The warning that is supposed to block double orders in a year will remain, there is no order link on the subscription search result list but only the warning. b) minor: the branch code in the result list should be the branch name, as it is in the filters on the left side. c) normal: the code should be using the date plugin. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8415 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED CC| |jonathan.druart@biblibre.co | |m Resolution|--- |DUPLICATE --- Comment #18 from Jonathan Druart <jonathan.druart@biblibre.com> --- Hi Amit, I proposed the original patch of this feature in Bug 5343. Given that it was easiest to me to recreate a new patch from scratch and the patch I proposed do the same thing as your one, I mark this bug as duplicate. *** This bug has been marked as a duplicate of bug 5343 *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8415 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=5343 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org