[Bug 29747] New: Cataloguing upload plugin broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29747 Bug ID: 29747 Summary: Cataloguing upload plugin broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org When 856$u has plugin 'upload.pl' attached, the choosing of the record fails because of a dataTables error. When fetching the column settings, we need to account for the fact that the plugin has 2 fewer columns -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29747 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29747 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 128833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128833&action=edit Bug 29747: Delete columns that don't exist from settings This patch simply checks if we are callinmg from the plugin, and removes two columns from the settings if so To test: 1 - In Admin->Marc bibliographic framework got to Marc Structure for default framework 2 - Search for 856$u 3 - Set Plugin to upload.pl 4 - Edit a record in the default framework 5 - Under 856u, click 'Upload' 6 - Uplaod a file and then click 'Choose' 7 - nothing happens 8 - View consiole (f12) and see error 9 - Apply patch 10 - Reload the page 11 - No more error 12 - Click choose 13 - Record link is populated -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29747 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29747 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28177 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28177 [Bug 28177] Add date column and column configuration to uploads -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29747 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29747 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128833|0 |1 is obsolete| | --- Comment #2 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 128839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128839&action=edit Bug 29747: Delete columns that don't exist from settings This patch simply checks if we are callinmg from the plugin, and removes two columns from the settings if so To test: 1 - In Admin->Marc bibliographic framework got to Marc Structure for default framework 2 - Search for 856$u 3 - Set Plugin to upload.pl 4 - Edit a record in the default framework 5 - Under 856u, click 'Upload' 6 - Uplaod a file and then click 'Choose' 7 - nothing happens 8 - View consiole (f12) and see error 9 - Apply patch 10 - Reload the page 11 - No more error 12 - Click choose 13 - Record link is populated Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29747 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29747 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128839|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 128862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128862&action=edit Bug 29747: Delete columns that don't exist from settings This patch simply checks if we are callinmg from the plugin, and removes two columns from the settings if so To test: 1 - In Admin->Marc bibliographic framework got to Marc Structure for default framework 2 - Search for 856$u 3 - Set Plugin to upload.pl 4 - Edit a record in the default framework 5 - Under 856u, click 'Upload' 6 - Uplaod a file and then click 'Choose' 7 - nothing happens 8 - View consiole (f12) and see error 9 - Apply patch 10 - Reload the page 11 - No more error 12 - Click choose 13 - Record link is populated Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29747 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29747 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29747 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29747 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29747 --- Comment #4 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29747 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |kyle@bywatersolutions.com Version(s)|22.05.00 |22.05.00,21.11.02 released in| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.11.x for 21.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29747 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED CC| |andrew@bywatersolutions.com Resolution|--- |FIXED --- Comment #6 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Missing dependency, not backported to 21.05 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org