[Bug 13392] New: New statistics wizard for suggestions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 Bug ID: 13392 Summary: New statistics wizard for suggestions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: new feature Priority: P5 - low Component: Reports Assignee: julian.maurice@biblibre.com Reporter: julian.maurice@biblibre.com QA Contact: testopia@bugs.koha-community.org Statistics wizard for suggestions -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 34124 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34124&action=edit Bug 13392: Add suggestions.ordereddate and suggestions.orderedby Those fields are updated when suggestion status is changed to 'ORDERED' and are displayed on suggestion/suggestion.pl page -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 --- Comment #2 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 34125 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34125&action=edit Bug 13392: New statistics assistant for suggestions New sub C4::Budgets::GetBudgetDescendantsIds (with unit tests) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #3 from Julian Maurice <julian.maurice@biblibre.com> --- Test plan: 1/ Go to Reports > Statistics wizard > Suggestions 2/ Play with it and check if result is consistent with what you have in your database. All fields used in this wizard correspond to a column in the suggestions table, except for categorycode, sort1 and sort2, which correspond to the borrowers fields of the user who made the suggestion (suggestedby). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34125|0 |1 is obsolete| | --- Comment #4 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 34135 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34135&action=edit Bug 13392: New statistics assistant for suggestions New sub C4::Budgets::GetBudgetDescendantsIds (with unit tests) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34135|0 |1 is obsolete| | --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 34136 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34136&action=edit Bug 13392: New statistics assistant for suggestions New sub C4::Budgets::GetBudgetDescendantsIds (with unit tests) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 beroud <isabelle.beroud@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |isabelle.beroud@univ-lyon3. | |fr --- Comment #6 from beroud <isabelle.beroud@univ-lyon3.fr> --- All fields used in this wizard correspond to a column in the suggestions table : it's ok. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes@biblibre.com --- Comment #7 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Beroud <isabelle.beroud@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34124|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34136|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 --- Comment #8 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 34328 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34328&action=edit Bug 13392: Add suggestions.ordereddate and suggestions.orderedby Those fields are updated when suggestion status is changed to 'ORDERED' and are displayed on suggestion/suggestion.pl page Signed-off-by: Beroud <isabelle.beroud@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 --- Comment #9 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 34329 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34329&action=edit Bug 13392: New statistics assistant for suggestions New sub C4::Budgets::GetBudgetDescendantsIds (with unit tests) Signed-off-by: Beroud <isabelle.beroud@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Signed Off |Failed QA --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Julian, I feel like this would have been a bit better split up into 2 separate bugs/features. Tried a few things and have some first feedback from code review and tests: Bug 13392: Add suggestions.ordereddate and suggestions.orderedby 1) I am not sure about adding ordereddate and orderedby as those seem duplicating the information we can get from aqorders.entrydate and aqbasket.authorisedby. Bug 13392: New statistics assistant for suggestions 1) The new tests don't give any information when run, please add a description. 2) Using the Koha:I18N is an option now, but I think we haven't created the po file that is needed for it yet. Those strings appear already multiple times in the templates, so the translators have to make sure to translate them the same as everywhere else. I feel it might be easier if we moved them to the template. But more important, the custom suggestion statuses are not supported by the new wizard (authorized value SUGGEST_STATUS) 3) For MARC21 the publicationyear is saved in the copyrightdate column in the database. Please change so that copyrightdate is used in the SQL query for MARC21 databases. 4) The bsort1 and bsort2 fields can be freetext if there are no entries in the authorised value categories - maybe show an input field in that case? 5) Please rename branch to library on the suggestion form. And maybe just "Reason" instead of "Reject reason"? The reasons can also be positive. In testing this I had difficulties with getting a suggestion into the ORDERED status with and without the patches - can you check if that works for you? The new database fields stayed empty too :( -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #11 from Julian Maurice <julian.maurice@biblibre.com> ---
1) I am not sure about adding ordereddate and orderedby as those seem duplicating the information we can get from aqorders.entrydate and aqbasket.authorisedby.
It seems there is no direct link between a suggestion and an order line. Are you suggesting we should create this link ?
3) For MARC21 the publicationyear is saved in the copyrightdate column in the database. Please change so that copyrightdate is used in the SQL query for MARC21 databases.
It seems in fact that suggestions.publicationyear is not used at all (my own database only contains NULL or 0 in this column whereas copyrightdate contains the actual data)
In testing this I had difficulties with getting a suggestion into the ORDERED status with and without the patches - can you check if that works for you? The new database fields stayed empty too :(
Yes, it worked for me, but I will re-check. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34328|0 |1 is obsolete| | --- Comment #12 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 35835 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35835&action=edit Bug 13392: Add suggestions.ordereddate and suggestions.orderedby Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34329|0 |1 is obsolete| | --- Comment #13 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 35836 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35836&action=edit Bug 13392: New statistics assistant for suggestions Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 --- Comment #14 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 35837 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35837&action=edit Bug 13392: QA fixes 1/ Add tests descriptions 2/ Do not use Koha::I18N for suggestion statuses, and add statuses from SUGGEST_STATUS authorised values 3/ Use copyrightdate instead of publicationyear which seems to be unused 4/ Display free text filters if there is no values in corresponding authorised values list 5/ Rename 'Branch' to 'Library' and 'Reject reason' to 'Reason' -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #15 from Julian Maurice <julian.maurice@biblibre.com> ---
In testing this I had difficulties with getting a suggestion into the ORDERED status with and without the patches - can you check if that works for you? The new database fields stayed empty too :(
Yes, it worked for me, but I will re-check.
Apparently it works only when the suggestion is not linked to an existing record (ie. the record is created while creating the order line). I don't know if this is a bug or not. And of course you need to run updatedatabase and misc/devel/update_dbix_class_files.pl (I always forget the latter) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Julian, sorry, I don't understand the last comment - can you give an example/step by step for both cases maybe? Thx! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 --- Comment #17 from Julian Maurice <julian.maurice@biblibre.com> --- Here's a simple step by step example that worked for me: 1/ Create a new suggestion 2/ Mark it as ACCEPTED 3/ Create a new order from this suggestion After these steps a new biblio record should be created, the suggestion should be linked to it and its status should be ORDERED. In the basket view, you should see a link to the suggestion. But before that make sure you've run the updatedatabase script and the script in misc/devel/update_dbix_class_files.pl My remark was about if we create a suggestion from a suggestion that is already linked to a biblionumber (maybe the suggestion was already ORDERED and someone reset status to ACCEPTED), then the suggestion status is not updated. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35835|0 |1 is obsolete| | Attachment #35836|0 |1 is obsolete| | Attachment #35837|0 |1 is obsolete| | --- Comment #18 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 36188 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36188&action=edit Bug 13392: Add suggestions.ordereddate and suggestions.orderedby Those fields are updated when suggestion status is changed to 'ORDERED' and are displayed on suggestion/suggestion.pl page -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 --- Comment #19 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 36189 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36189&action=edit Bug 13392: New statistics assistant for suggestions New sub C4::Budgets::GetBudgetDescendantsIds (with unit tests) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 --- Comment #20 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 36190 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36190&action=edit Bug 13392: QA fixes 1/ Add tests descriptions 2/ Do not use Koha::I18N for suggestion statuses, and add statuses from SUGGEST_STATUS authorised values 3/ Use copyrightdate instead of publicationyear which seems to be unused 4/ Display free text filters if there is no values in corresponding authorised values list 5/ Rename 'Branch' to 'Library' and 'Reject reason' to 'Reason' -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #21 from Jonathan Druart <jonathan.druart@biblibre.com> --- Last patches fixed an easy conflict on updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #22 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Nicole Engard <nengard@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36188|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36189|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36190|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 --- Comment #23 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 36343 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36343&action=edit Bug 13392: Add suggestions.ordereddate and suggestions.orderedby Those fields are updated when suggestion status is changed to 'ORDERED' and are displayed on suggestion/suggestion.pl page Signed-off-by: Nicole Engard <nengard@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 --- Comment #24 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 36344 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36344&action=edit Bug 13392: New statistics assistant for suggestions New sub C4::Budgets::GetBudgetDescendantsIds (with unit tests) Signed-off-by: Nicole Engard <nengard@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 --- Comment #25 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 36345 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36345&action=edit Bug 13392: QA fixes 1/ Add tests descriptions 2/ Do not use Koha::I18N for suggestion statuses, and add statuses from SUGGEST_STATUS authorised values 3/ Use copyrightdate instead of publicationyear which seems to be unused 4/ Display free text filters if there is no values in corresponding authorised values list 5/ Rename 'Branch' to 'Library' and 'Reject reason' to 'Reason' Signed-off-by: Nicole Engard <nengard@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 Courret <scourret@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |scourret@gmail.com Status|Signed Off |Needs Signoff --- Comment #26 from Courret <scourret@gmail.com> --- The suggest date wizard works good. But it seems that Koha reports some suggestions that were rejected, even if these suggestions do not appear in the staff interface. Some rejected suggestions that were refused for a lack of budget in the pro interface do not appear later in the wizard report. Similar issue of inconsistency of results for pending suggestions : 9 reported in the wizard while 19 appear in Koha pro interface. Unfortunately, we miss a running phpmyadmin interface to check the real content of the database. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |nengard@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Courret, you could create a sql report with the following statement: select * from suggestions; This will show you everything that is in your suggestions table. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #28 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Julian, working on this again: 1) The QA script outputs some warnings, could you please take a look? I can also see those in my logs on accessing the new page: Processing files before patches |========================>| 13 / 13 (100.00%) Processing files after patches Argument "" isn't numeric in numeric gt (>) at /home/katrin/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/reports/suggestions_stats.tt line 52. Argument "" isn't numeric in numeric gt (>) at /home/katrin/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/reports/suggestions_stats.tt line 52. Argument "" isn't numeric in numeric gt (>) at /home/katrin/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/reports/suggestions_stats.tt line 52. Argument "" isn't numeric in numeric gt (>) at /home/katrin/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/reports/suggestions_stats.tt line 52. Argument "" isn't numeric in numeric gt (>) at /home/katrin/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/reports/suggestions_stats.tt line 52. Argument "" isn't numeric in numeric gt (>) at /home/katrin/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/reports/suggestions_stats.tt line 52. |========================>| 13 / 13 (100.00%) 2) Some strings need to be changed from 'Acquisitions' to 'Suggestions' - like the table legend on the form and the heading on the result page. 3) We need some POD for the new GetBudgetDescendantsIds. 4) I was worried about some of the TT constructs translatability and ran some tests, but looking good so far :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36343|0 |1 is obsolete| | --- Comment #29 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 40305 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40305&action=edit Bug 13392: Add suggestions.ordereddate and suggestions.orderedby Those fields are updated when suggestion status is changed to 'ORDERED' and are displayed on suggestion/suggestion.pl page Signed-off-by: Nicole Engard <nengard@bywatersolutions.com> Patch updated: Use atomic update -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36344|0 |1 is obsolete| | --- Comment #30 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 40306 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40306&action=edit Bug 13392: New statistics assistant for suggestions New sub C4::Budgets::GetBudgetDescendantsIds (with unit tests) Signed-off-by: Nicole Engard <nengard@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36345|0 |1 is obsolete| | --- Comment #31 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 40307 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40307&action=edit Bug 13392: QA fixes 1/ Add tests descriptions 2/ Do not use Koha::I18N for suggestion statuses, and add statuses from SUGGEST_STATUS authorised values 3/ Use copyrightdate instead of publicationyear which seems to be unused 4/ Display free text filters if there is no values in corresponding authorised values list 5/ Rename 'Branch' to 'Library' and 'Reject reason' to 'Reason' Signed-off-by: Nicole Engard <nengard@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 --- Comment #32 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 40308 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40308&action=edit [Follow-up] Bug 13392 - Fix QA failures: - Fix a perl warning in suggestions_stats.tt, - Replace term "Acquisitions" with "Suggestions", - Add POD for GetBudgetDescendantsIds. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff CC| |alex.arnaud@biblibre.com --- Comment #33 from Alex Arnaud <alex.arnaud@biblibre.com> --- I rebased patches on master / updated them to use atomic update and fix Katrin' QA comments. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |bgkriegel@gmail.com --- Comment #34 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Sorry, does not apply CONFLICT (content): Merge conflict in t/db_dependent/Budgets.t Auto-merging C4/Budgets.pm Failed to merge in the changes. Patch failed at 0001 Bug 13392: New statistics assistant for suggestions -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org