[Bug 18706] New: subfields to delete not disabled anymore in batch item modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18706 Bug ID: 18706 Summary: subfields to delete not disabled anymore in batch item modification Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Tools Assignee: gmcharlt@gmail.com Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org In Tools > Batch item modification, one can click a checkbox to delete a subfield. This click use to disable the input to change the field value. This comes from the patch : Bug 13501: Move "Required" and checkbox after input/select Because input is found using JQuery next(). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18706 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18706 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18706 --- Comment #1 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 63864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63864&action=edit Bug 18706 - subfields to delete not disabled anymore in batch item modification In Tools > Batch item modification, one can click a checkbox to delete a subfield. This click use to disable the input to change the field value. This comes from the patch : Bug 13501: Move "Required" and checkbox after input/select Because input is found using JQuery next(). This patch replaces with $(this).parent().find("[name='field_value']"). Test plan : - Go to Tools > Batch item modification - Enter a barcode and submit - Click on a checkbox on a non-mandatory subfield => Without patch the input or select is not disabled => With patch the input or select is disabled - Submit => Check that subfield is deleted -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18706 --- Comment #2 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 63865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63865&action=edit Bug 18706 - Remove useless Javascript Whe checking a subfield to be deleted, the code $(this).val($(this).siblings("[name='subfield']").val()); is useless, the checkbox already contains the subfield code : <input type="checkbox" ... name="disable_input" value="[% ite.subfield %]" /> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18706 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18707 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18706 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18710 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18710 [Bug 18710] Wrong subfield modified in batch item modification -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18706 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18706 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63864|0 |1 is obsolete| | --- Comment #3 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 63890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63890&action=edit [SIGNED-OFF] Bug 18706 - subfields to delete not disabled anymore in batch item modification In Tools > Batch item modification, one can click a checkbox to delete a subfield. This click use to disable the input to change the field value. This comes from the patch : Bug 13501: Move "Required" and checkbox after input/select Because input is found using JQuery next(). This patch replaces with $(this).parent().find("[name='field_value']"). Test plan : - Go to Tools > Batch item modification - Enter a barcode and submit - Click on a checkbox on a non-mandatory subfield => Without patch the input or select is not disabled => With patch the input or select is disabled - Submit => Check that subfield is deleted Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18706 --- Comment #4 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 63891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63891&action=edit [SIGNED-OFF] Bug 18706 - Remove useless Javascript Whe checking a subfield to be deleted, the code $(this).val($(this).siblings("[name='subfield']").val()); is useless, the checkbox already contains the subfield code : <input type="checkbox" ... name="disable_input" value="[% ite.subfield %]" /> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18706 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com Attachment #63865|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18706 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13501 CC| |jonathan.druart@bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 [Bug 13501] Allow autocompletion on drop-down lists -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18706 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18706 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63890|0 |1 is obsolete| | Attachment #63891|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64152&action=edit Bug 18706 - subfields to delete not disabled anymore in batch item modification In Tools > Batch item modification, one can click a checkbox to delete a subfield. This click use to disable the input to change the field value. This comes from the patch : Bug 13501: Move "Required" and checkbox after input/select Because input is found using JQuery next(). This patch replaces with $(this).parent().find("[name='field_value']"). Test plan : - Go to Tools > Batch item modification - Enter a barcode and submit - Click on a checkbox on a non-mandatory subfield => Without patch the input or select is not disabled => With patch the input or select is disabled - Submit => Check that subfield is deleted Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18706 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64153&action=edit Bug 18706 - Remove useless Javascript Whe checking a subfield to be deleted, the code $(this).val($(this).siblings("[name='subfield']").val()); is useless, the checkbox already contains the subfield code : <input type="checkbox" ... name="disable_input" value="[% ite.subfield %]" /> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18706 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18706 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #8 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in 17.05.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18706 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.09. Please sign-off on bug 18710! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18706 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #10 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org