[Bug 23081] New: Item search : Filter for Items with Zero Checkouts Returns No Results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23081 Bug ID: 23081 Summary: Item search : Filter for Items with Zero Checkouts Returns No Results Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: jyorio@esilibrary.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- When conducting an item search, if I set the checkout count to = 0, I get "No data available in table" (and there are most definitely items without any checkouts). If I conduct a search that returns results (without filtering by checkout count), and then enter 0 into the box on the search results screen, I get results with 10 checkouts. I expected to get the items with 0 checkouts. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23081 Joelle Hannert <jhannert@nmc.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jhannert@nmc.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23081 Aguayo <azucena.aguayo@uvu.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |azucena.aguayo@uvu.edu --- Comment #1 from Aguayo <azucena.aguayo@uvu.edu> --- My library has been using the Item Search and also noticed the same problem with the checkout count. I think the problem is related to the "issues" field in the "items" table. The "issues" field is of type SMALLINT with a default value of "null" Using a report, I can illustrate the behavior. Example 1: select barcode, issues from items where issues <= <<equal or less than checkouts>> Result 1: Items with checkouts less or equal to the number you enter are listed but NOT items with 0 checkouts. Same as the Item Search. Example 2: select barcode, issues from items where issues is null OR issues <= <<equal or less than checkouts>> Result 2: Items with checkouts less or equal to the number you enter are listed AND any items with no checkouts. What we would expect to get if looking for check count = 0 or < # My assumption is that Koha displays a '0' when viewing an item on the staff client, however the "items" table stores a "null" value in the "issues" field. Limiting the checkout count with a '0' gives no results because there is no '0' in the "issues" field. If possible the "issues" field needs to have the default value set to '0', or the Item Search code needs to account for a "null" value. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23081 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Version|18.11 |master Severity|enhancement |normal --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I've confirmed, issues = 0 doesn't work in item search. Looking for items that haven't been issued is a common use case for weeding, marking this as a bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23081 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23081 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- I'm inclined to agree with Azucena that changing the items.issues default to zero rather than null seems like a good answer here. Changing item search functionality to accommodate those nulls seems like addressing a symptom rather than a root cause. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23081 --- Comment #4 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 103601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103601&action=edit Bug 23081: Change issues fields in items and deleteditems to default to zero -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23081 --- Comment #5 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Not sure I did this correctly, gonna get some eyes on it before I set it to Needs Signoff :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23081 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103601|0 |1 is obsolete| | --- Comment #6 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 103605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103605&action=edit Bug 23081: Change issues fields in items and deleteditems to default to zero -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23081 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103605|0 |1 is obsolete| | --- Comment #7 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 103606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103606&action=edit Bug 23081: Change issues fields in items and deleteditems to default to zero -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23081 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |19.11 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23081 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #8 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Confirmed that item search gives no results for number of checkouts=0 in 19.11. However, in master I *do* get items with issues=null in item search results for checkouts=0. So that search does work in master and I'm not sure what changed, but this schema change seems worthwhile anyway. To test: - save and run this sql query in reports: select sum(if(issues is null,1,0)),sum(if(issues=0,1,0)) from items - you should see a lot of nulls and no zeros - apply patch - updatedatabase - re-run your query and see that your nulls have changed to zeros - create a new item - rerun your query and see your new item is counted in the zeros, not the nulls -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23081 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23081 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103606|0 |1 is obsolete| | --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 103608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103608&action=edit Bug 23081: Change issues fields in items and deleteditems to default to zero Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23081 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24443 CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- The original issue report on this bug report has been fixed by bug 24443. Please edit the bug report title and remove the modifications made by bug 24443. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23081 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|19.11 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23081 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |andrew@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23081 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Item search : Filter for |Make items.issues and |Items with Zero Checkouts |deleteditems.issues default |Returns No Results |to 0 instead of null -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23081 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23081 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103608|0 |1 is obsolete| | --- Comment #11 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 103725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103725&action=edit Bug 23081: set default to 0 for items.issues and deleteditems.issues To test: - save and run this sql query in reports: select sum(if(issues is null,1,0)),sum(if(issues=0,1,0)) from items - you should see a lot of nulls and no zeros - apply patch - updatedatabase - re-run your query and see that your nulls have changed to zeros - create a new item - rerun your query and see your new item is counted in the zeros, not the nulls -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23081 --- Comment #12 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 103726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103726&action=edit Bug 23081: atomicupdate for change to existing installs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23081 --- Comment #13 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Renamed bug and patch and moved the atomicupdate bit into its own patch. Nothing here actually duplicates what was done in 24443. It does make the change in 24443 sort of irrelevant, but I think this schema change is still worth making, as it will make reports easier and cleaner to write. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23081 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Andrew Fuerste-Henry from comment #13)
Renamed bug and patch and moved the atomicupdate bit into its own patch. Nothing here actually duplicates what was done in 24443. It does make the change in 24443 sort of irrelevant, but I think this schema change is still worth making, as it will make reports easier and cleaner to write.
Andrew, yes that is what I was trying to explain. That's why we should remove the changes made by bug 24443, it's no longer relevant. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23081 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23081 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103725|0 |1 is obsolete| | Attachment #103726|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 103741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103741&action=edit Bug 23081: set default to 0 for items.issues and deleteditems.issues To test: - save and run this sql query in reports: select sum(if(issues is null,1,0)),sum(if(issues=0,1,0)) from items - you should see a lot of nulls and no zeros - apply patch - updatedatabase - re-run your query and see that your nulls have changed to zeros - create a new item - rerun your query and see your new item is counted in the zeros, not the nulls Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23081 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 103742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103742&action=edit Bug 23081: atomicupdate for change to existing installs Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23081 --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 103743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103743&action=edit Bug 23081: Revert "Bug 24443: Consider NULL as 0 for issues in items search" This reverts commit 80f1374f262544a750b5d81a7d9605c8708c53b1. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23081 --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 103744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103744&action=edit Bug 23081: Adjust tests Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23081 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23081 --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23081 --- Comment #20 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Thanks, Jonathan, for adding that! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23081 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|20.05.00 |20.05.00, 19.11.06 released in| | --- Comment #21 from Joy Nelson <joy@bywatersolutions.com> --- Backported to 19.11.x for 19.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23081 --- Comment #22 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 104706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104706&action=edit Bug 23081: [19.11.x] Set items.issues to 0 if not provided (AddItem) In master it has been replaced by Koha::Object->store and we deal with the default value. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23081 --- Comment #23 from Joy Nelson <joy@bywatersolutions.com> --- pushed 19.11.x patch to 19.11.x for 19.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23081 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|20.05.00, 19.11.06 |20.05.00, 19.11.06, released in| |19.05.11 CC| |lucas@bywatersolutions.com --- Comment #24 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23081 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #25 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Shouldn't we specify 'NOT NULL', like for itemlost for example : `itemlost` tinyint(1) NOT NULL default 0 I'm using MariaDB 10.4.13, colum issues is created nullable. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23081 --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It looks like this database update might have created quite an issue. Some libraries were looking at deleteditems.timestamp as deletion date, but the database update here altered it, so now it's all update day... :( $DBversion = '19.12.00.080'; if( CheckVersion( $DBversion ) ) { $dbh->do( "UPDATE items set issues=0 where issues is null" ); $dbh->do( "UPDATE deleteditems set issues=0 where issues is null" ); $dbh->do( "ALTER TABLE items ALTER issues set default 0" ); $dbh->do( "ALTER TABLE deleteditems ALTER issues set default 0" ); NewVersion( $DBversion, 23081, "Set default to 0 for items.issues"); } -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23081 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30392 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23081 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29902 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29902 [Bug 29902] While upgrading all empty deleteditems.datelastborrowed turned deleteditems.timestamp to date of upgrade -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org