[Bug 25855] New: Add post_renewal_hook in circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 Bug ID: 25855 Summary: Add post_renewal_hook in circulation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org We need a hook to trigger plugin actions after renweals take place. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 106215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106215&action=edit Bug 25855: Unit tests This patch adds tests fr a new circulation hook for plugins. In this case the post_renewal_action hook, The tests add the hook to the Test plugin, and verify that all the required parameters are passed for the plugin hook to use them. It relies on throwing an exception that is to be caught. Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 106216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106216&action=edit Bug 25855: Add a post_renewal_action plugin hook This patch adds a new hook to notify plugins about renewal actions. To test it: 1. Apply the unit tests 2. Run: $ kshell k$ prove t/db_dependent/Koha/Plugins/Circulation_hooks.t => FAIL: The tests expect some warnings to show, and they don't (i.e. the sample plugin hook is not being called). 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! The hook is being called on renewal! 5. Sign off :-D Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106215|0 |1 is obsolete| | Attachment #106216|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 106248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106248&action=edit Bug 25855: Unit tests This patch adds tests fr a new circulation hook for plugins. In this case the post_renewal_action hook, The tests add the hook to the Test plugin, and verify that all the required parameters are passed for the plugin hook to use them. It relies on throwing an exception that is to be caught. Sponsored-by: ByWater Solutions Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 106249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106249&action=edit Bug 25855: Add a post_renewal_action plugin hook This patch adds a new hook to notify plugins about renewal actions. To test it: 1. Apply the unit tests 2. Run: $ kshell k$ prove t/db_dependent/Koha/Plugins/Circulation_hooks.t => FAIL: The tests expect some warnings to show, and they don't (i.e. the sample plugin hook is not being called). 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! The hook is being called on renewal! 5. Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Please remember to document on the wiki: https://wiki.koha-community.org/wiki/Koha_Plugin_Hooks Thx! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Katrin Fischer from comment #5)
Please remember to document on the wiki: https://wiki.koha-community.org/wiki/Koha_Plugin_Hooks Thx!
Done! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21468 CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Comment on attachment 106248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106248 Bug 25855: Unit tests Review of attachment 106248: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=25855&attachment=106248) ----------------------------------------------------------------- ::: t/db_dependent/Koha/Plugins/Circulation_hooks.t @@ +68,5 @@
+ 'AddBiblio calls the hook with action=create'; + + warning_like { $item = $builder->build_sample_item({ biblionumber => $biblio->biblionumber }); } + qr/after_item_action called with action: create, ref: Koha::Item/, + 'AddItem calls the hook with action=create';
Hmm.. does it make sense to additionally test the AddBiblio and AddItem hooks here.. they're already well tested within Koha/Plugins/Biblio_and_Items_plugin_hooks.t aren't they? @@ +72,5 @@
+ 'AddItem calls the hook with action=create'; + + warning_like { AddIssue( $patron->unblessed, $item->barcode ); } + qr/after_item_action called with action: modify, ref: Koha::Item/, + 'AddItem calls the hook with action=modify';
'AddIssue' is being tested here.. not AddItem... must admit it feels a little strange that we trigger the item modification hook on an issue.. though I think I understand how that comes about. @@ +77,5 @@
+ + warnings_like { AddRenewal( $patron->borrowernumber, $item->id, $patron->branchcode ); } + [ qr/after_item_action called with action: modify, ref: Koha::Item/, + qr/post_renewal_action .* DateTime/ ], + 'AddRenewal calls the post_renewal_action hook';
I have a vague feeling renewals can be triggered via AddIssue as well as AddRenewal.... might be worth also testing that case to make sure you're always triggering as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Comment on attachment 106249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106249 Bug 25855: Add a post_renewal_action plugin hook Review of attachment 106249: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=25855&attachment=106249) ----------------------------------------------------------------- ::: C4/Circulation.pm @@ +4292,4 @@
return 0; }
+=head3 _post_renewal_actions
Hmm.. could we perhaps be a bit more forward-thinking here and adopt a more generic approach akin to that taken in C4/Biblio.pm where we have '_after_biblio_actions_hooks' which accepts and action param.. perhaps we could have `_after_circ_action_hooks` here and then in followup bugs we can extend it easily to support the other actions available within the module? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21468 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21468 [Bug 21468] ILL backends/plugins need hooks into checkin and checkout -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add post_renewal_hook in |Add after_circ_hook in |circulation |circulation --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Taking Martin's suggestion to generalize this hook I'm renaming it 'after_circ_action' and made the params be 'action' ('renewal' in this case) and 'payload' for all we want to pass the plugin. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 106513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106513&action=edit Bug 25855: (QA follow-up) Generalize hook and simplify tests This patch generalizes the hook so it can be used by other circulation actions. Tests are also simplified by mocking some of the (extensive) plugin hooks. To test: 1. Repeat the test plan on the original patch => SUCCESS: All good 2. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106248|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 106568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106568&action=edit Bug 25855: Unit tests This patch adds tests fr a new circulation hook for plugins. In this case the post_renewal_action hook, The tests add the hook to the Test plugin, and verify that all the required parameters are passed for the plugin hook to use them. It relies on throwing an exception that is to be caught. Sponsored-by: ByWater Solutions Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106249|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 106569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106569&action=edit Bug 25855: Add a post_renewal_action plugin hook This patch adds a new hook to notify plugins about renewal actions. To test it: 1. Apply the unit tests 2. Run: $ kshell k$ prove t/db_dependent/Koha/Plugins/Circulation_hooks.t => FAIL: The tests expect some warnings to show, and they don't (i.e. the sample plugin hook is not being called). 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! The hook is being called on renewal! 5. Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106513|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 106570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106570&action=edit Bug 25855: (QA follow-up) Generalize hook and simplify tests This patch generalizes the hook so it can be used by other circulation actions. Tests are also simplified by mocking some of the (extensive) plugin hooks. To test: 1. Repeat the test plan on the original patch => SUCCESS: All good 2. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Excellent work, Thanks Tomas Works well, fully tested and passes QA scripts. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Please remember to update the wiki :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Hmm, One final question actually.. now I've started to look into utilising the hook for AddIssue. Do we need to add a 'type' parameter into the payload to distinguish between OPAC, Staff, SIP and Autorenewals? It feels like something a plugin may want to know about and handle distinctly? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add after_circ_hook in |Add hook to AddRenewal |circulation |using a new | |_after_circ_actions method | |in circulation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 --- Comment #17 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Martin Renvoize from comment #16)
Hmm, One final question actually.. now I've started to look into utilising the hook for AddIssue.
Do we need to add a 'type' parameter into the payload to distinguish between OPAC, Staff, SIP and Autorenewals? It feels like something a plugin may want to know about and handle distinctly?
That's an excellent idea. Are you adding a follow-up here? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I'll file a bug... it's not a trivial addition and currently, we don thave a clear use case for it.. just a 'nice to have'. Leaving this as PQA :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25938 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25938 [Bug 25938] Identify the renewal type in the renewal after_circ_action hook -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #19 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- A couple of questions: 1. Why do we have the hook before UpdateStats and logaction? We could imagine a plugin that want to deal with them, and so get up-to-date info 2. A renewal is identified by an issue_id, why don't we only pass the issue_id to the plugin? It could then retrieve the info it wants. We should limit the number of params we pass, we only need to inform the plugin "yeah, we've just renewed this!". It will make the plugins' api more robust and maintainable IMO. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 --- Comment #20 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Additional question: what happens (and what is the expected behaviour) if the plugin fails? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 --- Comment #21 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #20)
Additional question: what happens (and what is the expected behaviour) if the plugin fails?
Related with patch "Bug 24031: Add safety checks in Koha::Plugins::call" https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105697 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 --- Comment #22 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #20)
Additional question: what happens (and what is the expected behaviour) if the plugin fails?
They are eval-ed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 --- Comment #23 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #19)
A couple of questions:
1. Why do we have the hook before UpdateStats and logaction? We could imagine a plugin that want to deal with them, and so get up-to-date info
2. A renewal is identified by an issue_id, why don't we only pass the issue_id to the plugin? It could then retrieve the info it wants. We should limit the number of params we pass, we only need to inform the plugin "yeah, we've just renewed this!". It will make the plugins' api more robust and maintainable IMO.
Those are valid questions. About the stats calls, I only copied what we already do. The most relevant information is the issue_id and the new date due. My impression was that we could send all the info we already had. In my case I needed the itemnumber and date due so my plugin notified a third party system and no extra call to the DB is required. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 --- Comment #24 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- At this point I'd privilege robustness and maintainability over extra calls :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 --- Comment #25 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 107251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107251&action=edit Bug 25855: (QA follow-up) Simplify payload This patch makes the hook be passed the Koha::Checkout object instead of a hand-crafted list of attributes. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107251|0 |1 is obsolete| | --- Comment #26 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 107257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107257&action=edit Bug 25855: (QA follow-up) Simplify payload This patch makes the hook be passed the Koha::Checkout object instead of a hand-crafted list of attributes. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 --- Comment #27 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I decided to keep the 'payload' parameter so if bug 25938 adds more information we don't change the API. I hope it fulfils your requirement, Jonathan. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26063 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26063 [Bug 26063] Use Koha::Plugins->call for circulation hooks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 --- Comment #28 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 --- Comment #29 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- kohadev-koha@kohadevbox:/kohadevbox/koha$ prove t/db_dependent/SIP/Message.t t/db_dependent/SIP/Message.t .. 2/7 # Looks like you planned 29 tests but ran 5. # Failed test 'Checkin V2' # at t/db_dependent/SIP/Message.t line 74. Can't call method "id" on an undefined value at /kohadevbox/koha/C4/Circulation.pm line 2209. The issue may not exist. Please fix. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 --- Comment #30 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Also 1. t/db_dependent/Reserves.t .. 2/63 Can't call method "id" on an undefined value at /kohadevbox/koha/C4/Circulation.pm line 2209. 2. t/db_dependent/Circulation/issue.t .. 21/46 Use of uninitialized value $resfound in string eq at /kohadevbox/koha/C4/Circulation.pm line 2127. Can't call method "id" on an undefined value at /kohadevbox/koha/C4/Circulation.pm line 2209. 3. # Failed test 'No tests run for subtest "checkin_lost"' # at t/db_dependent/SIP/Transaction.t line 360. Can't call method "id" on an undefined value at /kohadevbox/koha/C4/Circulation.pm line 2209. 4. # Failed test 'bug 22877' # at t/db_dependent/Circulation.t line 2455. # Looks like you planned 8 tests but ran 5. # Looks like you failed 1 test of 5 run. t/db_dependent/Circulation.t .. 31/49 # Failed test 'AddReturn | is_overdue' # at t/db_dependent/Circulation.t line 2669. Can't call method "id" on an undefined value at /kohadevbox/koha/C4/Circulation.pm line 2209. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26108 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26108 [Bug 26108] Checkins should not require item to have been checked out -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 --- Comment #31 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Failures reported on bug 26108 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #32 from Lucas Gass <lucas@bywatersolutions.com> --- I will backport this but first I will wait until bZ26108 is pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 --- Comment #33 from Lucas Gass <lucas@bywatersolutions.com> --- after consideringthis bug for 20.05.x I have decided not to backport this enhancement -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds release notes| |plugin hooks to allow | |plugins to take action | |after renewal circulation | |events. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org