[Bug 17188] New: Koha does not support several memcached servers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17188 Bug ID: 17188 Summary: Koha does not support several memcached servers Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org There is a bug in the initialisation of memcached, the server string is not correctly parsed. If several memcached servers are defined, they are separated by commas and so the string should be split accordingly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17188 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17188 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 54814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54814&action=edit Bug 17188: Fix support of several memcached servers There is a bug in the initialisation of memcached, the server string is not correctly parsed. If several memcached servers are defined, they are separated by commas and so the string should be split accordingly Test plan: 1/ Set MEMCACHED_SERVERS='localhost:11211,localhost:11222' 2/ Set DEBUG=1 3/ Reload plack, and check the log => Without this patch, you see Memcached server settings: localhost:11211,localhost:11222 with koha Selected caching system: Cache::Memory=HASH(0x9de2034) i.e. Memcached has not been configured correctly and the default caching system is used (Cache::Memory) => With this patch, you should see Memcached server settings: localhost:11211, localhost:11222 with koha Selected caching system: Cache::Memcached::Fast=SCALAR(0xa2a0c54) i.e. Memcached has been configured correctly \o/ Note that the cache_servers attribute is never set and it not used. It's better to remove it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17188 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16579 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16579 [Bug 16579] Use separate memcached namespace for caching koha-conf.xml -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17188 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11921 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11921 [Bug 11921] memcached configuration should be moved back to koha-conf.xml -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17188 Jacek Ablewicz <abl@biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl@biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17188 --- Comment #2 from Jacek Ablewicz <abl@biblos.pk.edu.pl> --- It's strange, but I'm not able to reproduce this issue in unpatched master (wheezy, 5.14.2, no plack). I'm wondering if plack / no plack can be a factor here (and if yes - why?). This statement my @servers = split /,/, $self->{'cache_servers'} ? $self->{'cache_servers'} : ($ENV{MEMCACHED_SERVERS} || ''); (while ugly as bat s**t) seems to work fine for me, I'm getting: Default caching system: memcached at /home/koha/devkohaclone/C4/Context.pm line 514 Memcached server settings: localhost:11301, localhost:11302 with koha at /home/koha/devkohaclone/C4/Context.pm line 514 Selected caching system: Cache::Memcached::Fast=SCALAR(0x297b488) at /home/koha/devkohaclone/C4/Context.pm line 514 in both patched and unpatched master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17188 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |INVALID --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Indeed I misread the code and it works as expected. It's weird I have no idea how I have invented this bug neither this test plan... -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org