[Bug 22816] New: OPAC detail holdings table doesn't fill it's div
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22816 Bug ID: 22816 Summary: OPAC detail holdings table doesn't fill it's div Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: wizzyrea@gmail.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- it could fit better, so let's make it so. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22816 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22816 --- Comment #1 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 89158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89158&action=edit Bug 22816: OPAC detail holdings table should now look a bit better This patch sets the "autowidth" option to "false" for the OPAC holdings DataTable on opac-detail.pl. This gives the table a fluid width rather than having the width be "hard-coded" by DataTables upon first page render. To test, apply the patch and view the detail page for a bibliographic record with some items. Under the "Holdings" tab, the table of holdings should fill the width of the tab container. Resize the browser window and confirm that the table width adjusts accordingly. thanks to Owen Leonard for the initial fix for the subscriptions table and the test plan. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22816 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |wizzyrea@gmail.com CC| |wizzyrea@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22816 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|OPAC detail holdings table |OPAC detail holdings table |doesn't fill it's div |doesn't fill it's container -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22816 Bin <bin.wen@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22816 Bin <bin.wen@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89158|0 |1 is obsolete| | --- Comment #2 from Bin <bin.wen@inlibro.com> --- Created attachment 89326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89326&action=edit Bug 22816: OPAC detail holdings table should now look a bit better This patch sets the "autowidth" option to "false" for the OPAC holdings DataTable on opac-detail.pl. This gives the table a fluid width rather than having the width be "hard-coded" by DataTables upon first page render. To test, apply the patch and view the detail page for a bibliographic record with some items. Under the "Holdings" tab, the table of holdings should fill the width of the tab container. Resize the browser window and confirm that the table width adjusts accordingly. Signed-off-by: Bin Wen <bin.wen@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22816 Arthur Bousquet <arthur.bousquet@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89326|0 |1 is obsolete| | --- Comment #3 from Arthur Bousquet <arthur.bousquet@inlibro.com> --- Created attachment 89328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89328&action=edit Bug 22816: OPAC detail holdings table should now look a bit better This patch sets the "autowidth" option to "false" for the OPAC holdings DataTable on opac-detail.pl. This gives the table a fluid width rather than having the width be "hard-coded" by DataTables upon first page render. To test, apply the patch and view the detail page for a bibliographic record with some items. Under the "Holdings" tab, the table of holdings should fill the width of the tab container. Resize the browser window and confirm that the table width adjusts accordingly. Signed-off-by: Bin Wen <bin.wen@inlibro.com> Signed-off-by: arthur <arthur.bousquet@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22816 Arthur Bousquet <arthur.bousquet@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.bousquet@inlibro.com --- Comment #4 from Arthur Bousquet <arthur.bousquet@inlibro.com> --- The bug isn't present in Firefox 67.0b16 but is in Chrome 74.0.3729.131 The patch works for this version of Chrome an doesn't change anything in Firefox -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22816 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22816 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89328|0 |1 is obsolete| | --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 89351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89351&action=edit Bug 22816: OPAC detail holdings table should now look a bit better This patch sets the "autowidth" option to "false" for the OPAC holdings DataTable on opac-detail.pl. This gives the table a fluid width rather than having the width be "hard-coded" by DataTables upon first page render. To test, apply the patch and view the detail page for a bibliographic record with some items. Under the "Holdings" tab, the table of holdings should fill the width of the tab container. Resize the browser window and confirm that the table width adjusts accordingly. Signed-off-by: Bin Wen <bin.wen@inlibro.com> Signed-off-by: arthur <arthur.bousquet@inlibro.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22816 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22816 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable Version(s)| |19.05.00, 18.11.06 released in| | CC| |martin.renvoize@ptfs-europe | |.com --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22816 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 18.05.x for 18.05.13 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22816 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org