[Bug 30931] New: Handling of items.dateaccessioned in the item editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30931 Bug ID: 30931 Summary: Handling of items.dateaccessioned in the item editor Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: alexbuckley@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl This bug report is for the community to decide which of the following is desired for handling of the dateaccessioned field in the item editor: 1. A hint - To tell users if they leave the items.dateaccessioned field (which is typically linked to the 952$d subfield) empty when adding a new item in serials, cataloguing, or acquisitions then Koha will automatically save the current date in that field. OR 2. Context-aware behaviour - Koha only pre-fills the item editor dateaccessioned field with the current date when the item is added/new. Shifting this discussion away from bug 29963 so the community can proceed to upstream the reversion of bug 29815 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30931 --- Comment #1 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 135854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135854&action=edit Bug 30931: Display a hint in item editor that the dateaccessioned will be filled with current date if left blank This hint will show when: - Adding an item - Editing an item - Receiving a serial issue Test plan: 1. Apply patch 2. Add an item to a biblio record, notice there is a hint message for the 952$d (date acquired) subfield 3. Edit an item, notice there is a hint message displaying for the 952$d subfield 4. Receive a serial (The subscription must be setup to create an item upon receival to test this). 5. Notice there is a hint message displaying for the 952$d (Date acquired) subfield in both the main issue you are receiving and the supplemental issue form as well Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30931 --- Comment #2 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 135855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135855&action=edit Bug 30931: Restore original intention of bug 29815 This patch restores the original intended behaviour of bug 29815; To pre-populate the dateaccessioned field on item creations only. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30931 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bdaeuber@cityoffargo.com, | |jonathan.druart+koha@gmail. | |com, | |martin.renvoize@ptfs-europe | |.com, nugged@gmail.com, | |slavashishkin@gmail.com Status|NEW |In Discussion Depends on| |29963 --- Comment #3 from Alex Buckley <alexbuckley@catalyst.net.nz> --- I have copied Martin's and my patches from bug 29963 onto this bug report. This is so, hopefully, the discussions around if a hint or context-aware logic should be implemented for handling the dateaccessioned field in the item editor can happen here. Freeing up bug 29963 to upstream a reversion of bug 29815 I have taken the liberty of adding people involved in bug 29963 to this bug report, please feel free to remove yourself if you wish. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29963 [Bug 29963] Date accessioned plugin should not automatically fill today's date on cataloguing screens -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30931 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff Assignee|koha-bugs@lists.koha-commun |alexbuckley@catalyst.net.nz |ity.org | --- Comment #4 from Alex Buckley <alexbuckley@catalyst.net.nz> --- There are two patches attached, each represents a different approach for handling the dateaccessioned field on the item editor: * Hint patch: 'Bug 30931: Display a hint in the item editor that the dateaccessioned will be filled with current date if left blank' * Context-specific patch: 'Bug 30931: Restore original intention of bug 29815' - This is context-specific logic because it only pre-populates the dateaccessioned field in the item editor page when creating new items. Please take a look, and note your preferred approach :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30931 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #5 from David Nind <david@davidnind.com> --- Hi Alex. I've posted a message on the koha-US cataloguing special interest group mailing list. I hope that will help with getting some feedback. David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30931 --- Comment #6 from Alex Buckley <alexbuckley@catalyst.net.nz> --- (In reply to David Nind from comment #5)
Hi Alex.
I've posted a message on the koha-US cataloguing special interest group mailing list.
I hope that will help with getting some feedback.
David
Hi David, Thank you very much! Alex -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30931 Heather <heather_hernandez@nps.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |heather_hernandez@nps.gov --- Comment #7 from Heather <heather_hernandez@nps.gov> --- Hi! Thank you for bringing this bug to the attention of the Koha-US CatSIG! I don't have a strong opinion on this behavior, but I'll monitor this bug & see if discussion is generated, and be sure that any discussion on the CatSIG email list makes its way into comments here--and if there isn't any discussion and the bug is still under discussion by our next meeting (July 7, 2022), I'll bring it up in the meeting to call additional attention to it & encourage commenting here. Cheerio! h2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30931 --- Comment #8 from Alex Buckley <alexbuckley@catalyst.net.nz> --- (In reply to Heather from comment #7)
Hi!
Thank you for bringing this bug to the attention of the Koha-US CatSIG! I don't have a strong opinion on this behavior, but I'll monitor this bug & see if discussion is generated, and be sure that any discussion on the CatSIG email list makes its way into comments here--and if there isn't any discussion and the bug is still under discussion by our next meeting (July 7, 2022), I'll bring it up in the meeting to call additional attention to it & encourage commenting here.
Cheerio! h2
Thanks very much Heather, much appreciated! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30931 --- Comment #9 from Benjamin Daeuber <bdaeuber@cityoffargo.com> --- I might be entirely missing something here, but it appears to be impossible to delete the dateaccessioned field now. Is that the intended behavior? The interface allows me to clear it, but the item record is populated with today's date. I was having this behavior with bug 29963 as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30931 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Benjamin Daeuber from comment #9)
I might be entirely missing something here, but it appears to be impossible to delete the dateaccessioned field now. Is that the intended behavior? The interface allows me to clear it, but the item record is populated with today's date. I was having this behavior with bug 29963 as well.
As I pointed out in comment# this is a separate bug filed earlier and unrelated to these changes: Bug 29958 - Missing dateaccessioned is set to today when storing an item But please note: Koha _always_ stored today's date for new items on saving, when the field was left empty. The bug is in setting it to today's date when editing items. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30931 --- Comment #11 from Benjamin Daeuber <bdaeuber@cityoffargo.com> ---
As I pointed out in comment# this is a separate bug filed earlier and unrelated to these changes: Bug 29958 - Missing dateaccessioned is set to today when storing an item
Right, I recall that now. That makes this hard to test since my concern is really in batch modification. The wording on the batch modification screen implies that if you modify 2 items, one with a date acquired and one without, they all need to be set to the same date (either today's date if you leave it blank or all the same date if you fill it in). I think that's a quirk of the wording, but it's hard to tell given that behavior. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30931 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Was just about to add the missing link: bug 29963 comment#28. I am not sure if this bug covers the batch edit as well - Alex might be able to tell. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30931 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135854|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30931 --- Comment #13 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 136663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136663&action=edit Bug 30931: (alternate) Display a hint in item editor that the dateaccessioned will be filled with current date if left blank This hint WILL show when: - Adding a new item - Receiving a serial issue This hint WILL NOT show when: - Batch modifying items - Editing existing items Test plan: 1. Apply patch 2. Add an item to a biblio record. Notice there is a hint message for the 952$d (date acquired) subfield. 3. Edit an existing item. Notice there is no hint message displaying for the 952$d subfield. 4. Batch modify an item by submitting an item barcode into Tools > Batch item modification. Notice no hint message is displayed for the 952$d subfield. 5. Receive a serial (The subscription must be setup to create an item upon receival to test this). 6. Notice there is a hint message displaying for the 952$d (Date acquired) subfield in both the main issue you are receiving and the supplemental issue form as well Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30931 --- Comment #14 from Alex Buckley <alexbuckley@catalyst.net.nz> --- (In reply to Katrin Fischer from comment #12)
Was just about to add the missing link: bug 29963 comment#28. I am not sure if this bug covers the batch edit as well - Alex might be able to tell.
Hi Katrin and Benjamin, Sincere apologies for my delay in replying! This bug report should only cover adding new items/serial issues, not batch editing. However, my previous hint patch on this bug report did incorrectly display on the batch edit page. I agree with Benjamin that having the hint text 'Today's date will be saved in this field if you leave it blank.' display for 952$d (date accessioned) when batch editing existing items is confusing. Therefore, I have modified my patch and attached a new one, so the hint only shows in two situations: - Receiving serial issues - Adding new items The hint no longer displayed when: - Editing individual existing items - Batch editing items Could you please take a look Benjamin? Thanks, Alex -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30931 Slava Shishkin <slavashishkin@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|slavashishkin@gmail.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30931 Bug 30931 depends on bug 29963, which changed state. Bug 29963 Summary: Date accessioned plugin should not automatically fill today's date on cataloguing screens https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29963 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30931 --- Comment #15 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Both patches still apply cleanly to master! Heather, were there any thoughts about this bug report in the Koha-US CatSIG meeting on July 7, 2022? Benjamin, would you mind testing the patches to let us know which behaviour you prefer? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30931 --- Comment #16 from Heather <heather_hernandez@nps.gov> --- Hi! Nothing special to report from CatSIGers--it seems pretty straightforward and welcome! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30931 --- Comment #17 from Benjamin Daeuber <bdaeuber@cityoffargo.com> --- Tested this on master. Plan: 1. Apply patch 2. Add an item to a biblio record. Notice there is a hint message for the 952$d (date acquired) subfield. 3. Edit an existing item. Notice there is no hint message displaying for the 952$d subfield. 4. Batch modify an item by submitting an item barcode into Tools > Batch item modification. Notice no hint message is displayed for the 952$d subfield. Did not test serials, since I don't have anything set up at the moment. Also confirmed that the date did not add when leaving field blank during item modification and batch item modification. I don't have much to say on the actual goal of this bug, so I probably shouldn't add a signoff, but I can confirm this is as expected on item edit screens. I can if you need it, however. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30931 --- Comment #18 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Hi Heather, Benjamin, and Martiin, Thanks very much for your replies Heather and Benjamin! Thank you for testing and offering to sign off Benjamin. Martin: Do you have a preference on which patch is upstreamed? I am happy with either patch :) Thanks, Alex -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30931 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |hammat.wele@inlibro.com --- Comment #19 from Hammat wele <hammat.wele@inlibro.com> --- Test Plan: 1. Apply patch 2. Add an item to a biblio record. Notice there is a hint message for Date acquired field. 3. Edit an existing item. Notice there is no hint message displaying for the Date acquired field. 4. Batch modify an item by submitting an item barcode into Tools > Batch item modification. Notice no hint message is displayed for the Date acquired. 5. Receive a Serial edition by changing status of issue to 'Arrived'. Notice there is a hint message for Date acquired field. 6. But When ordering a purchase suggestions (Acquisitions) there is no hint message displaying for the Date acquired field. The hint message should be displayed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30931 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136663|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30931 --- Comment #20 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 147280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147280&action=edit Bug 30931: (alternate) Display a hint in item editor that the dateaccessioned will be filled with current date if left blank This hint WILL show when: - Adding a new item - Receiving a serial issue - Ordering from a purchase suggestion (Acquisitions module) - Ordering from a staged file (Acquisitions module) This hint WILL NOT show when: - Batch modifying items - Editing existing items Test plan: 1. Apply patch 2. Add an item to a biblio record. Notice there is a hint message for the 952$d (date acquired) subfield. 3. Edit an existing item. Notice there is no hint message displaying for the 952$d subfield. 4. Batch modify an item by submitting an item barcode into Tools > Batch item modification. Notice no hint message is displayed for the 952$d subfield. 5. Receive a serial (The subscription must be setup to create an item upon receival to test this). 6. Notice there is a hint message displaying for the 952$d (Date acquired) subfield in both the main issue you are receiving and the supplemental issue form as well 7. In the Acquisitions module place an order from a purchase suggestion. Confirm the hint message is displayed for the Date acquired field. 8. In the Acquisitions module place an order from a staged file. Confirm the hint message is displayed for the Date acquired field. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30931 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #21 from Alex Buckley <alexbuckley@catalyst.net.nz> --- (In reply to Hammat wele from comment #19)
Test Plan:
1. Apply patch
2. Add an item to a biblio record. Notice there is a hint message for Date acquired field.
3. Edit an existing item. Notice there is no hint message displaying for the Date acquired field.
4. Batch modify an item by submitting an item barcode into Tools > Batch item modification. Notice no hint message is displayed for the Date acquired.
5. Receive a Serial edition by changing status of issue to 'Arrived'. Notice there is a hint message for Date acquired field.
6. But When ordering a purchase suggestions (Acquisitions) there is no hint message displaying for the Date acquired field. The hint message should be displayed
Thank you for testing Hammat. I have attached an amended patch (the alternate patch), which displays the date accessioned field hint when ordering from a purchase suggestion and from a staged file. Could you please re-test? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30931 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com Status|Needs Signoff |Signed Off --- Comment #22 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- (In reply to Alex Buckley from comment #21)
(In reply to Hammat wele from comment #19)
Test Plan:
1. Apply patch
2. Add an item to a biblio record. Notice there is a hint message for Date acquired field.
3. Edit an existing item. Notice there is no hint message displaying for the Date acquired field.
4. Batch modify an item by submitting an item barcode into Tools > Batch item modification. Notice no hint message is displayed for the Date acquired.
5. Receive a Serial edition by changing status of issue to 'Arrived'. Notice there is a hint message for Date acquired field.
6. But When ordering a purchase suggestions (Acquisitions) there is no hint message displaying for the Date acquired field. The hint message should be displayed
Thank you for testing Hammat.
I have attached an amended patch (the alternate patch), which displays the date accessioned field hint when ordering from a purchase suggestion and from a staged file.
Could you please re-test?
Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30931 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #23 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Alex Buckley from comment #0)
This bug report is for the community to decide which of the following is desired for handling of the dateaccessioned field in the item editor:
1. A hint - To tell users if they leave the items.dateaccessioned field (which is typically linked to the 952$d subfield) empty when adding a new item in serials, cataloguing, or acquisitions then Koha will automatically save the current date in that field.
OR
2. Context-aware behaviour - Koha only pre-fills the item editor dateaccessioned field with the current date when the item is added/new.
Shifting this discussion away from bug 29963 so the community can proceed to upstream the reversion of bug 29815
As I understand, the first patch is meant to revert 29815 but why doesnt it revert the plugin then? cataloguing/value_builder/dateaccessioned.pl Changing status. Please explain. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30931 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33931 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30931 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #24 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Hey Alex, I recently got Bug 37398 into main. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 Do think these patches are still needed with Bug 37398 now in main? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30931 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Failed QA |RESOLVED --- Comment #25 from Alex Buckley <alexbuckley@catalyst.net.nz> --- (In reply to Lucas Gass (lukeg) from comment #24)
Hey Alex,
I recently got Bug 37398 into main.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398
Do think these patches are still needed with Bug 37398 now in main?
Hi Lucas, Thanks for your question, yes in my humble opinion these patches are not needed anymore with Bug 37398 now in main, as that patchset improves the date picking UX. That being the case, I will close this bug report. If anyone else disagrees and feels like this patchset should be progressed please feel free to take over this bug report. Kind regards, Alex *** This bug has been marked as a duplicate of bug 37398 *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org