http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10666 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt@gmail.com |fridolyn.somers@biblibre.co | |m --- Comment #1 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 19998 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19998&action=edit Bug 10666 - Daily quotes tests are failing See commit message. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10666 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19998|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 20001 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20001&action=edit Bug 10666 - Daily quotes tests are failing In t/db_dependent/Koha.t, the test "Got a quote based on today's date" is failing : $prove t/db_dependent/Koha.t : t/db_dependent/Koha.t .. 1/6 # Failed test 'Got a quote based on today's date.' # at t/db_dependent/Koha.t line 126. # Compared $data->{"source"} # got : 'Herbert Hoover' # expect : 'Abraham Lincoln' # Be sure to run this test on a clean install of sample data. # Looks like you failed 1 test of 4. Looks like the wrong quote is returned by GetDailyQuote(). I'm using a databased created with the English sample SQL datas. I think I found the cause : The test "Got a random quote." calls GetDailyQuote('random'=>1) which changes the quote timestamp to now. When then testing GetDailyQuote(), this quote (which may not be the one created by test) is the most recent quote. This patch moves the "Got a random quote." test after "Got a quote based on today's date" to solve the problem. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10666 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #3 from Galen Charlton <gmcharlt@gmail.com> --- Works for me, and since it would be nice to make Jenkins happy (and hopefully no longer have it noisily report essentially false test suite failures), I've pushed this to master. Fridolyn, thanks! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10666 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.4. Thanks Fridolyn! -- You are receiving this mail because: You are watching all bug changes.