[Bug 41618] New: Add item data in marc returned by the api
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41618 Bug ID: 41618 Summary: Add item data in marc returned by the api Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs@lists.koha-community.org Reporter: shi-yao.wang@inLibro.com QA Contact: testopia@bugs.koha-community.org CC: tomascohen@gmail.com The export tool in cataloging exports biblios with item data in the 952 field by default. It would be nice if the /biblios api did the same -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41618 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |shi-yao.wang@inLibro.com |ity.org | CC| |caroline.cyr-la-rose@inlibr | |o.com, | |philippe.blouin@inlibro.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41618 --- Comment #1 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 191440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191440&action=edit Bug 41618: Add item metadata in biblios get and list API results Test plan: 1- Make an API request to both /biblios and /biblios/{biblio_id} 2- Notice the 952 field for items is missing for both 3- Apply patch 4- Repeat step 1 and notice item metadata is there in 952 field 5- Run `prove t/db_dependent/Koha/Objects/Record/Collections.t` There should be no side effect to /deleted/biblios or /authorities API -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41618 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41618 --- Comment #2 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- I like this. I would like it to be controlled on the API request by `x-koha-embed: items` though. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41618 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- oops. Clicked too fast. I meant for consistency on the API and for not changing behavior. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41618 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191440|0 |1 is obsolete| | --- Comment #4 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 191496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191496&action=edit Bug 41618: Add item metadata in biblios get and list API results Test plan: 1- Make an API request to both /biblios and /biblios/{biblio_id} 2- Notice the 952 field for items is missing for both 3- Apply patch 4- Repeat step 1 and notice item metadata is there in 952 field 5- Run `prove t/db_dependent/Koha/Objects/Record/Collections.t` There should be no side effect to /deleted/biblios or /authorities API -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41618 --- Comment #5 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 191497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191497&action=edit Bug 41618: Add x-koha-embed 'items' flag to preserve default behavior -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41618 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41618 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41618 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191496|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41618 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191497|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41618 --- Comment #6 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 196926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196926&action=edit Bug 41618: Add item metadata in biblios get and list API results Test plan: 1- Make an API request to both /biblios and /biblios/{biblio_id} 2- Notice the 952 field for items is missing for both 3- Apply patch 4- Repeat step 1 and notice item metadata is there in 952 field 5- Run `prove t/db_dependent/Koha/Objects/Record/Collections.t` There should be no side effect to /deleted/biblios or /authorities API Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41618 --- Comment #7 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 196927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196927&action=edit Bug 41618: Add x-koha-embed 'items' flag to preserve default behavior Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41618 --- Comment #8 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 196928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196928&action=edit Bug 41618: (follow-up) Use hashref for print_collection parameters Per coding guidelines, methods with more than one parameter must use a hashref. Change print_collection signature from: $rs->print_collection($format, $embed_items) To: $rs->print_collection({ format => $format, embed_items => $embed_items }) Update all callers in Biblios, DeletedBiblios, Authorities controllers and existing unit tests. Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41618 --- Comment #9 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 196929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196929&action=edit Bug 41618: (follow-up) Add tests for embed items in MARC responses Unit tests (Collections.t): - print_collection without embed_items: no 952 fields - print_collection with embed_items: 952 present, barcode verified API integration tests (biblios.t): - get() subtest: single biblio with/without x-koha-embed: items - list() subtest: biblio list with/without x-koha-embed: items Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41618 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41618 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add item data in marc |Add item data in MARC |returned by the api |records returned by the API -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41618 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org