[Bug 20688] New: Add accesskeys for hold confirmation boxes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20688 Bug ID: 20688 Summary: Add accesskeys for hold confirmation boxes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com When checking out a book that is already checked out to another patron the confirmation boxes display "Yes, check out (Y)" and the HTML has an "accesskey" element to allow confirmation via the keyboard We should duplicate the same functionality for hold confirmation boxes (and probably elsewhere eventually) I suggest: "c" Confirm hold (C) "p" Confirm hold and print (P) "i" Ignore (I) "x" Cancel hold (X) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20688 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20688 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Component|Circulation |Templates -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20688 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20688 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 121418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121418&action=edit Bug 20688: Add accesskeys to hold modals This patch adds accesskey elements to the hold modals during checkin For tips on how to access the accesskeys: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/accesske... To test: 1 - Place some holds on items 2 - Check in an item with a hold at a branch that requires transfer 3 - Use accesskey I to ignore 4 - Use accesskey Y to confirm and transfer 5 - Check in again 6 - Use accesskey Y to confirm 7 - Repeat 4-6 with a new hold but use the accesskey P to print the slip 8 - Check in the item again ans use accesskey X to cancel -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20688 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 121419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121419&action=edit Bug 20688: Add accesskeys for transfers To test: 1 - Disable AutomaticItemReturn systme preference 2 - Check in an item that does not float at a branch no it's home 3 - Test new accesskeys for I,N,Y,P 4 - With transfer confirmed check the item in at a wrong branch 5 - Test accesskeys Y,P,X -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20688 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20688 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20688 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121418|0 |1 is obsolete| | Attachment #121419|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 121432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121432&action=edit Bug 20688: Add accesskeys to hold modals This patch adds accesskey elements to the hold modals during checkin For tips on how to access the accesskeys: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/accesske... To test: 1 - Place some holds on items 2 - Check in an item with a hold at a branch that requires transfer 3 - Use accesskey I to ignore 4 - Use accesskey Y to confirm and transfer 5 - Check in again 6 - Use accesskey Y to confirm 7 - Repeat 4-6 with a new hold but use the accesskey P to print the slip 8 - Check in the item again ans use accesskey X to cancel Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20688 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 121433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121433&action=edit Bug 20688: Add accesskeys for transfers To test: 1 - Disable AutomaticItemReturn systme preference 2 - Check in an item that does not float at a branch no it's home 3 - Test new accesskeys for I,N,Y,P 4 - With transfer confirmed check the item in at a wrong branch 5 - Test accesskeys Y,P,X Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20688 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Can you please rebase? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 20688: Add accesskeys to hold modals Applying: Bug 20688: Add accesskeys for transfers error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt). error: could not build fake ancestor Patch failed at 0001 Bug 20688: Add accesskeys for transfers The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-20688-Add-accesskeys-for-transfers-nNbAY7.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20688 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20688 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121432|0 |1 is obsolete| | --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 123295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123295&action=edit Bug 20688: Add accesskeys to hold modals This patch adds accesskey elements to the hold modals during checkin For tips on how to access the accesskeys: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/accesske... To test: 1 - Place some holds on items 2 - Check in an item with a hold at a branch that requires transfer 3 - Use accesskey I to ignore 4 - Use accesskey Y to confirm and transfer 5 - Check in again 6 - Use accesskey Y to confirm 7 - Repeat 4-6 with a new hold but use the accesskey P to print the slip 8 - Check in the item again ans use accesskey X to cancel Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20688 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121433|0 |1 is obsolete| | --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 123296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123296&action=edit Bug 20688: Add accesskeys for transfers To test: 1 - Disable AutomaticItemReturn systme preference 2 - Check in an item that does not float at a branch no it's home 3 - Test new accesskeys for I,N,Y,P 4 - With transfer confirmed check the item in at a wrong branch 5 - Test accesskeys Y,P,X Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20688 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
For tips on how to access the accesskeys: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/accesske...
This was really helpful, thx! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20688 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20688 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123295|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 124229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124229&action=edit Bug 20688: Add accesskeys to hold modals This patch adds accesskey elements to the hold modals during checkin For tips on how to access the accesskeys: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/accesske... To test: 1 - Place some holds on items 2 - Check in an item with a hold at a branch that requires transfer 3 - Use accesskey I to ignore 4 - Use accesskey Y to confirm and transfer 5 - Check in again 6 - Use accesskey Y to confirm 7 - Repeat 4-6 with a new hold but use the accesskey P to print the slip 8 - Check in the item again ans use accesskey X to cancel Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20688 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123296|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 124230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124230&action=edit Bug 20688: Add accesskeys for transfers To test: 1 - Disable AutomaticItemReturn systme preference 2 - Check in an item that does not float at a branch no it's home 3 - Test new accesskeys for I,N,Y,P 4 - With transfer confirmed check the item in at a wrong branch 5 - Test accesskeys Y,P,X Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20688 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I believe the info on how to access the accesskeys with different browsers would make a nice addition somewhere in the manual. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20688 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20688 --- Comment #12 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20688 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20688 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Templates |Circulation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20688 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31419 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org