[Bug 5698] New: Provide datepicker for sql reports runtime parameters
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5698 Summary: Provide datepicker for sql reports runtime parameters Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Reports AssignedTo: gmcharlt@gmail.com ReportedBy: oleonard@myacpl.org QAContact: koha-bugs@lists.koha-community.org Estimated Hours: 0.0 It would be helpful if a datepicker widget could be tied to particular reports runtime parameters. It would be logical to integrate it with the current syntax for using authorized values. The authorized values syntax looks like this: <<Question to ask|authorised_value>> For date fields, you could do: <<Last seen|date>> ...and have the script check for the "date" parameter. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5698 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- *** Bug 7640 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5698 --- Comment #2 from Ian Walls <koha.sekjal@gmail.com> --- Created attachment 8136 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8136&action=edit Bug 5698: Add date picker option to SQL Runtime Parameters Adds a date picker for SQL reports with the 'date' authorised_value. Updates help documentation for this new feature, as well. To test: 1. Create a new report with two date parameters, using the syntax: <<Label for this selection of date|date>> 2. Run the report 3. Select dates 4. The SQL generated should format the dates properly in ISO, and keep track of which date is which -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5698 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |koha.sekjal@gmail.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5698 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |koha.sekjal@gmail.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5698 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8136|0 |1 is obsolete| | --- Comment #3 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 8138 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8138&action=edit Bug 5698: Add date picker option to SQL Runtime Parameters Adds a date picker for SQL reports with the 'date' authorised_value. Updates help documentation for this new feature, as well. To test: 1. Create a new report with two date parameters, using the syntax: <<Label for this selection of date|date>> 2. Run the report 3. Select dates 4. The SQL generated should format the dates properly in ISO, and keep track of which date is which Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5698 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |jcamins@cpbibliography.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5698 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5698 --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 8220 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8220&action=edit Followup proposed for discussion QA Comment, Hi Ian, Your patch works as expected. But I am annoyed the html code is generated in the perl script (ok, it is the code style of this page...). What do you think about this patch ? It is not clean, but perhaps a bit better ? :-/ I can understand if you do not agree with it and in this case I will pass QA your patch. It is just a proposition ;) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5698 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5698 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #5 from Ian Walls <koha.sekjal@gmail.com> --- I agree that generating the code in the Perl is less than optimal. That's how it works for all the other SQL params, so rather than rearchitect the whole section, I just carried through on the existing paradigm. But, that said, your solution is much more elegant, and does the same job. Marking as Signed off and Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5698 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5698 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> --- patch and follow-up pushed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5698 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |rel_3_8 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5698 --- Comment #7 from Nicole C. Engard <nengard@gmail.com> --- I just did a pull on master, but don't see this feature. Nicole -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5698 --- Comment #8 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to comment #7)
I just did a pull on master, but don't see this feature. Nicole, when I test/push, I do that locally, then push on public repo, after some push.
I changed the status less than 2 hours ago, it's still not on public repo, pushed just on my local git ;-) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5698 --- Comment #9 from Nicole C. Engard <nengard@gmail.com> --- Okey Dokey! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5698 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #10 from Nicole C. Engard <nengard@gmail.com> --- Love it! Works Awesome!! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org