[Bug 26925] New: Pickup library list should be in alphabetical order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26925 Bug ID: 26925 Summary: Pickup library list should be in alphabetical order Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com When we fetch the list of valid pickup locations for placing a hold on the staff client, we grab a separate list of valid locations for each item on that bib, put each of those sub-lists in alphabetical order, and then string them together. We need to alphabetize the entire list at the end. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26925 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26925 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 112995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112995&action=edit Bug 26925: Sort pickup locations for biblio Currently we fetch the pickup locations for each item on the biblio, then we remove duplicates. Each items locations are sorted alphabetically, however, we don't ensure the final list is ordered To test: 1 - Find a title with items from two different libraries 2 - Create two library groups and select 'is local hold group' 3 - Place the libraries of the items in separate groups with differing libraries 4 - Attempt to place a hold for the title in the staff client 5 - Note the "Pickup at" list is not in alphabetical order 6 - Apply patch 7 - Restart all and reload 8 - Pickup locations are now sorted correctly -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26925 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26925 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112995|0 |1 is obsolete| | --- Comment #2 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 113005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113005&action=edit Bug 26925: Sort pickup locations for biblio Currently we fetch the pickup locations for each item on the biblio, then we remove duplicates. Each items locations are sorted alphabetically, however, we don't ensure the final list is ordered To test: 1 - Find a title with items from two different libraries 2 - Create two library groups and select 'is local hold group' 3 - Place the libraries of the items in separate groups with differing libraries 4 - Attempt to place a hold for the title in the staff client 5 - Note the "Pickup at" list is not in alphabetical order 6 - Apply patch 7 - Restart all and reload 8 - Pickup locations are now sorted correctly Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26925 --- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Oh, missing a step in the test plan. One must set one's hold pickup branch policy to Item's Hold Group. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26925 --- Comment #4 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- a jQuery bandaid in the meantime: if ( $('#circ_request').length ) { var select = $('#pickup'); select.html(select.find('option').sort(function(x, y) { return $(x).text() > $(y).text() ? 1 : -1; })); } -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26925 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113005|0 |1 is obsolete| | --- Comment #5 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 113017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113017&action=edit Bug 26925: Sort pickup locations for biblio Currently we fetch the pickup locations for each item on the biblio, then we remove duplicates. Each items locations are sorted alphabetically, however, we don't ensure the final list is ordered To test: 1 - Find a title with items from two different libraries 2 - Create two library groups and select 'is local hold group' 3 - Place the libraries of the items in separate groups with differing libraries 4 - Attempt to place a hold for the title in the staff client 5 - Note the "Pickup at" list is not in alphabetical order 6 - Apply patch 7 - Restart all and reload 8 - Pickup locations are now sorted correctly Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26925 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26925 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Patch no longer applies, please rebase! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26925 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26925 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Patch doesn't apply |RESOLVED --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- *** This bug has been marked as a duplicate of bug 28202 *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org