[Bug 42708] New: Itemtype images no longer displayed on the holdings table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42708 Bug ID: 42708 Summary: Itemtype images no longer displayed on the holdings table Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 41566 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41566 [Bug 41566] Tidy kohaTable block - catalogue -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42708 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42708 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 199616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199616&action=edit Bug 42708: (bug 41566 follow-up) Restore display of itemtype images
- [% UNLESS noItemTypeImages %] + if (prefs.noItemTypeImages){
This is wrong! Test plan: Go to /cgi-bin/koha/catalogue/detail.pl?biblionumber=4 Notice that with this patch the "Book" icon is displayed Turn off noItemTypeImages and reload => It's now hidden! Without this patch the behavior is reversed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42708 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42708 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression, | |rel_26_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42708 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42708 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199616|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42708 --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 199635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199635&action=edit Bug 42708: (bug 41566 follow-up) Restore display of itemtype images
- [% UNLESS noItemTypeImages %] + if (prefs.noItemTypeImages){
This is wrong! Test plan: Go to /cgi-bin/koha/catalogue/detail.pl?biblionumber=4 Notice that with this patch the "Book" icon is displayed Turn off noItemTypeImages and reload => It's now hidden! Without this patch the behavior is reversed Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42708 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes showing item release notes| |type images in the staff | |interface holdings table. | | | |Item type images weren't | |showing where | |noItemTypeImages was set to | |"Show", and were showing | |when it was set to "Don't | |show" (the opposite of what | |it should be). | | | |The correct behavour for | |the noItemTypeImages system | |preference is now restored: | |- If set to "Show", the | |item type image is shown. | |- If set to "Don't show", | |the item type image is not | |shown. | | | |(This was a regression from | |bug 41566 - Tidy kohaTable | |block - catalogue, added to | |Koha 26.05.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42708 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |Laura.escamilla@bywatersolu |y.org |tions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42708 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199635|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42708 --- Comment #3 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 199679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199679&action=edit Bug 42708: (bug 41566 follow-up) Restore display of itemtype images
- [% UNLESS noItemTypeImages %] + if (prefs.noItemTypeImages){
This is wrong! Test plan: Go to /cgi-bin/koha/catalogue/detail.pl?biblionumber=4 Notice that with this patch the "Book" icon is displayed Turn off noItemTypeImages and reload => It's now hidden! Without this patch the behavior is reversed Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42708 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42708 --- Comment #4 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42708 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.11.00 |26.11.00,26.05.01 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42708 --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to 26.05.x for the upcoming 26.05.01 release. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org