[Bug 8079] New: opac not showing fines - says 'no'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8079 Priority: P5 - low Change sponsored?: --- Bug ID: 8079 CC: gmcharlt@gmail.com Assignee: kyle.m.hall@gmail.com Summary: opac not showing fines - says 'no' Severity: normal Classification: Unclassified OS: All Reporter: nengard@gmail.com Hardware: All Status: NEW Version: master Component: Circulation Product: Koha Created attachment 9524 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9524&action=edit staff shows fines In the OPAC under the fines column on the 'checked out' tab it always says 'No' See attached. In the staff client there are fines on the items, but in the OPAC it says 'No'. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8079 --- Comment #1 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 9525 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9525&action=edit opac says no -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8079 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- It appears that only charges of the types F and L are counted, but not FU. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8079 --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 15276 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15276&action=edit Bug 8079 - opac not showing fines - says 'no' Make charges of type FU be counted for opac-user.pl Test Plan: 1) Checkout an item to a patron, back date the date due enough to create fines 2) Run fines.pl 3) Log into the patron's account via the OPAC 4) Note the fines line for that issue says 'No' 5) Apply patch 6) Reload opac-user.pl, not the fines column now says 'Yes' -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8079 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8079 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15276|0 |1 is obsolete| | --- Comment #4 from David Cook <dcook@prosentient.com.au> --- Created attachment 15333 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15333&action=edit Bug 8079 - opac not showing fines - says 'no' Make charges of type FU be counted for opac-user.pl Test Plan: 1) Checkout an item to a patron, back date the date due enough to create fines 2) Run fines.pl 3) Log into the patron's account via the OPAC 4) Note the fines line for that issue says 'No' 5) Apply patch 6) Reload opac-user.pl, not the fines column now says 'Yes' Signed-off-by: David Cook <dcook@prosentient.com.au> Works great, Kyle. Seeing as my test patron had $4500 in fines for that item, I was glad to see that column switch to "Yes" ;). I'm not sure what the difference is between FU and F is, or what L means, but the patch works, so I'm signing off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8079 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8079 --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Just so you know, FU is the fee code for a fine currently accruing ( you cannot pay off fines still accruing iirc ). When the item is returned, the code is switched to F. A lost item fee has a code of L. Kyle (In reply to comment #4)
Created attachment 15333 [details] [review] Bug 8079 - opac not showing fines - says 'no'
Make charges of type FU be counted for opac-user.pl
Test Plan: 1) Checkout an item to a patron, back date the date due enough to create fines 2) Run fines.pl 3) Log into the patron's account via the OPAC 4) Note the fines line for that issue says 'No' 5) Apply patch 6) Reload opac-user.pl, not the fines column now says 'Yes'
Signed-off-by: David Cook <dcook@prosentient.com.au>
Works great, Kyle. Seeing as my test patron had $4500 in fines for that item, I was glad to see that column switch to "Yes" ;).
I'm not sure what the difference is between FU and F is, or what L means, but the patch works, so I'm signing off.
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8079 --- Comment #6 from Nicole C. Engard <nengard@gmail.com> --- (In reply to comment #5)
Just so you know, FU is the fee code for a fine currently accruing ( you cannot pay off fines still accruing iirc ). When the item is returned, the code is switched to F. A lost item fee has a code of L.
Yes you can pay a fine in FU - and always have been able to - something a lot of libraries like :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8079 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jwagner@ptfs.com --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 5688 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8079 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8079 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15333|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 15481 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15481&action=edit [PASSED QA] Bug 8079 - opac not showing fines - says 'no' Make charges of type FU be counted for opac-user.pl Test Plan: 1) Checkout an item to a patron, back date the date due enough to create fines 2) Run fines.pl 3) Log into the patron's account via the OPAC 4) Note the fines line for that issue says 'No' 5) Apply patch 6) Reload opac-user.pl, not the fines column now says 'Yes' Signed-off-by: David Cook <dcook@prosentient.com.au> Works great, Kyle. Seeing as my test patron had $4500 in fines for that item, I was glad to see that column switch to "Yes" ;). I'm not sure what the difference is between FU and F is, or what L means, but the patch works, so I'm signing off. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> This works as described, all tests and QA script are ok. Note: why show yes and not the fine amount? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8079 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de QA Contact| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8079 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8079 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x and 3.8.x will be in 3.10.3 and 3.8.10 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org