[Bug 22195] New: Change default DataTables configuration to consolidate buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22195 Bug ID: 22195 Summary: Change default DataTables configuration to consolidate buttons Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Target Milestone: --- Created attachment 84336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84336&action=edit Screen capture showing the new button style DataTables gives us the option of more carefully controlling the arrangement and appearance of buttons like "Column visibility." I propose to change the default DataTables configuration so that tables with columns settings have two buttons: One to trigger a menu of columns show show/hide, and one to trigger a menu of export options. See attached screenshot. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22195 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22195 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 84337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84337&action=edit Bug 22195: Change default DataTables configuration to consolidate buttons This patch changes the default DataTables configuration provided by the columns settings include file. It consolidates DataTables buttons into to menus: One for column configuration and one for export options. This change would not affect tables which aren't set up for column configuration. To test, apply the patch and view a page with columns configuration. Example: Tools -> Notices & slips - Confirm that the buttons appear as expected. - Confirm that each button menu performs its task correctly (column visiblity, export, print). - Test other pages with columns configuration. For instance: Acquisitions order search, Currencies administration, Holds queue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22195 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22195 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84337|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 84391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84391&action=edit Bug 22195: Change default DataTables configuration to consolidate buttons This patch changes the default DataTables configuration provided by the columns settings include file. It consolidates DataTables buttons into to menus: One for column configuration and one for export options. This change would not affect tables which aren't set up for column configuration. To test, apply the patch and view a page with columns configuration. Example: Tools -> Notices & slips - Confirm that the buttons appear as expected. - Confirm that each button menu performs its task correctly (column visiblity, export, print). - Test other pages with columns configuration. For instance: Acquisitions order search, Currencies administration, Holds queue Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22195 José-Mario Monteiro-Santos <jose-mario.monteiro-santos@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84391|0 |1 is obsolete| | --- Comment #3 from José-Mario Monteiro-Santos <jose-mario.monteiro-santos@inlibro.com> --- Created attachment 84442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84442&action=edit Bug 22195: Change default DataTables configuration to consolidate buttons This patch changes the default DataTables configuration provided by the columns settings include file. It consolidates DataTables buttons into to menus: One for column configuration and one for export options. This change would not affect tables which aren't set up for column configuration. To test, apply the patch and view a page with columns configuration. Example: Tools -> Notices & slips - Confirm that the buttons appear as expected. - Confirm that each button menu performs its task correctly (column visiblity, export, print). - Test other pages with columns configuration. For instance: Acquisitions order search, Currencies administration, Holds queue Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jose-Mario Monteiro-Santos <jose-mario.monteiro-santos@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22195 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I like that it takes up less space, but I am a little worried about it being less self-explanatory. Could we get a tooltip showing when you leave the cursor on the icon? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22195 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22195 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84442|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 84443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84443&action=edit Bug 22195: Change default DataTables configuration to consolidate buttons This patch changes the default DataTables configuration provided by the columns settings include file. It consolidates DataTables buttons into to menus: One for column configuration and one for export options. This change would not affect tables which aren't set up for column configuration. To test, apply the patch and view a page with columns configuration. Example: Tools -> Notices & slips - Confirm that the buttons appear as expected. - Confirm that each button menu performs its task correctly (column visiblity, export, print). - Test other pages with columns configuration. For instance: Acquisitions order search, Currencies administration, Holds queue Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jose-Mario Monteiro-Santos <jose-mario.monteiro-santos@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22195 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 84450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84450&action=edit Bug 22195: (follow-up) Add tooltip to buttons This patch adds title attributes and Bootstrap tooltips to the columns configuration and export/print butttons. To test, apply the patch and visit a page with columns configuration buttons. Confirm that when you hover over each of the DataTable control buttons a tooltip is shown. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22195 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 84629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84629&action=edit Bug 22195: (follow-up) Add text labels to buttons if window is wide enough This patch adds responsive handling of text labels to the columns configuration and export buttons. To test, apply the patch and clear your browser cache if necessary. - View a page with column configuration, e.g. Administration -> Patron categories. - At wider browser widths the buttons should have text labels. - At narrower browser widths the labels should be hidden. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22195 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22261 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22261 [Bug 22261] Revise style of DataTables menus -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22195 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22195 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|22261 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22261 [Bug 22261] Revise style of DataTables menus -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22195 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |RESOLVED --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Cosmetic enhancement, will not be backported. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org