http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7572 --- Comment #1 from Kyle M Hall <kyle.m.hall@gmail.com> 2012-02-21 19:31:53 UTC --- Created attachment 7790 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7790 Clubs & Services This features adds the ability to create clubs and services which patrons may be enrolled in. It is particularly useful for tracking summer reading programs, book clubs and other such clubs. It includes 2 built-in service archetypes: Bestsellers Club : Batch generate a holds list which shuffles the holds queue when new items matching a given title or author are catalogued. New Items Weekly Mailing Lists : Create custom mailing lists to alert subscribers to new items in your library. This code has been in production for a number of years at the Crawford County Federated Library System. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7572 --- Comment #2 from Kyle M Hall <kyle.m.hall@gmail.com> 2012-02-21 20:02:49 UTC --- Created attachment 7792 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7792 Clubs & Services This features adds the ability to create clubs and services which patrons may be enrolled in. It is particularly useful for tracking summer reading programs, book clubs and other such clubs. It includes 2 built-in service archetypes: Bestsellers Club : Batch generate a holds list which shuffles the holds queue when new items matching a given title or author are catalogued. New Items Weekly Mailing Lists : Create custom mailing lists to alert subscribers to new items in your library. This code has been in production for a number of years at the Crawford County Federated Library System. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7572 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7572 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7792|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle.m.hall@gmail.com> 2012-02-27 15:38:24 UTC --- Created attachment 7904 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7904 Bug 7572 - Add Clubs & Services Feature This features adds the ability to create clubs and services which patrons may be enrolled in. It is particularly useful for tracking summer reading programs, book clubs and other such clubs. It includes 2 built-in service archetypes: Bestsellers Club : Batch generate a holds list which shuffles the holds queue when new items matching a given title or author are catalogued. New Items Weekly Mailing Lists : Create custom mailing lists to alert subscribers to new items in your library. This code has been in production for a number of years at the Crawford County Federated Library System. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7572 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8102|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle.m.hall@gmail.com> --- Created attachment 8103 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8103&action=edit Bug 7572 - Add Clubs & Services Feature This features adds the ability to create clubs and services which patrons may be enrolled in. It is particularly useful for tracking summer reading programs, book clubs and other such clubs. It includes 2 built-in service archetypes: Bestsellers Club : Batch generate a holds list which shuffles the holds queue when new items matching a given title or author are catalogued. New Items Weekly Mailing Lists : Create custom mailing lists to alert subscribers to new items in your library. This code has been in production for a number of years at the Crawford County Federated Library System. Test Plan: 1) Add clubs & services permissions for a librarian account. 2) Create a new archetype 3) Create a new club or service based on the archetype 4) Enroll a borrower in the club or service 5) Cancel the enrollment in the club or service 6) Verify the permissions work correctly by turning off each one in turn and attempt to perform the action that should be denied. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7572 --- Comment #8 from Liz Rea <wizzyrea@gmail.com> --- It appears that when creating a club or service archetype, both the title and description are required, but are not labeled as such. Furthermore, if you try and create a service or club archetype and you don't enter a title or description, it lets you submit, but doesn't add the archetype and gives no error. It is the same condition for adding individual clubs and services. So I suggest that we mark the title and description as required, and have some checking done that will alert users as to *why* their archetype isn't created if they persist in trying to submit the form without the required fields. I'm up in the air as to whether this precludes inclusion or getting my signoff - it's an easy followup. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7572 --- Comment #10 from Kyle M Hall <kyle.m.hall@gmail.com> --- New patch adds form validation for title and description as per Liz Rea's comments. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7572 --- Comment #12 from Liz Rea <wizzyrea@gmail.com> --- (also, awesome, will grab the new patch right now and check it out. :)) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7572 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #14 from Liz Rea <wizzyrea@gmail.com> --- Falling back to patching base and 3-way merge... Auto-merging C4/Auth.pm Auto-merging cataloguing/addbiblio.pl Auto-merging circ/circulation.pl Auto-merging installer/data/mysql/kohastructure.sql CONFLICT (content): Merge conflict in installer/data/mysql/kohastructure.sql Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/members-menu.inc Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt Most of those are trivial changes. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7572 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7572 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9616|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall <kyle.m.hall@gmail.com> --- Created attachment 10169 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10169&action=edit Bug 7572 - Add Clubs & Services Feature This features adds the ability to create clubs and services which patrons may be enrolled in. It is particularly useful for tracking summer reading programs, book clubs and other such clubs. It includes 2 built-in service archetypes: Bestsellers Club : Batch generate a holds list which shuffles the holds queue when new items matching a given title or author are catalogued. New Items Weekly Mailing Lists : Create custom mailing lists to alert subscribers to new items in your library. This code has been in production for a number of years at the Crawford County Federated Library System. Test Plan: 1) Add clubs & services permissions for a librarian account. 2) Create a new archetype 3) Create a new club or service based on the archetype 4) Enroll a borrower in the club or service 5) Cancel the enrollment in the club or service 6) Verify the permissions work correctly by turning off each one in turn and attempt to perform the action that should be denied. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7572 --- Comment #18 from Marc Véron <veron@veron.ch> --- Patch did not apply. I tried to resolve it using git am -iu3 (...), got it to apply. However I got errors running updatedatabase.pl, removed Line 5250 (<<<..) that was alredy in the patch, droped all tables that were alreade created by the first run, and run updatedatabase.pl again. BTW, the SQL statements in updatedatabase.pl contain backticks (`). Got JavaScript Eror while Editing Clubs & Services (Calendar not defined), not sure if any follwoing JavaScript then is broken (validations etc.) On a patrons checkout page the menu at the left is doubled, I suppose it is a conflict with the new layout. Anyway, I could then follow the test plan and enroll a patron to a club (and cancel as well), both in the staff client and in the Opac. Then I was a little bit lost in testing. It took a while until I found out that a self made Club Archetype *must* have the title "Bestsellers Club" to trigger holdings, see ClubsAndServices.pm line 1175: $sth = $dbh->prepare("SELECT * FROM clubsAndServicesArchetypes WHERE title LIKE 'Bestsellers Club' "); Adding items for biblios with matching titles somtimes placed a hold for the patron and sometimes not. Could not find out why. Maybe it is due to some misconfiguration related to my try to resolve the patch issue. It seems to be a great and promising feature, but for now I am stuck. For a new test with a rebased patch I would really appreciate a more complete description of the overall concept and functionality (Wiki?) and a more detailed testing plan. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7572 --- Comment #20 from Marc Véron <veron@veron.ch> --- Created attachment 11431 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11431&action=edit Java Script Error related to Calendar -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7572 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Kyle, I think the hardcoded description "Bestsellers Club" sounds like a translation problem? Not sure as I have not tested the patch yet, only wondering while reading through this. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7572 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Kyle, I have read through the code and there are some issues with this patch: 1) Can you please add the new permisson for all languages? English is ok - easier to add a translation than figuring out a missing permission. 2) Some of the perl files have strict, but not warnings, can you add use Modern::Perl? 3) The Templates don't follow the capitalization rules. Examples: Start Date End Date You Are Not Enrolled In Any Clubs Or Services 4) This will not work for other languages, as noted in some of the earlier comments: $sth = $dbh->prepare("SELECT * FROM clubsAndServicesArchetypes WHERE title LIKE 'Bestsellers Club' "); Also: +# This script utilizes the 'New Items E-mail List' archetype +# from the ClubsAndServices.pm module. +# If you do not have this archtype, create an archetype of that name 5) If I read the code correctly, this is another translation problem, adding a hardcoded note to the hold: + my $notes = "Automatic Reserve for Bestsellers Club", 6) I wonder about the error messages - from reading the code I am not totally sure but I think they are also not translatable. + <div>Reason: <strong>[% failureMessage %]</strong></div> 7) Could you add documenation to the database tables? I was wondering about the line: + `casaId` int(11) NOT NULL default '0' COMMENT 'foreign key to clubsAndServicesArchetypes', - not sure if COMMENT is a mysqlism. We had some discussion about following the standard in one of the IRC meetings and agreed on using -- comment in the end. But I don't remember exactly why. 8) Another translation issue is the preset data you add in kohastructure.sql. Also adding data to the tables is normally done by separate sql files, while kohastructure is only creating the table structure without any data. +-- Preset data for ClubsAndServicesArchetypes +-- + +INSERT INTO `clubsAndServicesArchetypes`... 9) There is a conflict marker in updatedatabase.pl and the version should be set to be XXX. +<<<<<<< HEAD $DBversion = "3.09.00.005"; 10) There is some untranslatable JavaScript too. Example: + alert("Title is a required field"); + alert("Description is a required field"); 11) There is a large block of code commented out. Maybe delete it, if it's not needed? +<!-- These messages are uneccessary because you can see if it was deleted or created immediately... Also some typos in there 'Archtype'. 12) It looks like the old calendar is being used? Not sure here. + <img src="/intranet-tmpl/prog/en/lib/calendar/cal.gif" alt="Show Calendar" border="0" id="CalendarStartDate" style="cursor: pointer;" /> 13) Ok, now I found something really big :( The doc states: HTML::Template file mailinglist.tmpl Also: +use HTML::Template::Pro; And then: +++ b/misc/cronjobs/mailinglist/mailinglist.tmpl This needs to be redone to use TT. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7572 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7572 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12350|0 |1 is obsolete| | --- Comment #27 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 12351 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12351&action=edit Bug 7572 - Add Clubs & Services Feature This features adds the ability to create clubs and services which patrons may be enrolled in. It is particularly useful for tracking summer reading programs, book clubs and other such clubs. It includes 2 built-in service archetypes: Bestsellers Club : Batch generate a holds list which shuffles the holds queue when new items matching a given title or author are catalogued. New Items Weekly Mailing Lists : Create custom mailing lists to alert subscribers to new items in your library. This code has been in production for a number of years at the Crawford County Federated Library System. Test Plan: 1) Add clubs & services permissions for a librarian account. 2) Create a new archetype 3) Create a new club or service based on the archetype 4) Enroll a borrower in the club or service 5) Cancel the enrollment in the club or service 6) Verify the permissions work correctly by turning off each one in turn and attempt to perform the action that should be denied. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7572 --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Kyle, thx for reworking your patch! I took a quick look at the last of the attached patches and found some more "use stricts" - could you check? Thx. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7572 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12351|0 |1 is obsolete| | --- Comment #31 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 12354 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12354&action=edit Bug 7572 - Add Clubs & Services Feature -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7572 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12354|0 |1 is obsolete| | --- Comment #32 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 14744 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14744&action=edit Bug 7572 - Add Clubs & Services Feature This features adds the ability to create clubs and services which patrons may be enrolled in. It is particularly useful for tracking summer reading programs, book clubs and other such clubs. It includes 2 built-in service archetypes: Bestsellers Club : Batch generate a holds list which shuffles the holds queue when new items matching a given title or author are catalogued. New Items Weekly Mailing Lists : Create custom mailing lists to alert subscribers to new items in your library. This code has been in production for a number of years at the Crawford County Federated Library System. Test Plan: 1) Add clubs & services permissions for a librarian account. 2) Create a new archetype 3) Create a new club or service based on the archetype 4) Enroll a borrower in the club or service 5) Cancel the enrollment in the club or service 6) Verify the permissions work correctly by turning off each one in turn and attempt to perform the action that should be denied. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7572 Frederic Durand <frederic.durand@unilim.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic.durand@unilim.fr --- Comment #33 from Frederic Durand <frederic.durand@unilim.fr> --- Trying to test it on a sandbox, did not work, here the message : Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging C4/Auth.pm CONFLICT (content): Merge conflict in C4/Auth.pm Auto-merging cataloguing/addbiblio.pl Auto-merging circ/circulation.pl Auto-merging installer/data/mysql/de-DE/mandatory/userflags.sql CONFLICT (content): Merge conflict in installer/data/mysql/de-DE/mandatory/userflags.sql Auto-merging installer/data/mysql/de-DE/mandatory/userpermissions.sql CONFLICT (content): Merge conflict in installer/data/mysql/de-DE/mandatory/userpermissions.sql Auto-merging installer/data/mysql/en/mandatory/userflags.sql CONFLICT (content): Merge conflict in installer/data/mysql/en/mandatory/userflags.sql Auto-merging installer/data/mysql/en/mandatory/userpermissions.sql CONFLICT (content): Merge conflict in installer/data/mysql/en/mandatory/userpermissions.sql Auto-merging installer/data/mysql/es-ES/mandatory/userflags.sql CONFLICT (content): Merge conflict in installer/data/mysql/es-ES/mandatory/userflags.sql Auto-merging installer/data/mysql/es-ES/mandatory/userpermissions.sql CONFLICT (content): Merge conflict in installer/data/mysql/es-ES/mandatory/userpermissions.sql Auto-merging installer/data/mysql/fr-FR/1-Obligatoire/userflags.sql CONFLICT (content): Merge conflict in installer/data/mysql/fr-FR/1-Obligatoire/userflags.sql Auto-merging installer/data/mysql/fr-FR/1-Obligatoire/userpermissions.sql CONFLICT (content): Merge conflict in installer/data/mysql/fr-FR/1-Obligatoire/userpermissions.sql Auto-merging installer/data/mysql/it-IT/necessari/userflags.sql CONFLICT (content): Merge conflict in installer/data/mysql/it-IT/necessari/userflags.sql Auto-merging installer/data/mysql/it-IT/necessari/userpermissions.sql CONFLICT (content): Merge conflict in installer/data/mysql/it-IT/necessari/userpermissions.sql Auto-merging installer/data/mysql/kohastructure.sql CONFLICT (content): Merge conflict in installer/data/mysql/kohastructure.sql Auto-merging installer/data/mysql/nb-NO/1-Obligatorisk/userflags.sql CONFLICT (content): Merge conflict in installer/data/mysql/nb-NO/1-Obligatorisk/userflags.sql Auto-merging installer/data/mysql/nb-NO/1-Obligatorisk/userpermissions.sql CONFLICT (content): Merge conflict in installer/data/mysql/nb-NO/1-Obligatorisk/userpermissions.sql Auto-merging installer/data/mysql/pl-PL/mandatory/userflags.sql CONFLICT (content): Merge conflict in installer/data/mysql/pl-PL/mandatory/userflags.sql Auto-merging installer/data/mysql/pl-PL/mandatory/userpermissions.sql CONFLICT (content): Merge conflict in installer/data/mysql/pl-PL/mandatory/userpermissions.sql Auto-merging installer/data/mysql/ru-RU/mandatory/permissions_and_user_flags.sql CONFLICT (content): Merge conflict in installer/data/mysql/ru-RU/mandatory/permissions_and_user_flags.sql Auto-merging installer/data/mysql/uk-UA/mandatory/permissions_and_user_flags.sql CONFLICT (content): Merge conflict in installer/data/mysql/uk-UA/mandatory/permissions_and_user_flags.sql Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt Failed to merge in the changes. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7572 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7572 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11430|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7572 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17905|0 |1 is obsolete| | --- Comment #35 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 17906 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17906&action=edit Bug 7572 - Add Clubs & Services Feature This features adds the ability to create clubs and services which patrons may be enrolled in. It is particularly useful for tracking summer reading programs, book clubs and other such clubs. It includes 2 built-in service archetypes: Bestsellers Club : Batch generate a holds list which shuffles the holds queue when new items matching a given title or author are catalogued. New Items Weekly Mailing Lists : Create custom mailing lists to alert subscribers to new items in your library. This code has been in production for a number of years at the Crawford County Federated Library System. Test Plan: 1) Add clubs & services permissions for a librarian account. 2) Create a new archetype 3) Create a new club or service based on the archetype 4) Enroll a borrower in the club or service 5) Cancel the enrollment in the club or service 6) Verify the permissions work correctly by turning off each one in turn and attempt to perform the action that should be denied. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7572 Campbell Reid-Tait <campbellreidtait@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |campbellreidtait@gmail.com --- Comment #36 from Campbell Reid-Tait <campbellreidtait@gmail.com> --- Did not apply at first. Needed to solve some conflicts. Could not seem to add any new archtypes. But that might just be me doing somthing wrong. Also on the Modify Professional patron page, on the sidebar for the Clubs and services label there is an extra "> at the start. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7572 --- Comment #38 from Kyle M Hall <kyle@bywatersolutions.com> --- We could easily modify the new items list script to select records created within the last X days, and have at least one item. (In reply to David Cook from comment #37)

I created a "weekly mailing list" type feature as well recently. I haven't uploaded it yet (due to time constraints and possible intersection with this patch), but it seems to be a bit different.

I'm wondering...why would the mailing list be for new "items" rather than new "bibliographic records"? In my case, I opted for the latter, as I thought it made more sense to email people when a new record has been catalogued as it represented a completely new material that they might find interesting.

If you send mailing lists based on items, couldn't you be receiving emails about items that already exist in the system? Or do you only send out emails for new items for a bib where there haven't been items before? I could see that being quite useful.

The downside of my feature is that you might add a record but not have any items attached, so while people would know about the new record, they wouldn't be able to really "use" it.

Could you explain a bit more about how the mailing lists work, Kyle?

-- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7572 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17906|0 |1 is obsolete| | --- Comment #39 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25176 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25176&action=edit Bug 7572 - Add Clubs & Services Feature This features adds the ability to create clubs and services which patrons may be enrolled in. It is particularly useful for tracking summer reading programs, book clubs and other such clubs. It includes 2 built-in service archetypes: Bestsellers Club : Batch generate a holds list which shuffles the holds queue when new items matching a given title or author are catalogued. New Items Weekly Mailing Lists : Create custom mailing lists to alert subscribers to new items in your library. This code has been in production for a number of years at the Crawford County Federated Library System. Test Plan: 1) Add clubs & services permissions for a librarian account. 2) Create a new archetype 3) Create a new club or service based on the archetype 4) Enroll a borrower in the club or service 5) Cancel the enrollment in the club or service 6) Verify the permissions work correctly by turning off each one in turn and attempt to perform the action that should be denied. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7572 wajasu <matted-34813@mypacks.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |matted-34813@mypacks.net -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7572 --- Comment #41 from David Cook <dcook@prosentient.com.au> --- I'm curious why you've marked this one as resolved won't fix, Kyle. Is it because of no progress on the bug or other reasons? I'd still be interested in this going forward at some stage. -- You are receiving this mail because: You are watching all bug changes.