[Bug 19402] New: Date of birth datepicker year range depending on current value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19402 Bug ID: 19402 Summary: Date of birth datepicker year range depending on current value Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Bug 18447 sets for date of birth a year range "c-100:c" meaning current year and 100 years earlier. This is good when imput is empty. But when input already contains a date, say "01/01/1950", years range is 1850 to 1950. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19402 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |18447 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447 [Bug 18447] Datepicker only shows -10/+10 years for date of birth -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19402 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19402 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19402 --- Comment #1 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 67543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67543&action=edit Bug 19402: Date of birth datepicker year range not depending on current value Bug 18447 sets for date of birth a year range "c-100:c" meaning current year and 100 years earlier. This is good when imput is empty. But when input already contains a date, say "01/01/1950", years range is 1850 to 1950. This patch sets for date of birth a year range "-120:+0" to not be dependent on current value. Some people may have more than 100 years (maybe more often in the future) so i choose to propose maximum 120 years old. To test : 1) Go to intranet 2) Create a new patron 3) Click on date picker on "Date of birth" input 4) Look at available years in combobox, you see from 1897 to 2017 5) Edit an existing patron with for example date of birth in 1950 6) Repeat 3) and 4) 7) Go to OPAC 8) Login with a patron with for example date of birth in 1950 9) Go to "your personal details" 10) Repeate 3) and 4) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19402 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19402 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Fridolin SOMERS from comment #0)
But when input already contains a date, say "01/01/1950", years range is 1850 to 1950.
Hmm...this is not what I see - if I edit a patron with a birth year of 1950 the datepicker goes from 1850 to 2017 - no matter how far back I set the year I can always slide the dropdown forward to 2017 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19402 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67543|0 |1 is obsolete| | --- Comment #3 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 67574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67574&action=edit Bug 19402: Date of birth datepicker year range not depending on current value Bug 18447 sets for date of birth a year range "c-100:c" meaning current year and 100 years earlier. This is good when imput is empty. But when input already contains a date, say "01/01/1950", years range is 1850 to 1950. This patch sets for date of birth a year range "-120:+0" to not be dependent on current value. Some people may have more than 100 years (maybe more often in the future) so i choose to propose maximum 120 years old. To test : 1) Go to intranet 2) Create a new patron 3) Click on date picker on "Date of birth" input 4) Look at available years in combobox, you see from 1897 to 2017 5) Edit an existing patron with for example date of birth in 1950 6) Repeat 3) and 4) 7) Go to OPAC 8) Login with a patron with for example date of birth in 1950 9) Go to "your personal details" 10) Repeate 3) and 4) Followed test plan, patch worked as described. Also ran QA test tools and that passed the files modified in this patch Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19402 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |alexbuckley@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19402 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |julian.maurice@biblibre.com |y.org | CC| |julian.maurice@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19402 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #4 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Nick Clemens from comment #2)
(In reply to Fridolin SOMERS from comment #0)
But when input already contains a date, say "01/01/1950", years range is 1850 to 1950.
Hmm...this is not what I see - if I edit a patron with a birth year of 1950 the datepicker goes from 1850 to 2017 - no matter how far back I set the year I can always slide the dropdown forward to 2017
Same. Fridolin, can you test this again and tell if the patch is still useful ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19402 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|In Discussion |RESOLVED --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Closing, please reopen if still needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org