[Bug 33655] New: z39.50 search no longer shows search in progress
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33655 Bug ID: 33655 Summary: z39.50 search no longer shows search in progress Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: bwsdonna@gmail.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl With 22.11 when adding a new bib record via z39.50 import there is no longer any indication that a search has been submitted. Previously, the cursor icon would change to the busy status, but now there is no change so there is no way to know if the search has been submitted or not. This leads to staff submitting the same search repeatedly. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33655 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- On what version of Koha did this previously work for you? I would love to implement something like I proposed in Bug 30437 here. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33655 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I was wondering too - maybe only on the advanced editor? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33655 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org, | |phil@chetcolibrary.org Blocks| |32072 --- Comment #3 from Phil Ringnalda <phil@chetcolibrary.org> --- The basic editor, in 22.05. This is a regression from bug 32072, because https://git.koha-community.org/Koha-community/Koha/src/commit/9c039d4716a099... sets cursor: wait on click of a thing with the class "submit" but the submit button for a Z39.50 search no longer has that class. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32072 [Bug 32072] Consistent classes for primary buttons: Cataloging -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33655 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com Depends on| |32072 Blocks|32072 | Version|22.11 |unspecified Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32072 [Bug 32072] Consistent classes for primary buttons: Cataloging -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33655 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33655 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33655 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 150964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150964&action=edit Bug 33655: z39.50 search no longer shows search in progress This patch adds an id to z39.50 search interface submit buttons so that the JavaScript event for changing the cursor can be linked to that instead of the obsolete class. The patch also adds code copied from Bug 33233 in order to make the "waiting" cursor revert to the default if the user uses the back button to return to the search form. To test, apply the patch and go to Cataloging -> New from Z39.50 - Fill in a search term and click the submit button - Your cursor should change to a "waiting" cursor while the search is performed, before you're redirected to the results. - From the results page, clicking the back button (or right-clicking the page and choosing "Back") should return you to the search form and your cursor should be a standard pointer. Perform the same test from: - Acquisitions -> Vendor -> Basket -> Add to basket -> From an external source - Authorities -> New from Z39.50/SRU -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33655 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33655 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150964|0 |1 is obsolete| | --- Comment #5 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 151040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151040&action=edit Bug 33655: z39.50 search no longer shows search in progress This patch adds an id to z39.50 search interface submit buttons so that the JavaScript event for changing the cursor can be linked to that instead of the obsolete class. The patch also adds code copied from Bug 33233 in order to make the "waiting" cursor revert to the default if the user uses the back button to return to the search form. To test, apply the patch and go to Cataloging -> New from Z39.50 - Fill in a search term and click the submit button - Your cursor should change to a "waiting" cursor while the search is performed, before you're redirected to the results. - From the results page, clicking the back button (or right-clicking the page and choosing "Back") should return you to the search form and your cursor should be a standard pointer. Perform the same test from: - Acquisitions -> Vendor -> Basket -> Add to basket -> From an external source - Authorities -> New from Z39.50/SRU Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33655 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33655 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151040|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 151045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151045&action=edit Bug 33655: z39.50 search no longer shows search in progress This patch adds an id to z39.50 search interface submit buttons so that the JavaScript event for changing the cursor can be linked to that instead of the obsolete class. The patch also adds code copied from Bug 33233 in order to make the "waiting" cursor revert to the default if the user uses the back button to return to the search form. To test, apply the patch and go to Cataloging -> New from Z39.50 - Fill in a search term and click the submit button - Your cursor should change to a "waiting" cursor while the search is performed, before you're redirected to the results. - From the results page, clicking the back button (or right-clicking the page and choosing "Back") should return you to the search form and your cursor should be a standard pointer. Perform the same test from: - Acquisitions -> Vendor -> Basket -> Add to basket -> From an external source - Authorities -> New from Z39.50/SRU Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33655 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33655 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33655 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33655 --- Comment #8 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33655 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- Missing dependecies for 22.05.x, no backport -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33655 Bug 33655 depends on bug 32072, which changed state. Bug 32072 Summary: Consistent classes for primary buttons: Cataloging https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32072 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org