[Bug 17513] New: koha-create does not set GRANTS correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17513 Bug ID: 17513 Summary: koha-create does not set GRANTS correctly Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org There is a behavior change between MySQL and MariaDB: With: CREATE DATABASE koha_kohadev; CREATE USER koha_kohadev@localhost IDENTIFIED BY 'password'; CREATE USER koha_kohadev@'%' IDENTIFIED BY 'password'; GRANT ALL PRIVILEGES ON koha_kohadev.* TO koha_kohadev; Using Mysql, as admin user: mysql> SHOW GRANTS FOR koha_kohadev@'localhost'; GRANT USAGE ON *.* TO 'koha_kohadev'@'localhost' IDENTIFIED BY PASSWORD '*2470C0C06DEE42FD1618BB99005ADCA2EC9D1E19' mysql> SHOW GRANTS FOR koha_kohadev; GRANT USAGE ON *.* TO 'koha_kohadev'@'%' IDENTIFIED BY PASSWORD '*2470C0C06DEE42FD1618BB99005ADCA2EC9D1E19' GRANT ALL PRIVILEGES ON `koha_kohadev`.* TO 'koha_kohadev'@'%' Using Mysql, as koha_user user: mysql> SHOW GRANTS FOR koha_kohadev@'localhost'; GRANT USAGE ON *.* TO 'koha_kohadev'@'localhost' IDENTIFIED BY PASSWORD <secret> mysql> SHOW GRANTS FOR koha_kohadev; GRANT USAGE ON *.* TO 'koha_kohadev'@'%' IDENTIFIED BY PASSWORD <secret> GRANT ALL PRIVILEGES ON `koha_kohadev`.* TO 'koha_kohadev'@'%' Using MariaDB, as admin user: MariaDB [(none)]> SHOW GRANTS FOR kohaçkohadev@localhost; GRANT USAGE ON *.* TO 'koha_kohadev'@'%' IDENTIFIED BY PASSWORD '*'2470C0C06DEE42FD1618BB99005ADCA2EC9D1E19 MariaDB [(none)]> SHOW GRANTS FOR kohaçkohadev; GRANT USAGE ON *.* TO 'koha_kohadev'@'%' IDENTIFIED BY PASSWORD '*'2470C0C06DEE42FD1618BB99005ADCA2EC9D1E19 GRANT ALL PRIVILEGES ON `koha_kohadev`.* TO 'koha_kohadev'@'%' So all the same so far :) But, Using MariaDB, as koha_user user: MariaDB [(none)]> SHOW GRANTS FOR kohaçkohadev@localhost; GRANT USAGE ON *.* TO 'koha_kohadev'@'%' IDENTIFIED BY PASSWORD '*'2470C0C06DEE42FD1618BB99005ADCA2EC9D1E19 MariaDB [(none)]> SHOW GRANTS FOR kohaçkohadev; ERROR 1044 (42000): Access denied for user 'koha_kohadev'@'localhost' to database 'mysql' BOOM! The installer does not parse the expected output and then raise an error. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17513 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17513 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 56922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56922&action=edit Bug 17513: Create GRANT for user@localhost in koha-create See the bug description for the details. Test plan: Use this script to create a new koha installation, using MariaDB You should not display "user koha_kohadev doesn't have enough privilege on database koha_kohadev " -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17513 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56922|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 56975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56975&action=edit [PASSED QA] Bug 17513: Create GRANT for user@localhost in koha-create See the bug description for the details. Test plan: Use this script to create a new koha installation, using MariaDB You should not display "user koha_kohadev doesn't have enough privilege on database koha_kohadev " Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17513 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17513 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Could have sworn this had been signed off.. will amend to singed off instead of passed qa -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17513 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56975|[PASSED QA] Bug 17513: |[SIGNED OFF] Bug 17513: description|Create GRANT for |Create GRANT for |user@localhost in |user@localhost in |koha-create |koha-create -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17513 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks Jonathan, great to see Maria making it to first class citizen ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17513 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17513 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17513 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17513 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56975|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 57643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57643&action=edit Bug 17513: Create GRANT for user@localhost in koha-create See the bug description for the details. Test plan: Use this script to create a new koha installation, using MariaDB You should not display "user koha_kohadev doesn't have enough privilege on database koha_kohadev " Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Confirm that this still works (with MySQL). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17513 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|tomascohen@gmail.com |m.de.rooy@rijksmuseum.nl Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17513 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17513 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17513 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> --- Pushed to 3.22.x, will be in 3.22.13 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17513 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko@abunchofthings.net, | |mtj@kohaaloha.com --- Comment #8 from Mirko Tietgen <mirko@abunchofthings.net> --- Should go into 16.05 too please, I just ran into it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17513 --- Comment #9 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.06 release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org