[Bug 32516] New: SIP2 no block flag on renewals is passed, but not used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32516 Bug ID: 32516 Summary: SIP2 no block flag on renewals is passed, but not used Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org C4/SIP/ILS.pm 429 sub renew { 430 my ($self, $patron_id, $patron_pwd, $item_id, $title_id, 431 $no_block, $nb_due_date, $third_party, no_block does not appear elsewhere in the routine -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32516 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12225 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225 [Bug 12225] SIP does not respect the "no block" flag -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32516 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32516 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Marking as major - this is a behaviour change from bug 12225 - it seems we have allowed machines to send the no-block in the past and treated it as a normal checkin - now we die on calling a non-existent routine We should add real support for this, but until we do we should stop failing -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32516 Bug 32516 depends on bug 12225, which changed state. Bug 12225 Summary: SIP does not respect the "no block" flag https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32516 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Is this still a major Nick? I've just stumbled into it when working through fee acknowledgement fixes.. but I must admit, I've not come across this one in real life yet. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32516 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32515 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32516 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |normal --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- I think we saw that some vendors started failing on upgrade because of this, and that's why I marked major. Bug 32515 may have mitigated the issue for us. Marking as normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32516 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marion.durand@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org