[Bug 10773] New: Replace item-level codes with names/descriptions for Label Printing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773 Bug ID: 10773 Summary: Replace item-level codes with names/descriptions for Label Printing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label printing Assignee: cnighswonger@foundations.edu Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org Currently, if you include "ccode","homebranch","holdingbranch","location", or "permanent_location" when printing labels, you'll end up with a code rather than a descriptive name/label. While I don't know how often you would necessarily use all of these, I have had a request come in for a label (instead of a code) for "homebranch" as they want their labels to include their library name. Makes sense to me. We already do it with item type. Collection code might be another one or location/permanent_location, depending on how they work their collections. "Holdingbranch" probably never but best perhaps to throw it in for good measure... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Created attachment 20520 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20520&action=edit Bug 10773 - Replace item-level codes with names/descriptions for Label Printing This patch replaces item-level codes for certain fields so that names and descriptions are printed out instead of codes when using the Label Creator. The fields in question are "ccode", "homebranch", "holdingbranch", "location", and "permanent_location". Test Plan: 1) Edit a layout in the Label Creator so that it includes any of these fields. I suggest including "homebranch" and perhaps "ccode" if you have them in your item data. 2) Add items to a batch in the Label Creator. 3) Export the batch using the layout, and view as PDF 4) Note how the codes for homebranch (and ccode if available) come up instead of the name of the homebranch (and ccode). 5) Apply patch 6) Export the batch again 7) Note how the branch name and category name are now displaying instead of the codes that showed before. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|cnighswonger@foundations.ed |dcook@prosentient.com.au |u | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20520|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 20541 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20541&action=edit Bug 10773 - Replace item-level codes with names/descriptions for Label Printing This patch replaces item-level codes for certain fields so that names and descriptions are printed out instead of codes when using the Label Creator. The fields in question are "ccode", "homebranch", "holdingbranch", "location", and "permanent_location". Test Plan: 1) Edit a layout in the Label Creator so that it includes any of these fields. I suggest including "homebranch" and perhaps "ccode" if you have them in your item data. 2) Add items to a batch in the Label Creator. 3) Export the batch using the layout, and view as PDF 4) Note how the codes for homebranch (and ccode if available) come up instead of the name of the homebranch (and ccode). 5) Apply patch 6) Export the batch again 7) Note how the branch name and category name are now displaying instead of the codes that showed before. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20541|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 21285 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21285&action=edit Bug 10773 - Replace item-level codes with names/descriptions for Label Printing This patch replaces item-level codes for certain fields so that names and descriptions are printed out instead of codes when using the Label Creator. The fields in question are "ccode", "homebranch", "holdingbranch", "location", and "permanent_location". Test Plan: 1) Edit a layout in the Label Creator so that it includes any of these fields. I suggest including "homebranch" and perhaps "ccode" if you have them in your item data. 2) Add items to a batch in the Label Creator. 3) Export the batch using the layout, and view as PDF 4) Note how the codes for homebranch (and ccode if available) come up instead of the name of the homebranch (and ccode). 5) Apply patch 6) Export the batch again 7) Note how the branch name and category name are now displaying instead of the codes that showed before. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- One question, might it not still be useful to be able to print the codes directly for terseness? Since printing the code is the current default, perhaps these should be ccode_description, homebranch_description, etc instead? I have no idea if or how these codes are used in practice, so I do not feel qualified to make such a call, but I think it's a pertinent question at least. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773 --- Comment #5 from David Cook <dcook@prosentient.com.au> --- (In reply to Kyle M Hall from comment #4)
One question, might it not still be useful to be able to print the codes directly for terseness? Since printing the code is the current default, perhaps these should be ccode_description, homebranch_description, etc instead? I have no idea if or how these codes are used in practice, so I do not feel qualified to make such a call, but I think it's a pertinent question at least.
Certainly a pertinent question, Kyle! I was pondering it last week a little bit. I was wondering if any libraries print their branch code on their spine label or on other labels they might apply to resources. I would think that printing on the spine label would be a bizarre choice, but I suppose one never knows... I like the idea of "ccode_description, homebranch_description, etc.", although I can't remember how straightforward those would be to implement. Still, as you say, since the code is the current default, it might make more sense to add a new option rather than changing the default. If this change were pushed, we might find some libraries quite surprised that their labels suddenly are very different. As far as I know, I only have one library using the branch code, and they're the ones who wanted the description, but like I was saying...you never know. I'll have to ponder this one some more at some point... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dpavlin@rot13.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773 --- Comment #6 from Dobrica Pavlinusic <dpavlin@rot13.org> --- Created attachment 34539 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34539&action=edit Bug 10773 - Add item-level descriptions for Label Printing This patch adds new fields ccode_description, homebranch_description, holdingbranch_description, location_description and permanent_location_description which can be used in the Label Creator to display names/descriptions instead of codes Test Plan: 1) Edit a layout in the Label Creator so that it includes any of these fields. I suggest including "homebranch_description" and perhaps "ccode_description" if you have them in your item data. 2) Add items to a batch in the Label Creator. 3) Export the batch using the layout, and view as PDF 4) Verify that you see descriptions for fields which you added -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #7 from Dobrica Pavlinusic <dpavlin@rot13.org> --- Adding all new fields as *_description wasn't that hard after all, and since we also need holdingbranch_description for one of our libraries I decided to throw my hat into ring and write patch with implements it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Replace item-level codes |Add item-level descriptions |with names/descriptions for |for Label Printing |Label Printing | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21285|0 |1 is obsolete| | --- Comment #8 from Dobrica Pavlinusic <dpavlin@rot13.org> --- Created attachment 34634 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34634&action=edit Bug 10773 - add help for *_description fields -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773 paxed <pasi.kallinen@pttk.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pasi.kallinen@pttk.fi --- Comment #9 from paxed <pasi.kallinen@pttk.fi> --- (In reply to Dobrica Pavlinusic from comment #8)
Created attachment 34634 [details] [review] Bug 10773 - add help for *_description fields
Typo "Fileds" in there -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34634|0 |1 is obsolete| | --- Comment #10 from Dobrica Pavlinusic <dpavlin@rot13.org> --- Created attachment 35031 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35031&action=edit Bug 10773 - add help for *_description fields -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773 --- Comment #11 from Dobrica Pavlinusic <dpavlin@rot13.org> --- (In reply to paxed from comment #9)
(In reply to Dobrica Pavlinusic from comment #8)
Created attachment 34634 [details] [review] [review] Bug 10773 - add help for *_description fields
Typo "Fileds" in there
Thanks, fixed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|dcook@prosentient.com.au |dpavlin@rot13.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34539|0 |1 is obsolete| | --- Comment #12 from Nick Clemens <nick@quecheelibrary.org> --- Created attachment 36051 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36051&action=edit [SIGNED OFF] Bug 10773 - Add item-level descriptions for Label Printing This patch adds new fields ccode_description, homebranch_description, holdingbranch_description, location_description and permanent_location_description which can be used in the Label Creator to display names/descriptions instead of codes Test Plan: 1) Edit a layout in the Label Creator so that it includes any of these fields. I suggest including "homebranch_description" and perhaps "ccode_description" if you have them in your item data. 2) Add items to a batch in the Label Creator. 3) Export the batch using the layout, and view as PDF 4) Verify that you see descriptions for fields which you added Signed-off-by: Nick <Nick@quechelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35031|0 |1 is obsolete| | --- Comment #13 from Nick Clemens <nick@quecheelibrary.org> --- Created attachment 36052 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36052&action=edit [SIGNED OFF]Bug 10773 - add help for *_description fields Signed-off-by: Nick <Nick@quechelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36051|0 |1 is obsolete| | Attachment #36052|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 36085 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36085&action=edit [PASSED QA] Bug 10773 - Add item-level descriptions for Label Printing This patch adds new fields ccode_description, homebranch_description, holdingbranch_description, location_description and permanent_location_description which can be used in the Label Creator to display names/descriptions instead of codes Test Plan: 1) Edit a layout in the Label Creator so that it includes any of these fields. I suggest including "homebranch_description" and perhaps "ccode_description" if you have them in your item data. 2) Add items to a batch in the Label Creator. 3) Export the batch using the layout, and view as PDF 4) Verify that you see descriptions for fields which you added Signed-off-by: Nick <Nick@quechelibrary.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773 --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 36086 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36086&action=edit [PASSED QA] Bug 10773 - add help for *_description fields Signed-off-by: Nick <Nick@quechelibrary.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12553 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton@bywatersolutions.com --- Comment #16 from Chris Nighswonger <cnighswonger@foundations.edu> --- *** Bug 12553 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773 --- Comment #17 from Chris Nighswonger <cnighswonger@foundations.edu> --- Bumping the priority on this as it is causing issues for several folks at this point. It would be good to get this into the next release. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major Priority|P5 - low |P3 CC| |cnighswonger@foundations.ed | |u -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #18 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I would say this is an enhancement. But, anyway, Chris N. is about to post a followup with regression tests, so I'll be holding this until then. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773 --- Comment #19 from Chris Nighswonger <cnighswonger@foundations.edu> --- (In reply to Tomás Cohen Arazi from comment #18)
I would say this is an enhancement.
This is not the intended nor expected behavior which makes me lean toward it being a true bug.
But, anyway, Chris N. is about to post a followup with regression tests, so I'll be holding this until then.
FTR, here are my current thoughts on this: This is going to be a bit of a problem to try to mock. Notice here: http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=C4/Labels/Label.pm... we grab all of the data in 4 tables. I know that DBD::Mock allows mocking resultsets, but this would require a significant amount of coding, and it is not clear whether DBD::Mock will handle a join or not. The way I read the docs, it will not. I think the only way to do this is to make it run over a test database which means it will not be run as part of the standard test suite. I will be glad to write up a test for this, but question the value of it if it will not be run as a part of the standard test suite. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773 --- Comment #20 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Chris, tests on t/db_dependent are considered standard and are always run by the dev team and jenkins too, when pushed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #21 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Dobrica! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #22 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.6 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Severity|major |enhancement -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773 --- Comment #23 from David Cook <dcook@prosentient.com.au> --- Finally took the time to look at this one again... thanks indeed Dobrica! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773 Giannis Tsakonas <john@lis.upatras.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |john@lis.upatras.gr -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org