[Bug 39032] New: "Items selected" in item search untranslatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39032 Bug ID: 39032 Summary: "Items selected" in item search untranslatable Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: f.demians@tamil.fr, jonathan.druart@gmail.com When you select results from the item search page, a small rectangle with "Items selected:" appears. This phrase is not in any translation file (that I could find). To recreate: 1. Go to Item search 2. Click 'Search' 3. Select one or more results --> In the bar at the top of the results there is a rectangle with "Items selected: N XClear" 4. Install another language (e.g. fr-CA) 4.1. For ktd, do the following commands ktd --shell gulp po:update --lang fr-CA Ctrl+D (exit shell) ktd --root --shell koha-translate --install fr-CA --dev kohadev koha-translate --update fr-CA --dev kohadev 4.2. Go to Administration > System preferences 4.3. Search for StaffInterfaceLanguages 4.4. Check fr-CA 4.5. Click 'Save all I18N/L10N preferences' 5. Redo steps 1-3 in other language --> "Items selected" is not translated `git grep "Items selected" fr-CA*` in the translation git repo returns nothing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39032 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39032 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 177517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177517&action=edit Bug 39032: "Items selected" in item search untranslatable This patch corrects a syntax error that prevented the string "Items selected" from being picked up by the translation tool. To recreate: 1. Go to Item search 2. Click 'Search' 3. Select one or more results --> In the bar at the top of the results there is a rectangle with "Items selected: N XClear" 4. Install another language (e.g. fr-CA) 4.1. For ktd, do the following commands ktd --shell gulp po:update --lang fr-CA Ctrl+D (exit shell) ktd --root --shell koha-translate --install fr-CA --dev kohadev koha-translate --update fr-CA --dev kohadev 4.2. Go to Administration > System preferences 4.3. Search for StaffInterfaceLanguages 4.4. Check fr-CA 4.5. Click 'Save all I18N/L10N preferences' 5. Redo steps 1-3 in French --> "Items selected" is not translated 6. Apply patch 7. Update translations (for ktd) ktd --shell gulp po:update --lang fr-CA 8. Open misc/translator/po/fr-CA-staff-prog.po 9. Search for "Items selected" --> It should be there, with a fuzzy flag 10. Translate the phrase in msgstr and remove the line with the fuzzy flag 11. Apply translations (for ktd) ktd --root --shell koha-translate --update fr-CA --dev kohadev 12. Redo steps 1-3 in French --> "Items selected" is now translated! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39032 --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- QA please note that I only copied the syntax from a line a bit further down and have no idea what I'm doing... >_< -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39032 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34227 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34227 [Bug 34227] Add persistent selections and batch operations to item search -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39032 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39032 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |caroline.cyr-la-rose@inlibr |ity.org |o.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39032 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39032 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177517|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 177661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177661&action=edit Bug 39032: "Items selected" in item search untranslatable This patch corrects a syntax error that prevented the string "Items selected" from being picked up by the translation tool. To recreate: 1. Go to Item search 2. Click 'Search' 3. Select one or more results --> In the bar at the top of the results there is a rectangle with "Items selected: N XClear" 4. Install another language (e.g. fr-CA) 4.1. For ktd, do the following commands ktd --shell gulp po:update --lang fr-CA Ctrl+D (exit shell) ktd --root --shell koha-translate --install fr-CA --dev kohadev koha-translate --update fr-CA --dev kohadev 4.2. Go to Administration > System preferences 4.3. Search for StaffInterfaceLanguages 4.4. Check fr-CA 4.5. Click 'Save all I18N/L10N preferences' 5. Redo steps 1-3 in French --> "Items selected" is not translated 6. Apply patch 7. Update translations (for ktd) ktd --shell gulp po:update --lang fr-CA 8. Open misc/translator/po/fr-CA-staff-prog.po 9. Search for "Items selected" --> It should be there, with a fuzzy flag 10. Translate the phrase in msgstr and remove the line with the fuzzy flag 11. Apply translations (for ktd) ktd --root --shell koha-translate --update fr-CA --dev kohadev 12. Redo steps 1-3 in French --> "Items selected" is now translated! Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39032 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes a syntax error release notes| |that prevented the string | |"Items selected" for the | |item search from being | |picked up by the | |translation tool (the text | |is shown when items in the | |item search results are | |selected). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39032 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39032 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177661|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 178085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178085&action=edit Bug 39032: "Items selected" in item search untranslatable This patch corrects a syntax error that prevented the string "Items selected" from being picked up by the translation tool. To recreate: 1. Go to Item search 2. Click 'Search' 3. Select one or more results --> In the bar at the top of the results there is a rectangle with "Items selected: N XClear" 4. Install another language (e.g. fr-CA) 4.1. For ktd, do the following commands ktd --shell gulp po:update --lang fr-CA Ctrl+D (exit shell) ktd --root --shell koha-translate --install fr-CA --dev kohadev koha-translate --update fr-CA --dev kohadev 4.2. Go to Administration > System preferences 4.3. Search for StaffInterfaceLanguages 4.4. Check fr-CA 4.5. Click 'Save all I18N/L10N preferences' 5. Redo steps 1-3 in French --> "Items selected" is not translated 6. Apply patch 7. Update translations (for ktd) ktd --shell gulp po:update --lang fr-CA 8. Open misc/translator/po/fr-CA-staff-prog.po 9. Search for "Items selected" --> It should be there, with a fuzzy flag 10. Translate the phrase in msgstr and remove the line with the fuzzy flag 11. Apply translations (for ktd) ktd --root --shell koha-translate --update fr-CA --dev kohadev 12. Redo steps 1-3 in French --> "Items selected" is now translated! Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39032 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39032 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |Main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39032 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39032 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39032 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com Version(s)|25.05.00 |25.05.00,24.11.08 released in| | --- Comment #6 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Pushed into 24.11.x for 24.11.08 nice work everyone -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39032 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39032 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #7 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39032 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #8 from David Nind <david@davidnind.com> --- Bug fix, no updates to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org