[Bug 9462] New: Use DataTables on patron detail page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9462 Bug ID: 9462 Summary: Use DataTables on patron detail page Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org The patron detail page uses the old tablesorter plugin. It should use the DataTables plugin instead. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9462 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9462 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 14795 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14795&action=edit Bug 9462 - Use DataTables on patron detail page Replace the tablesorter plugin with the DataTables plugin on the patron detail page. To test, open a patron detail page for a patron who has checkouts, holds, and relatives' checkouts. Confirm that table sorting works correctly for each of those three tables. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9462 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Hi Owen, The holdst is really small and does not extend to the width of the container (div id="holdst_wrapper"). I don't know why, I did not find the difference with the issuest table. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9462 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- (In reply to comment #2)
The holdst is really small and does not extend to the width of the container
I noticed this on the branch transfers page as well. If you have a sorted table in a hidden tab the table doesn't expand to the width one would expect. On the branch transfers page I ended up setting an explicit min-width on the table. When I tested this patch the problem wasn't as noticeable, but that was probably due to the data I had in the table. Setting an explicit width here too could be a solution. I would like to see a screenshot if that is possible. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9462 --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 14843 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14843&action=edit Patron detail > holds table issue (In reply to comment #3)
Setting an explicit width here too could be a solution. I would like to see a screenshot if that is possible.
Yes of course. If I set a width=100% for the table element, the table appears with a good width. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9462 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14795|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 14917 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14917&action=edit Bug 9462 [Revised] Use DataTables on patron detail page Replace the tablesorter plugin with the DataTables plugin on the patron detail page. To test, open a patron detail page for a patron who has checkouts, holds, and relatives' checkouts. Confirm that table sorting works correctly for each of those three tables. Revision adds some JavaScript designed to handle table-sizing for tables which are hidden initally in tabs. DataTables has an approved method for handling these cases: http://www.datatables.net/examples/api/tabs_and_scrolling.html This should prevent the table of existing holds from looking squeezed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9462 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14917|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 15180 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15180&action=edit Bug 9462 [Revised] Use DataTables on patron detail page Replace the tablesorter plugin with the DataTables plugin on the patron detail page. To test, open a patron detail page for a patron who has checkouts, holds, and relatives' checkouts. Confirm that table sorting works correctly for each of those three tables. Revision adds some JavaScript designed to handle table-sizing for tables which are hidden initally in tabs. DataTables has an approved method for handling these cases: http://www.datatables.net/examples/api/tabs_and_scrolling.html This should prevent the table of existing holds from looking squeezed. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9462 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9462 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: The table is correctly displayed now. There is a sort issue on the barcode column if it contains something else than a barcode (e.g. "Item is waiting -barcode-"), not blocker. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9462 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15180|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 15223 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15223&action=edit Bug 9462 [Revised] Use DataTables on patron detail page Replace the tablesorter plugin with the DataTables plugin on the patron detail page. To test, open a patron detail page for a patron who has checkouts, holds, and relatives' checkouts. Confirm that table sorting works correctly for each of those three tables. Revision adds some JavaScript designed to handle table-sizing for tables which are hidden initally in tabs. DataTables has an approved method for handling these cases: http://www.datatables.net/examples/api/tabs_and_scrolling.html This should prevent the table of existing holds from looking squeezed. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9462 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org