[Bug 35987] New: See highlighted items below link broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35987 Bug ID: 35987 Summary: See highlighted items below link broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: lisette.scheer@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com On circulation.pl and moremember.pl the "see highlighted items below" link goes to #checkouts, but there is no div #checkouts instead of #checkouts_panel -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35987 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Depends on| |33528 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33528 [Bug 33528] Use template wrapper for tabs: Patron details and circulation -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35987 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Even with `*_panel` the behavior is still odd if you don't "Always show checkouts automatically". Clicking "See highlighted items below:" should expand the checkout table if it is not already. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35987 Lari Strand <lmstrand@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lmstrand@gmail.com --- Comment #2 from Lari Strand <lmstrand@gmail.com> --- Adding a double event onclick="$('#issues-table-load-immediately').click(); $('#issues-table-load-immediately').click();" to the checkouts_panel href text link fixes this without need to create a new function that checks the existence of the issues datatable (without the check I get a popup error DataTables warning: table id=issues-table - Cannot reinitialise DataTable if I press on the "See highlighted items below" text link again). It's a dirty fix that simulates two clicks on the Always show checkouts automatically checkbox. Is this acceptable? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35987 --- Comment #3 from Lari Strand <lmstrand@gmail.com> --- Created attachment 171441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171441&action=edit Bug 35987: Fix broken See highlighted items below link -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35987 Lari Strand <lmstrand@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35987 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |shi-yao.wang@inLibro.com --- Comment #4 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Can we get a test plan? https://wiki.koha-community.org/wiki/Commit_messages -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35987 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35987 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171441|0 |1 is obsolete| | --- Comment #5 from Magnus Enger <magnus@libriotech.no> --- Created attachment 173769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173769&action=edit Bug 35987: Fix broken See highlighted items below link Signed-off-by: Magnus Enger <magnus@libriotech.no> Test plan with KTD: - Issue a couple of items to a patron, and make sure one of them is overdue. - Make sure "Always show checkouts automatically" is not checked - Reload the page - Click on the link in "Overdues: Patron has ITEMS OVERDUE See highlighted items below" - Nothing happens - Apply the patch, restart_all, reload the "Check out" page for the patron - Click on the link again, and the active loans should be shown -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35987 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35987 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173769|0 |1 is obsolete| | --- Comment #6 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 174060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174060&action=edit Bug 35987: Fix broken See highlighted items below link Signed-off-by: Magnus Enger <magnus@libriotech.no> Test plan with KTD: - Issue a couple of items to a patron, and make sure one of them is overdue. - Make sure "Always show checkouts automatically" is not checked - Reload the page - Click on the link in "Overdues: Patron has ITEMS OVERDUE See highlighted items below" - Nothing happens - Apply the patch, restart_all, reload the "Check out" page for the patron - Click on the link again, and the active loans should be shown Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35987 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz QA Contact|testopia@bugs.koha-communit |aleisha@catalyst.net.nz |y.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35987 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35987 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35987 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00 |24.11.00,24.05.06 released in| | Status|Pushed to main |Pushed to stable --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.06 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35987 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35987 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Shouldnt we avoid onclick attributes ? See https://wiki.koha-community.org/wiki/Coding_Guidelines JS9: Avoid the use of event attributes like "onclick" to attach events -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35987 --- Comment #10 from Aleisha Amohia <aleisha@catalyst.net.nz> --- (In reply to Fridolin Somers from comment #9)
Shouldnt we avoid onclick attributes ? See https://wiki.koha-community.org/wiki/Coding_Guidelines JS9: Avoid the use of event attributes like "onclick" to attach events
Yes you're right - I think we decided the dirty fix was needed to correct this quickly, but we should get a better fix in that aligns with our coding guidelines -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35987 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #11 from David Cook <dcook@prosentient.com.au> --- (In reply to Fridolin Somers from comment #9)
Shouldnt we avoid onclick attributes ? See https://wiki.koha-community.org/wiki/Coding_Guidelines JS9: Avoid the use of event attributes like "onclick" to attach events
100% I'm glad this was for the staff interface and not the OPAC, as I've been working quite hard to remove all inline Javascript handlers from the OPAC in preparation of Content-Security-Policy implementation. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35987 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38756 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38756 [Bug 38756] Fix "See highlighted items below" link without using an onclick attribute -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35987 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to oldstable |Needs documenting --- Comment #12 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 unless requested -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org