http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5844 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- This bug applies to the new highlight feature on the detail page as well. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5844 --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 37273 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37273&action=edit Bug 5844: Avoid strings cut on unhighlighing If a user is searching for several words and that one is contained in another ( "mag ma" ), some characters are cut (removed from the DOM!). To reproduce: 1/ search for "mag ma m" 2/ The result page contains "Magazine" 3/ "Mag" is highlighted 4/ Click on the "Unhighlight" link 5/ The "Magazine" words become "azine", "Mag" has been cut. There is no way to show these characters again. Test plan: 1/ Confirm the bad behavior without this patch 2/ Apply this patch 3/ search for "mag ma m" 4/ The result page contains "Magazine" 5/ "Mag" is highlighted 6/ Click on the "Unhighlight" link 7/ strings are unhighlighted and still in the DOM :) Note that the Highlight link won't work very well (only "a" will be highlighted, but considered as minor since this did not work before the patch neither). -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5844 --- Comment #4 from Marc Véron <veron@veron.ch> --- Created attachment 37282 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37282&action=edit [Signed-off] Bug 5844: Avoid strings cut on unhighlighing If a user is searching for several words and that one is contained in another ( "mag ma" ), some characters are cut (removed from the DOM!). To reproduce: 1/ search for "mag ma m" 2/ The result page contains "Magazine" 3/ "Mag" is highlighted 4/ Click on the "Unhighlight" link 5/ The "Magazine" words become "azine", "Mag" has been cut. There is no way to show these characters again. Test plan: 1/ Confirm the bad behavior without this patch 2/ Apply this patch 3/ search for "mag ma m" 4/ The result page contains "Magazine" 5/ "Mag" is highlighted 6/ Click on the "Unhighlight" link 7/ strings are unhighlighted and still in the DOM :) Note that the Highlight link won't work very well (only "a" will be highlighted, but considered as minor since this did not work before the patch neither). Followed test plan. Strings are no longer cut when unhiglighted. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5844 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5844 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37282|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37317 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37317&action=edit [PASSED QA] Bug 5844: Avoid strings cut on unhighlighing If a user is searching for several words and that one is contained in another ( "mag ma" ), some characters are cut (removed from the DOM!). To reproduce: 1/ search for "mag ma m" 2/ The result page contains "Magazine" 3/ "Mag" is highlighted 4/ Click on the "Unhighlight" link 5/ The "Magazine" words become "azine", "Mag" has been cut. There is no way to show these characters again. Test plan: 1/ Confirm the bad behavior without this patch 2/ Apply this patch 3/ search for "mag ma m" 4/ The result page contains "Magazine" 5/ "Mag" is highlighted 6/ Click on the "Unhighlight" link 7/ strings are unhighlighted and still in the DOM :) Note that the Highlight link won't work very well (only "a" will be highlighted, but considered as minor since this did not work before the patch neither). Followed test plan. Strings are no longer cut when unhiglighted. Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5844 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.6 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.