[Bug 5533] New: marking item lost diff in two places
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5533 Summary: marking item lost diff in two places Change sponsored?: --- Product: Koha Version: HEAD Platform: All OS/Version: All Status: NEW Severity: critical Priority: P5 Component: Cataloging AssignedTo: gmcharlt@gmail.com ReportedBy: nengard@gmail.com QAContact: koha-bugs@lists.koha-community.org CC: ian.walls@bywatersolutions.com Estimated Hours: 0.0 Please see this screencast for details: http://screencast.com/t/6CJlMGQn2r42 Basically if you mark an item lost via edit items there is one behavior and if you mark it lost via the items tab there is another behavior. I think that the behavior that happens on the items tab is what we want (marking the item lost charges the patron the replacement fee). -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5533 --- Comment #1 from Nicole C. Engard <nengard@gmail.com> 2011-03-01 13:10:19 UTC --- Just a little bump on this one - anyone have any ideas on how we can solve this? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5533 --- Comment #2 from Nicole C. Engard <nengard@gmail.com> 2011-03-22 13:05:26 UTC --- Another update - if you mark items lost using the batch edit tool the lost items remain on the patron's record as checked out instead of being removed. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5533 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com --- Comment #3 from Ian Walls <ian.walls@bywatersolutions.com> 2011-03-25 14:42:02 UTC --- *** Bug 5953 has been marked as a duplicate of this bug. *** -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5533 --- Comment #4 from Nicole C. Engard <nengard@gmail.com> 2011-03-25 15:28:18 UTC --- Also, When an item is marked Lost and Paid For, it remains checked out to the patron. It would seem like this would mark the item lost and remove it from the patron's checked out list. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5533 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jcamins@cpbibliography.com --- Comment #5 from Jared Camins-Esakov <jcamins@cpbibliography.com> 2011-04-04 16:22:16 UTC --- The problem here is that C4::Acounts::chargelostitems is not called when items are edited through the addbiblio.pl interface. Following a discussion on IRC, it sounds like the solution is to add a wrapper around C4::Items::ModItem which handles all business logic calls (like C4::Accounts::chargelostitems). -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5533 --- Comment #6 from Nicole C. Engard <nengard@gmail.com> 2011-06-09 16:05:45 UTC --- This issue is kind of critical (if a critical issue can be 'kind of') anyone have any clues? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5533 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|gmcharlt@gmail.com |srdjan@catalyst.net.nz --- Comment #7 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2011-09-12 03:01:27 UTC --- Created attachment 5398 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5398 patch There's an issue here. I can see two sets of logic for triggering lost item processing: * catalogue/updateitem.pl: itemlost==1 * misc/cronjobs/longoverdue.pl : $charge eq $lostvalue That prevented me from placing a single call in ModItem(). So what I have done is applying itemlost==1 where it was missing (manly after ModItemFromMarc() calls) Can anyone comment on this please. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5533 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff Change sponsored?|--- |Sponsored -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5533 --- Comment #8 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2011-09-12 03:34:05 UTC --- On a related note, can anyone please state the connection with the bug 5211 http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5211 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5533 --- Comment #9 from Ian Walls <ian.walls@bywatersolutions.com> 2011-09-13 13:08:25 UTC --- Srdjan, It seems to me that what needs to happen here is what Jared suggests: we need a single subroutine to handle all the logic of marking an item Lost. Input params: * lost value: which LOST auth values to use * charge: charge the patron the replacement cost? * markreturned: check in the material? The behaviour on the item tab and the behaviour in longoverdue.pl can then be synchronized. I'm still not convinced that the edit items screen needs to include this additional logic; it's the manual way to edit an item record, and should only be done by people who know what they're doing. Hiding 'Lost' in the MARC Framework would be an easy way to prevent folks from inadvertently making the changes without properly handling all the other logic. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5533 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5398|0 |1 is obsolete| | --- Comment #10 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2011-09-20 07:18:29 UTC --- Created attachment 5473 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5473 patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5533 --- Comment #11 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2011-09-20 07:19:37 UTC --- Please have a look at the new patch comments if this is what is required. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5533 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Failed QA --- Comment #12 from Liz Rea <wizzyrea@gmail.com> 2011-09-20 19:06:22 UTC --- http://screencast.com/t/mmbWNhm1mxQ During testing for this patch, I discovered that when editing items, it appeared that changes to item records were either written to the wrong item record, or offset so as to bleed into the next item record (dk how that's possible, but the screencast illustrates). We ran into this the last time that we tried to "remove" the lost item handling from the cataloging screen using jquery. All fields were offset by 1 that time, this behavior appears to be similar. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5533 --- Comment #13 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2011-09-21 00:08:43 UTC --- Ah yes, that is my omission, disabled widgets don't get submitted. Will correct. That is why submitting multiple values for multiple connected inputs should not be used. HTTP spec actually explicitly says that the order is not guaranteed. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5533 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5473|0 |1 is obsolete| | --- Comment #14 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2011-09-21 01:14:55 UTC --- Created attachment 5486 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5486 patch Apologies for not catching that, should be fine now -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5533 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5533 --- Comment #15 from Liz Rea <wizzyrea@gmail.com> 2011-09-21 17:23:03 UTC --- Thanks for the new patch, will test today. :) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5533 --- Comment #16 from Liz Rea <wizzyrea@gmail.com> 2011-09-21 18:06:39 UTC --- Created attachment 5515 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5515 [Signed Off] bug_5533: new function C4::Circulation::LostItem($itemnumber, $mark_returned) Disabled Lost Status on cataloging full item edit longoverdue.pl calls LostItem() *without* $mark_returned Item moredetail calls LostItem() *with* $mark_returned Batch mode edit calls LostItem() *with* $mark_returned Signed-off-by: Liz Rea <lrea@nekls.org> I am happy to sign off on this new version. Editing works fine, behavior of 'lost' is as I expected. Steps to test: Check out an item with a replacement cost to a patron. Mark the item lost from moredetail.pl -> should remove the item from checked out items and apply replacement cost to the patron's fines. Check in the item -> should report "item was lost, now found" and remove the charge (apply a credit, technically) to the patron's fines. Check out several items to several patrons. Batch mod those items to lost -> should remove the item from checked out items and apply replacement cost to the patron's fines. Check in the items -> should report "item was lost, now found" and remove the charge (apply a credit, technically) to the patron's fines. Editing items:
From your test item, Edit -> Edit Items Select an item to edit Edit the item as you see fit Verify that all values are saved in correct fields, and your changes are correct. (they are) Verify that you cannot set 'lost' status from the edit item interface. (You cannot)
longoverdue.pl backdate an item so it will be long overdue run longoverdue.pl to set your item as long overdue. verify that the item is not removed from the patron's checked out items. Long Overdue does not charge the patron for the replacement. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5533 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5533 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5486|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5533 --- Comment #17 from Ian Walls <ian.walls@bywatersolutions.com> 2011-09-22 18:09:16 UTC --- In catalogue/updateitem.pl, this patch only calls LostItem if itemlost is set to 1.... what about other Lost values? This is a forward port of the way the code was before, but I think that may have been a bug... should only LOST value 1 mark the item as lost? Thoughts/opinions? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5533 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |6490 --- Comment #18 from Liz Rea <wizzyrea@gmail.com> 2011-09-23 02:12:41 UTC --- also, one thing, bug 6490 is still outstanding with lost. Might be nice to nip it while we're in here? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5533 --- Comment #19 from Ian Walls <ian.walls@bywatersolutions.com> 2011-09-23 15:02:53 UTC --- I believe that bug 6490 is outside the scope of this bug report and it's proposed fix. Let's work on getting this fix in first, then we can frame the fix for 6490 in the context of the newly added subroutines. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5533 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|6490 | --- Comment #20 from Liz Rea <wizzyrea@gmail.com> 2011-09-23 15:23:09 UTC --- totally fair :) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5533 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com --- Comment #21 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-12 10:07:15 UTC --- QA comment: Ian, as you seem to understand & investigate this one, it's for you. Not sure i'm understanding correctly everything on this topic. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5533 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Failed QA --- Comment #22 from Ian Walls <ian.walls@bywatersolutions.com> 2011-10-12 14:05:45 UTC --- Srdjan, Could you update this patch to handle LOST values greater than 1 as well, in catalogue/updateitem.pl? Another thing I'm curious about: you add a "use C4::Circulation" call to cataloguing/additem.pl, but I don't see what subroutine from C4::Circulation is used. Am I missing it? I'd like to avoid loading another huge module if at all possible. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5533 --- Comment #23 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2011-10-13 03:11:13 UTC --- To make things clear: * In catalogue/updateitem.pl we want LostItem($itemnumber, 'MARK RETURNED') if $itemlost instead of LostItem($itemnumber, 'MARK RETURNED') if ($itemlost==1) * what about tools/batchMod.pl? I will remove use C4::Circulation from cataloguing/additem.pl, probably put some code in there that got moved elsewhere. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5533 --- Comment #24 from Ian Walls <ian.walls@bywatersolutions.com> 2011-10-14 12:31:28 UTC --- Srdjan, Yes, tools/batchMod.pl should also handle cases other than itemlost == 1. Good catch. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5533 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5515|0 |1 is obsolete| | --- Comment #25 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2011-10-17 02:41:44 UTC --- Created attachment 5907 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5907 patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5533 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5533 --- Comment #26 from Nicole C. Engard <nengard@gmail.com> 2011-10-17 16:38:11 UTC --- Created attachment 5936 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5936 lost label remains This appears to work, my problem is possible a style one - and splitting hairs, but when you edit an item Lost still shows on the menu of fields but doesn't have a field. Shouldn't we remove it completely from the framework by putting it in the 'ignore' tab - like with other item fields that don't show on the record when editing? I'm running more tests now, but wanted to put this out there. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5533 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5907|0 |1 is obsolete| | --- Comment #27 from Nicole C. Engard <nengard@gmail.com> 2011-10-17 16:42:43 UTC --- Created attachment 5937 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5937 [SIGNED-OFF] bug_5533: Slightly improved marking items as lost Call LostItem() whenever item is lost. LostItem() new arg - mark returned. Disabled Lost Status on catalogue item edit. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> For follow up we need to explain how to hide the 952$1 (lost) from the framework by putting it in the 'ignore' tab. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5533 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5533 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Passed QA --- Comment #28 from Ian Walls <ian.walls@bywatersolutions.com> 2011-10-17 19:10:53 UTC --- New patch implements recommended QA changes, does not introduce new strings. We can control the display of the Lost status with the frameworks, so I'm going to mark this as Passed QA. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5533 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Passed QA |Patch Pushed --- Comment #29 from Chris Cormack <chris@bigballofwax.co.nz> 2011-10-17 20:03:14 UTC --- Pushed to master, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5533 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cnighswonger@foundations.ed | |u --- Comment #30 from Chris Nighswonger <cnighswonger@foundations.edu> 2011-10-19 20:09:53 UTC --- patch does not apply cleanly to 3.4.x due to enhancement bug 6068 which was not applied to 3.4.x. If this patch should apply to 3.4.x, please rebase over 3.4.x and attach here. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5533 --- Comment #31 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2011-10-20 01:29:46 UTC --- Created attachment 6001 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6001 patch against 3.4.x -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5533 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Patch Pushed |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5533 --- Comment #32 from Ian Walls <ian.walls@bywatersolutions.com> 2011-12-15 13:29:24 UTC --- Created attachment 6810 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6810 Proposed followup patch removes filter that was preventing Lost status from being editable in the Edit Items screen. Numerous libraries have complained about losing this ability, even when they understand it was removed to force consistent 'lost' behaviour. The default framework is altered to hide this field for new installs. It can be restored to the interface by editing the 'hidden' value for the itemlost subfield. This method hides the preference by default, but allows libraries who understand the implications of what they're doing (and accept the risks) to have more control over their workflows. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5533 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5937|0 |1 is obsolete| | Attachment #6810|0 |1 is obsolete| | --- Comment #33 from Chris Cormack <chris@bigballofwax.co.nz> 2011-12-21 00:40:37 UTC --- Created attachment 6896 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6896 Bug 5533 followup: reinstate Lost status editing The original patch for 5533 removed the Lost status from the edit items screen; new items were not affected, and batch changes could still be made, so this was not a consistent change. This patch removes the filter that hid the Lost status dropdown, but then changes the default MARC framework to hide this field by default (value -5). New installations will not see this status in the editor, unless they manually activate it. This will enforce the semantics of using the "mark lost" options by default, but provide a workaround for libraries that understand and accept the consequences of manually editing this field. To test: 1. on an existing install, edit an item. you should have the Lost status visible 2. on a new install, editing or creating an item should not show the Lost status at all Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5533 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5533 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QAContact|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5533 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6896|0 |1 is obsolete| | --- Comment #34 from Paul Poulain <paul.poulain@biblibre.com> 2012-01-17 15:03:31 UTC --- Comment on attachment 6896 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6896 Bug 5533 followup: reinstate Lost status editing this follow-up has been pushed. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5533 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #35 from Paul Poulain <paul.poulain@biblibre.com> 2012-01-17 15:04:13 UTC --- chris_n, this patch has been applied to master. Is the 3.4 patch to apply to 3.4 or has it been done ? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5533 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5533 --- Comment #36 from Chris Nighswonger <cnighswonger@foundations.edu> 2012-01-17 15:11:14 UTC --- (In reply to comment #35)
chris_n, this patch has been applied to master. Is the 3.4 patch to apply to 3.4 or has it been done ?
The 3.4.x version of this patch has been applied to the 3.4.x branch. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5533 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P3 Status|Pushed to Master |Pushed to Stable CC| |katrin.fischer@bsz-bw.de -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5533 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5533 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12311 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12311 [Bug 12311] Batch modification of checked out and lost items checks them in -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org