https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32392 --- Comment #1 from Björn Nylén <bjorn.nylen@ub.lu.se> --- Created attachment 148948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148948&action=edit Bug 32392: Enable skipping forward issues when receiving serials. Bug 32392: Enable skipping forward issues when receiving serials. This patch adds the ability to skip forward issues when receiving and generating the next issue from both the serial receive page and serial collection page. To test: 1. Apply patch. 2. Set up a subscription for a bib record. 3. Go to Serials -> Search your subscription -> Serial receive 4. Note that below last expected issue there will be checkbox to toggle a field to specify how many issues to skip when recieving and generating the next. 5. On serials-collection page there is also a button 'Skip issues and generate next'. When pressed will open a modal promting how many issues to skip. 6. Generate issues with different values and make sure the correct issue is generated. ​Sponsored-by: Lund University Library Sponsored-by: Bibliotek Mellansjö, Sweden Co-authored-by: Johan Sahlberg <johan.sahlberg@tidaholm.se> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32392 Björn Nylén <bjorn.nylen@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32392 Marie <marie.hedbom@musikverket.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |marie.hedbom@musikverket.se -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32392 Marie <marie.hedbom@musikverket.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from Marie <marie.hedbom@musikverket.se> --- (In reply to Björn Nylén from comment #1)

Created attachment 148948 [details] [review] Bug 32392: Enable skipping forward issues when receiving serials.

Bug 32392: Enable skipping forward issues when receiving serials.

This patch adds the ability to skip forward issues when receiving and generating the next issue from both the serial receive page and serial collection page.

To test: 1. Apply patch. 2. Set up a subscription for a bib record. 3. Go to Serials -> Search your subscription -> Serial receive 4. Note that below last expected issue there will be checkbox to toggle a field to specify how many issues to skip when recieving and generating the next. 5. On serials-collection page there is also a button 'Skip issues and generate next'. When pressed will open a modal promting how many issues to skip. 6. Generate issues with different values and make sure the correct issue is generated.

​Sponsored-by: Lund University Library Sponsored-by: Bibliotek Mellansjö, Sweden Co-authored-by: Johan Sahlberg <johan.sahlberg@tidaholm.se>

Signed-off-by: Marie Hedbom <marie.hedbom@musikverket.se> (first sign off, is this enough?) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32392 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33678 --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- While testing, stumbled over byg 33678 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32392 --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Do not understand why we add this to serial-EDIT here ? + $("form").on("submit", function(){ + let issues = $('input[name="skip_issues"]').val() ? $('input[name="skip_issues"]').val() : ''; + let too_many = _("Choose a value between 0-10 in issues to skip!"); + let no_number = _("Not a number in skip issues!"); + + if ( issues == '' || ( issues.match(/^\d+$/) && issues <= 10 ) ) { + return true; + } + else if ( issues.match(/^\d+$/) && issues > 10 ) { + alert(too_many); + return false; + } else if ( !issues.match(/^\d+$/) ) { + alert(no_number); + return false; + } + else { + return false; + } + }); -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32392 --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #8)

And why do we cap at 10 ?

And why dont we cap on serial-collection then ? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32392 --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Both Perl and JS allow you to write this shorter with a = b || c. Note that Perl also has a // b but this checks on defined instead of true. + my $count = $count_forward ? $count_forward : 1; + let issues = $('input[name="skip_issues"]').val() ? $('input[name="skip_issues"]').val() : ''; No blocker but less typing and errors doing so. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32392 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Failed QA --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Just raising questions here. But I spent some time here and am not confident that this change is without bugs. The whole context of Serials is quite buggy, I am afraid. Opened two new reports too. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32392 --- Comment #14 from Kevin Carnes <kevin.carnes@ub.lu.se> --- Created attachment 159617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159617&action=edit Bug 32392: Fix QA issues -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32392 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159617|0 |1 is obsolete| | --- Comment #15 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 159618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159618&action=edit Bug 32392: Fix QA issues Signed-off-by: Stina <stina.hallin@ub.lu.se> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32392 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no --- Comment #16 from Magnus Enger <magnus@libriotech.no> --- (In reply to Marie from comment #3)

Signed-off-by: Marie Hedbom <marie.hedbom@musikverket.se> (first sign off, is this enough?)

Congratulations! :-) It would be nice to say at least "followed the test plan and everything works as expected". And if you tested other things than what the test plan says that would be good to mention. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32392 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148948|0 |1 is obsolete| | --- Comment #17 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 165083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165083&action=edit Bug 32392: Enable skipping forward issues when receiving serials. This patch adds the ability to skip forward issues when receiving and generating the next issue from both the serial receive page and serial collection page. To test: 1. Apply patch. 2. Set up a subscription for a bib record. 3. Go to Serials -> Search your subscription -> Serial receive 4. Note that below last expected issue there will be checkbox to toggle a field to specify how many issues to skip when recieving and generating the next. 5. On serials-collection page there is also a button 'Skip issues and generate next'. When pressed will open a modal promting how many issues to skip. 6. Generate issues with different values and make sure the correct issue is generated. Sponsored-by: Lund University Library Sponsored-by: Bibliotek Mellansjö, Sweden Co-authored-by: Johan Sahlberg <johan.sahlberg@tidaholm.se> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32392 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159618|0 |1 is obsolete| | --- Comment #19 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 165085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165085&action=edit Bug 32392: Fix QA issues Signed-off-by: Stina <stina.hallin@ub.lu.se> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32392 Kevin Carnes <kevin.carnes@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165083|0 |1 is obsolete| | --- Comment #21 from Kevin Carnes <kevin.carnes@ub.lu.se> --- Created attachment 165729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165729&action=edit Bug 32392: Enable skipping forward issues when receiving serials. This patch adds the ability to skip forward issues when receiving and generating the next issue from both the serial receive page and serial collection page. To test: 1. Apply patch. 2. Set up a subscription for a bib record. 3. Go to Serials -> Search your subscription -> Serial receive 4. Note that below last expected issue there will be checkbox to toggle a field to specify how many issues to skip when recieving and generating the next. 5. On serials-collection page there is also a button 'Skip issues and generate next'. When pressed will open a modal promting how many issues to skip. 6. Generate issues with different values and make sure the correct issue is generated. ​Sponsored-by: Lund University Library Sponsored-by: Bibliotek Mellansjö, Sweden Co-authored-by: Johan Sahlberg <johan.sahlberg@tidaholm.se> Signed-off-by: Marie Hedbom <marie.hedbom@musikverket.se> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32392 Kevin Carnes <kevin.carnes@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165085|0 |1 is obsolete| | --- Comment #23 from Kevin Carnes <kevin.carnes@ub.lu.se> --- Created attachment 165731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165731&action=edit Bug 32392: Fix QA issues Signed-off-by: Stina <stina.hallin@ub.lu.se> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32392 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Grabbing it directly, you are a star Kevin :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32392 --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32392 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #27 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not backported to 23.11.x -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32392 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37925 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37925 [Bug 37925] When skipping issues the publication date is not moved forward -- You are receiving this mail because: You are watching all bug changes.