[Bug 21516] New: Request notes CSS bug makes them unreadable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21516 Bug ID: 21516 Summary: Request notes CSS bug makes them unreadable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: andrew.isherwood@ptfs-europe.com There's a bug in the CSS that is indirectly related to the layout of the staff and OPAC request notes. There's a 1em height specified that cascades to all divs in the containing div, this is fine for everything apart from the notes, which may need a height greater than 1em. An exception rule needs creating. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21516 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |andrew.isherwood@ptfs-europ |ity.org |e.com Status|NEW |ASSIGNED Depends on| |7317 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21516 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21516 --- Comment #1 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 80209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80209&action=edit Bug 21516: Fix incorrect CSS Override the height definition for notes fields. Test plan: (Before applying the patch) 1. Create an ILL request and modify it to add staff notes and OPAC notes, each notes field should be quite lengthy. 2. View the request and observe that the notes field lines overlap each other 3. Apply the patch 4. Observe that the notes fields now display correctly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21516 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21516 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com, oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21516 --- Comment #2 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Test plan: (Before applying the patch) 1. Create an ILL request and modify it to add staff notes and OPAC notes, each notes field should be quite lengthy. 2. View the request and observe that the notes field lines overlap each other 3. Apply the patch 4. Regenerate the CSS (npm run css) 5. Observe that the notes fields now display correctly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21516 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21516 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 82309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82309&action=edit Bug 21516: (ALTERNATE) Request notes CSS bug makes them unreadable This alternate patch makes multiple markup corrections to the ILL requests templates. It reformats the request details to use a list, making it consistent with similar interfaces (see patron details, baskets in acquisitions). The display of notes has been changed so that it uses a paragraph tag instead of <pre>. To test, apply the patch and rebuild the staff client CSS. - Manage an ILL request which has staff and OPAC notes. Everything should look readable. - Running validation on the HTML should only return warnings coming from global include files (js_includes.inc). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21516 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80209|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21516 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21516 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82309|0 |1 is obsolete| | --- Comment #4 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 82315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82315&action=edit Bug 21516: (ALTERNATE) Request notes CSS bug makes them unreadable This alternate patch makes multiple markup corrections to the ILL requests templates. It reformats the request details to use a list, making it consistent with similar interfaces (see patron details, baskets in acquisitions). The display of notes has been changed so that it uses a paragraph tag instead of <pre>. To test, apply the patch and rebuild the staff client CSS. - Manage an ILL request which has staff and OPAC notes. Everything should look readable. - Running validation on the HTML should only return warnings coming from global include files (js_includes.inc). Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21516 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21516 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82315|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 82382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82382&action=edit Bug 21516: (ALTERNATE) Request notes CSS bug makes them unreadable This alternate patch makes multiple markup corrections to the ILL requests templates. It reformats the request details to use a list, making it consistent with similar interfaces (see patron details, baskets in acquisitions). The display of notes has been changed so that it uses a paragraph tag instead of <pre>. To test, apply the patch and rebuild the staff client CSS. - Manage an ILL request which has staff and OPAC notes. Everything should look readable. - Running validation on the HTML should only return warnings coming from global include files (js_includes.inc). Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21516 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact| |m.de.rooy@rijksmuseum.nl --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- @RM: rebuild the staff client CSS ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21516 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21516 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jesse@bywatersolutions.com --- Comment #8 from Jesse Maseto <jesse@bywatersolutions.com> --- Not able to backport in to 18.05. If this is something that needs to be in 18.05 please provide an 18.05 version. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21516 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |CLOSED Resolution|--- |FIXED CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org