https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5620 --- Comment #6 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 51290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51290 bug 5620 - Capture Mode of payment, receipt number and notes in pay fines. Review of attachment 51290: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=5620&attachment=51290) ----------------------------------------------------------------- ::: C4/Accounts.pm @@ +89,4 @@

sub recordpayment {

#here we update the account lines + my ( $borrowernumber, $data, $sip_paytype, $payment_note, $paymentmode ) = @_;

"PERL16: Hashrefs should be used as arguments" Perhaps refactor is in order? There are already too many parameters. ::: installer/data/mysql/atomicupdate/bug5620_Add_Mode_Of_Payment.perl @@ +10,5 @@

+$dbh->do("alter table accountlines add column paymentmode text not null"); +$dbh->do("insert into authorised_values (category, authorised_value, lib, lib_opac) values('PAYMODE','CASH','Cash', 'Cash')"); +$dbh->do("insert into authorised_values (category, authorised_value, lib, lib_opac) values('PAYMODE','CC','Credit Card', 'Credit Card')"); +$dbh->do("insert into authorised_values (category, authorised_value, lib, lib_opac) values('PAYMODE','DEBIG','Debit', 'Debit')"); +print "bug5620 - add mode of payment";

Why not do this as a sql file? Also, missing kohastructure.sql patch. ::: members/paycollect.pl @@ +50,5 @@

+my $sth = $dbh->prepare('SELECT * FROM authorised_values WHERE category = "PAYMODE"'); +$sth->execute(); +while ( my $row = $sth->fetchrow_hashref() ) { + push @paymentmodes, $row; +}

This should probably be some nice function in some authorised value library somewhere. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.