[Bug 8845] New: Bug 7544 - Add ability search patrons by date of birth
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8845 Priority: P5 - low Change sponsored?: --- Bug ID: 8845 CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Assignee: koha-bugs@lists.koha-community.org Summary: Bug 7544 - Add ability search patrons by date of birth Severity: enhancement Classification: Unclassified OS: All Reporter: kyle@bywatersolutions.com Hardware: All Status: NEW Version: master Component: Patrons Product: Koha Some librarians would like to be able to search for patrons by date of birth. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8845 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Bug 7544 - Add ability |Add ability search patrons |search patrons by date of |by date of birth |birth | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8845 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 12601 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12601&action=edit Bug 8845 - Add ability search patrons by date of birth Adds the ability to search by dates of birth in iso format. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8845 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8845 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12601|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 12608 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12608&action=edit Bug 8845 - Add ability search patrons by date of birth Adds the ability to search by dates of birth in iso format. Signed-off-by: Marc Veron <veron@veron.ch> Searched with following formats: YYYYMMDD , YYYY-MM-DD , YYYY.MM.DD All searches are OK -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8845 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron@veron.ch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8845 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- I think it's a problem that this patch doesn't take varying date formats into account. What about searches by DD-MM-YYYY or MM-DD-YYYY? A couple of possibilities for mitigating the problem, if the patch can't be amended to accept multiple formats: - Offer a hint about the date format required - Offer a datepicker which will return the correct format Both could be triggered upon selection of the "date of birth" option. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8845 --- Comment #4 from Marc Véron <veron@veron.ch> --- I think the problem with coding is that e.g. 03-09-2012 would be ambiguous (3. September or 9. March?). Thats why I propose to give a hint, the best place would be in the selection itself, e.g. <option value='dateofbirth'>Date of birth (YYYYMMDD)</option> Marc -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8845 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- (In reply to comment #4)
I think the problem with coding is that e.g. 03-09-2012 would be ambiguous (3. September or 9. March?).
Unless you used the dateformat system preference as a rule by which you parse the date. Does Koha have existing code for handling varying date inputs? Otherwise, I agree that putting a hint in the <option> is a good idea. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8845 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 12639 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12639&action=edit Bug 8845 - Add ability search patrons by date of birth - Add tooltip -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8845 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |rel_3_12 --- Comment #7 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Changing target version so this bug report will show up in the list of 3.12-targeted features and doesn't get lost in the shuffle during feature freeze. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8845 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff CC| |jonathan.druart@biblibre.co | |m --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Last patch needs a SO -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8845 --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 14293 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14293&action=edit Bug 8845: Followup Allow to give a date using the syspref format -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8845 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14293|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@biblibre.com> --- Comment on attachment 14293 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14293 Bug 8845: Followup Allow to give a date using the syspref format Kyle, This patch allows to enter a date given the syspref format. I let you decide if it is better or not. I mark it as obsolete in order to not interfere with your last patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8845 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14293|1 |0 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8845 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14293|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 14367 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14367&action=edit Bug 8845: Followup Allow to give a date using the syspref format Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8845 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12639|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 14368 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14368&action=edit Bug 8845 - Add ability search patrons by date of birth - Add tooltip -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8845 --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- I think that is a great followup! I've updated the tooltip patch, if you can SO that patch, we can set the status to signed-off! (In reply to comment #10)
Comment on attachment 14293 [details] Bug 8845: Followup Allow to give a date using the syspref format
Kyle, This patch allows to enter a date given the syspref format. I let you decide if it is better or not. I mark it as obsolete in order to not interfere with your last patch.
-- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8845 --- Comment #14 from Jonathan Druart <jonathan.druart@biblibre.com> --- Kyle, your patch does not work: the dateformat variable is not set in the template (the tooltip is 'Dates of birth should be entered in the format ""'). (/!\ Work in progress in Bug 9108) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8845 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14368|0 |1 is obsolete| | --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 14392 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14392&action=edit Bug 8845 - Add ability search patrons by date of birth - Add tooltip -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8845 --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- Sorry about that! Please retest this updated patch! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8845 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8845 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14392|0 |1 is obsolete| | --- Comment #17 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 14393 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14393&action=edit Bug 8845 - Add ability search patrons by date of birth - Add tooltip Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Works with all date formats -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8845 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |katrin.fischer@bsz-bw.de --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Bug 8845: Followup Allow to give a date using the syspref format Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -------------------------- Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying: Bug 8845: Followup Allow to give a date using the syspref format Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging members/member.pl CONFLICT (content): Merge conflict in members/member.pl Failed to merge in the changes. Patch failed at 0001 Bug 8845: Followup Allow to give a date using the syspref format When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8845 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12608|0 |1 is obsolete| | Attachment #14367|0 |1 is obsolete| | Attachment #14393|0 |1 is obsolete| | --- Comment #19 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 15556 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15556&action=edit Bug 8845 - Add ability search patrons by date of birth Adds the ability to search by dates of birth in iso format. Signed-off-by: Marc Veron <veron@veron.ch> Searched with following formats: YYYYMMDD , YYYY-MM-DD , YYYY.MM.DD All searches are OK -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8845 --- Comment #20 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 15557 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15557&action=edit Bug 8845: Followup Allow to give a date using the syspref format Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8845 --- Comment #21 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 15558 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15558&action=edit Bug 8845 - Add ability search patrons by date of birth - Add tooltip Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Works with all date formats -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8845 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8845 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #22 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: This patch adds a new entry in the search fields dropdown list: date of birth. The functionality deals with all date formats and works as expected. Marked as Passed QA. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8845 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15556|0 |1 is obsolete| | Attachment #15557|0 |1 is obsolete| | Attachment #15558|0 |1 is obsolete| | --- Comment #23 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 18437 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18437&action=edit Bug 8845 - Add ability search patrons by date of birth Adds the ability to search by dates of birth in iso format. Signed-off-by: Marc Veron <veron@veron.ch> Searched with following formats: YYYYMMDD , YYYY-MM-DD , YYYY.MM.DD All searches are OK Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8845 --- Comment #24 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 18438 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18438&action=edit Bug 8845: Followup Allow to give a date using the syspref format Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8845 --- Comment #25 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 18439 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18439&action=edit Bug 8845 - Add ability search patrons by date of birth - Add tooltip Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Works with all date formats -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8845 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.12 |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8845 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #26 from Galen Charlton <gmcharlt@gmail.com> --- The patches do not apply. The base patch needs to be rebased to take 065fe316e into account, while the tooltip patch needs to be adjusted now that 7e10f6fb was pushed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8845 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18437|0 |1 is obsolete| | Attachment #18438|0 |1 is obsolete| | Attachment #18439|0 |1 is obsolete| | --- Comment #27 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 18508 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18508&action=edit Bug 8845 - Add ability search patrons by date of birth Adds the ability to search by dates of birth in iso format. Signed-off-by: Marc Veron <veron@veron.ch> Searched with following formats: YYYYMMDD , YYYY-MM-DD , YYYY.MM.DD All searches are OK Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8845 --- Comment #28 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 18509 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18509&action=edit Bug 8845: Followup Allow to give a date using the syspref format Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8845 --- Comment #29 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 18510 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18510&action=edit Bug 8845 - Add ability search patrons by date of birth - Add tooltip Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Works with all date formats Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8845 --- Comment #30 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 18511 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18511&action=edit Bug 8845: FIX dateonly is the 4th parameter, not 3rd! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8845 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA --- Comment #31 from Jonathan Druart <jonathan.druart@biblibre.com> --- Rebased patches. I added a patch in order to fix a variable order. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8845 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #32 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Kyle and Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8845 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10835 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org